]> rtime.felk.cvut.cz Git - sojka/can-utils.git/log
sojka/can-utils.git
12 years agoinclude: import kernel header files into tree
Marc Kleine-Budde [Fri, 2 Dec 2011 12:53:49 +0000 (13:53 +0100)]
include: import kernel header files into tree

Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Tested-by: Jan-Niklas Meier <dschanoeh@googlemail.com>
12 years agocanbusload: flush output at the end of each cycle
Kurt Van Dijck [Wed, 21 Dec 2011 09:08:57 +0000 (10:08 +0100)]
canbusload: flush output at the end of each cycle

When canbusload is piped to another program, the output
is queued for several cycles. This patch will flush the output
explicitely.

Signed-off-by: Kurt Van Dijck <kurt.van.dijck@eia.be>
13 years agocan-utils/lib: fix build issues introduced with sprintf_can_error_frame()
Wolfgang Grandegger [Mon, 14 Feb 2011 16:10:39 +0000 (16:10 +0000)]
can-utils/lib: fix build issues introduced with sprintf_can_error_frame()

Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
13 years agocandump: add option -e to dump error messages in human readable format
Wolfgang Grandegger [Mon, 14 Feb 2011 15:49:27 +0000 (15:49 +0000)]
candump: add option -e to dump error messages in human readable format

If "candump" is called with the option "-e", the error messages are
dumped in human readable format:

  # candump -e any,0:0,#FFFFFFFF
  ...
  can0  20000088  [8] 00 00 80 19 00 00 00 00   ERRORFRAME
        protocol-violation{{error-on-tx}{acknowledge-slot}}
        bus-error
        error-counter{tx{128}rx{97}}
  ...
  can0  2000008C  [8] 00 08 80 19 00 00 00 00   ERRORFRAME
        controller-problem{tx-error-warning}
        protocol-violation{{error-on-tx}{acknowledge-slot}}
        bus-error
        error-counter{tx{128}rx{97}}

"candump" actually calles a library function snprintf_can_error_frame()
to do the formatting. It could be used for other purposes as well.

Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
Acked-by: Kurt Van Dijck <kurt.van.dijck@eia.be>
13 years agocandump: Avoid ragged output of timestamp values when printing differential
Oliver Hartkopp [Wed, 19 Jan 2011 17:43:07 +0000 (17:43 +0000)]
candump: Avoid ragged output of timestamp values when printing differential
timestamps (commandline option -td).
Idea & original patch by Uwe Bonnes.

Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
13 years agocangen: set seed value for pseudo random numbers
Oliver Hartkopp [Wed, 19 Jan 2011 17:35:37 +0000 (17:35 +0000)]
cangen: set seed value for pseudo random numbers

As pointed out by Andre Naujoks the pseudo random generator should be
initialized with a seed to prevend this ugly behaviour:

$ ./cangen vcan2 -v & ./cangen vcan1 -v
[1] 5995
  vcan2  567#69.98.3C.64.73.48
  vcan1  567#69.98.3C.64.73.48
  vcan2  451#4A.94.E8.2A.EC.58.55.62
  vcan1  451#4A.94.E8.2A.EC.58.55.62
  vcan2  729#BA.58.1B.3D.AB.D7.7E.50
  vcan1  729#BA.58.1B.3D.AB.D7.7E.50
(..)

Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
13 years agoslcan_attach: added '-f' commandline option to read status flags.
Oliver Hartkopp [Sun, 9 Jan 2011 11:49:20 +0000 (11:49 +0000)]
slcan_attach: added '-f' commandline option to read status flags.

In the case of pending bus errors on some slcan adapters the read of the
status flags resets the adapter and clears the error LED.

This patch adds the commandline option to send the status read command to the
adapter as suggested by Thorsten Godau.

Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
13 years agoslcan_attach: 'close' the slcan adapter before setting a bitrate
Oliver Hartkopp [Sun, 9 Jan 2011 11:35:03 +0000 (11:35 +0000)]
slcan_attach: 'close' the slcan adapter before setting a bitrate

As investigated by Thorsten Godau the bitrate can only be set after the
slcan adapter is in 'close' state.

Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Tested-by: Thorsten Godau <dl9sec@gmx.net>
13 years agoslcand: replace char pointers with static char buffers
Oliver Hartkopp [Thu, 6 Jan 2011 19:20:18 +0000 (19:20 +0000)]
slcand: replace char pointers with static char buffers

The buffers to build the pathnames had been malloc'ed and never been free'd.
This patch removes the malloc stuff entirely.

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
13 years agocandump: Added '-u <usecs>' commandline option to delay bridged CAN frames by
Oliver Hartkopp [Mon, 29 Nov 2010 19:11:11 +0000 (19:11 +0000)]
candump: Added '-u <usecs>' commandline option to delay bridged CAN frames by
usecs microseconds.

13 years agocangen: Added '-n <count>' commandline option analogue to candump tool.
Oliver Hartkopp [Mon, 29 Nov 2010 18:58:12 +0000 (18:58 +0000)]
cangen: Added '-n <count>' commandline option analogue to candump tool.
Inspired by Uwe Bonnes.

13 years agoslcand : added new commandline option to support direct assignment of a CAN
Oliver Hartkopp [Fri, 19 Nov 2010 19:52:39 +0000 (19:52 +0000)]
slcand : added new commandline option to support direct assignment of a CAN
netdevice name to the given tty (by renaming the created netdevice).

Signed-off-by: Robert Haddon <robert.haddon@cirrascale.com>
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
13 years agoslcan_attach: Added new commandline option to specify the created netdevice name.
Oliver Hartkopp [Wed, 17 Nov 2010 11:55:46 +0000 (11:55 +0000)]
slcan_attach: Added new commandline option to specify the created netdevice name.

13 years agoslcan_attach: Print the name of the assigned netdevice after attaching the tty.
Oliver Hartkopp [Wed, 17 Nov 2010 06:59:20 +0000 (06:59 +0000)]
slcan_attach: Print the name of the assigned netdevice after attaching the tty.

13 years agoAdded new socketoptions to force the isotp protocol to intentionally
Oliver Hartkopp [Sun, 14 Nov 2010 08:55:06 +0000 (08:55 +0000)]
Added new socketoptions to force the isotp protocol to intentionally
misbehave for regression tests.

CAN_ISOTP_TX_STMIN:
Set a value in nano secs that's used as minimum CF gap by the sender.
This value is used instead of the value provided by the receiver inside the FC.

CAN_ISOTP_RX_STMIN:
Ignores received CF frames which timestamps differ less than this value in nano
secs. This is used to test the receivers misbehaviour when the receiver
provides a lower stmin value that he's able to cope with. Received CF frames
are silently dropped when they come faster than specified by this value.

13 years agoFix datatype issue in sscanf() on 64bit systems.
Oliver Hartkopp [Sat, 25 Sep 2010 10:24:37 +0000 (10:24 +0000)]
Fix datatype issue in sscanf() on 64bit systems.

On 64bit systems a 'long' is a 64bit value but the target values of scanf()
are always 32bit in the affected code - which means just an 'unsigned int'.
Unsigned int is fine on 32 and 64 bit systems.

Thanks to Andre Naujoks for reporting this issue.

13 years agoAdded support for inverted CAN ID filters.
Oliver Hartkopp [Fri, 24 Sep 2010 18:23:42 +0000 (18:23 +0000)]
Added support for inverted CAN ID filters.

13 years agoFixed calculation of needed bits on the physical wire according Ken Tindells
Oliver Hartkopp [Fri, 24 Sep 2010 17:56:53 +0000 (17:56 +0000)]
Fixed calculation of needed bits on the physical wire according Ken Tindells
*worst* case calculation for stuff-bits.
(see "Guaranteeing Message Latencies on Controller Area Network" 1st ICC'94)
Due to the bitstuffing estimation the calculated busload may exceed 100%.

13 years agocan-calc-bit-timing: remove rtcantl1
Marc Kleine-Budde [Tue, 20 Jul 2010 14:10:38 +0000 (14:10 +0000)]
can-calc-bit-timing: remove rtcantl1

No one can verify the timing parameters to be correct.

Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
13 years agocan-calc-bit-timing: add more can controller definitions and ref clocks
Marc Kleine-Budde [Tue, 20 Jul 2010 13:43:20 +0000 (13:43 +0000)]
can-calc-bit-timing: add more can controller definitions and ref clocks

Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
13 years agocan-calc-bit-timing: calculate bit timings for all known controllers by default
Marc Kleine-Budde [Tue, 20 Jul 2010 13:43:16 +0000 (13:43 +0000)]
can-calc-bit-timing: calculate bit timings for all known controllers by default

When testing or improving the bit timing algorithm, you're probably
interested in the values of all can controllers. Further you might not
know the all reference clocks of the controllers.

This patch add a "ref_clock" member to the "struct can_bittiming_const"
that holds the reference clock of the controller in Hz.

By default now the bit timing is calculated for all known can
controllers with the default ref_clock defined in "can_bittiming_const".

It's still possible to overwrite the ref clock with the command line
option "-c".

Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
13 years agocan-calc-bit-timing: improve printing of bit timing parameters
Marc Kleine-Budde [Tue, 20 Jul 2010 13:43:12 +0000 (13:43 +0000)]
can-calc-bit-timing: improve printing of bit timing parameters

This patch adds additional fields when printing the bit timing
parameters. Now the real bitrate the nominal and the real sample point
as well as the error of the sample point is displayed.

The output now looks like this:

Bit timing parameters for at91 with 100.000000 MHz ref clock
nominal                                 real Bitrt   nom  real SampP
Bitrate TQ[ns] PrS PhS1 PhS2 SJW BRP Bitrate Error SampP SampP Error     CAN_BR
1000000     50   7    7    5   1   5 1000000  0.0% 75.0% 75.0%  0.0% 0x00040664
 800000     50   8    8    8   1   5  800000  0.0% 80.0% 68.0% 15.0% 0x00040777
 500000    100   8    8    3   1  10  500000  0.0% 87.5% 85.0%  2.9% 0x00090772
 250000    250   6    7    2   1  25  250000  0.0% 87.5% 87.5%  0.0% 0x00180561
 125000    500   6    7    2   1  50  125000  0.0% 87.5% 87.5%  0.0% 0x00310561
 100000    500   8    8    3   1  50  100000  0.0% 87.5% 85.0%  2.9% 0x00310772
  50000   1250   6    7    2   1 125   50000  0.0% 87.5% 87.5%  0.0% 0x007c0561
  20000 ***bitrate not possible***
  10000 ***bitrate not possible***

Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
13 years agocan-calc-bit-timing: use algorithm from the kernel
Marc Kleine-Budde [Tue, 20 Jul 2010 13:43:08 +0000 (13:43 +0000)]
can-calc-bit-timing: use algorithm from the kernel

This patch copies the algorithm functions (can_update_spt and
can_calc_bittiming) from the kernel. Then some glue code is added that
these functions compile in userspace.

Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
13 years agocan-calc-bit-timing: fix indention
Marc Kleine-Budde [Tue, 20 Jul 2010 13:43:04 +0000 (13:43 +0000)]
can-calc-bit-timing: fix indention

Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
13 years agoadd can-calc-bit-timing to Makefiles + gitignore
Marc Kleine-Budde [Tue, 20 Jul 2010 13:43:01 +0000 (13:43 +0000)]
add can-calc-bit-timing to Makefiles + gitignore

Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
13 years agoadd can-calc-bit-timing
Marc Kleine-Budde [Tue, 20 Jul 2010 13:42:57 +0000 (13:42 +0000)]
add can-calc-bit-timing

Add the tool as sent by Wolfgang via email
(<4BE152D2.6060306@grandegger.com>).

Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
14 years agoRemove compiler warning :
Oliver Hartkopp [Fri, 14 May 2010 12:50:17 +0000 (12:50 +0000)]
Remove compiler warning :
warning: suggest explicit braces to avoid ambiguous ‘else’

14 years agoAdded isotpserver in autotool config file and gitignore
Oliver Hartkopp [Fri, 14 May 2010 12:43:42 +0000 (12:43 +0000)]
Added isotpserver in autotool config file and gitignore

14 years agoAdded tiny ip server to send ISO 15765-2 PDUs via internetsockets to the CAN bus...
Oliver Hartkopp [Fri, 14 May 2010 12:03:32 +0000 (12:03 +0000)]
Added tiny ip server to send ISO 15765-2 PDUs via internetsockets to the CAN bus and vice versa.

14 years agoAllow to have 4, 5 or 6 decimal places instead of only 4 & 6.
Oliver Hartkopp [Tue, 11 May 2010 10:01:49 +0000 (10:01 +0000)]
Allow to have 4, 5 or 6 decimal places instead of only 4 & 6.

14 years agoadd autotools infrastructure
Marc Kleine-Budde [Mon, 19 Apr 2010 12:12:18 +0000 (12:12 +0000)]
add autotools infrastructure

Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
14 years agoadd .gitignore
Marc Kleine-Budde [Mon, 19 Apr 2010 12:12:04 +0000 (12:12 +0000)]
add .gitignore

This may be usefull once the can-utils are migrated to git.

Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
14 years agocangw: replace obsolete bzero by memset
Marc Kleine-Budde [Mon, 19 Apr 2010 12:11:49 +0000 (12:11 +0000)]
cangw: replace obsolete bzero by memset

uclibc for example doesn't implement bzero

Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
14 years agoAdded CRC8 profiles to handle additional data for checksum generation.
Oliver Hartkopp [Fri, 16 Apr 2010 08:46:17 +0000 (08:46 +0000)]
Added CRC8 profiles to handle additional data for checksum generation.

14 years agoAdded checksum functionality and some documentation in gw.h
Oliver Hartkopp [Mon, 12 Apr 2010 14:41:14 +0000 (14:41 +0000)]
Added checksum functionality and some documentation in gw.h

14 years agoComplete rework of CAN netlink gateway.
Oliver Hartkopp [Sat, 10 Apr 2010 16:38:48 +0000 (16:38 +0000)]
Complete rework of CAN netlink gateway.

Major changes:

- rework internal structures to prepare routings and modifications of CAN traffic also to non-CAN interfaces
- fix reading of netlink messages in cangw.c (added RTCAN_RTA / RTCAN_PAYLOAD macros)
- rework reading of gw-job lists in cgw_dump_jobs()
- rename of functions and API definitions to have a common namespace cgw_
- added infrastructure to perform crc8 and xor checksums in CAN frame data[]

TODO:

- add and test functionality for crc8 and xor checksums in CAN frame data[]
- add help text for crc8 and xor checksums in CAN frame data[]

14 years agoSome binaries in can-utils depend on features in the socket-can svn
Oliver Hartkopp [Wed, 17 Mar 2010 19:21:38 +0000 (19:21 +0000)]
Some binaries in can-utils depend on features in the socket-can svn
repository. Building with exported headers from an unpatched kernel will
fail due to missing symbols or headers.

This patch adds two make variables to optionally disable building such
binaries, like this:

make PROGRAMS_ISOTP= PROGRAMS_CANGW= PROGRAMS_SLCAN= all

Signed-off-by: Olaf Hering <olaf@aepfle.de>
Signed-off-by: Oliver Hartkopp <oliver@hartkopp.net>
14 years agoTo simplify packaging of can-utils, add DESTDIR and PREFIX support to
Oliver Hartkopp [Wed, 17 Mar 2010 19:12:26 +0000 (19:12 +0000)]
To simplify packaging of can-utils, add DESTDIR and PREFIX support to
the can-utils Makefile.

Signed-off-by: Olaf Hering <olaf@aepfle.de>
Signed-off-by: Oliver Hartkopp <oliver@hartkopp.net>
14 years agoInitialize packet counters when printing each routing entry.
Oliver Hartkopp [Thu, 4 Mar 2010 10:59:24 +0000 (10:59 +0000)]
Initialize packet counters when printing each routing entry.

14 years agoRework of help text.
Oliver Hartkopp [Sat, 27 Feb 2010 16:07:58 +0000 (16:07 +0000)]
Rework of help text.

14 years agoWhen sending a sequence, we need to resend the same frame when poll() returns.
Oliver Hartkopp [Fri, 26 Feb 2010 08:38:47 +0000 (08:38 +0000)]
When sending a sequence, we need to resend the same frame when poll() returns.
Fixed that to be a valid data source e.g. for ptx cansequence.

14 years agoAdded commandline option '-p <timeout>' to enable polling on the writing socket.
Oliver Hartkopp [Thu, 25 Feb 2010 20:53:19 +0000 (20:53 +0000)]
Added commandline option '-p <timeout>' to enable polling on the writing socket.
Inspired by Marc Kleine-Budde :-)

14 years agoAdded funtionality to flush all GW jobs in one netlink message.
Oliver Hartkopp [Tue, 23 Feb 2010 19:13:17 +0000 (19:13 +0000)]
Added funtionality to flush all GW jobs in one netlink message.

14 years agoBeautify the listing of registered gwjobs (cangw -L).
Oliver Hartkopp [Mon, 22 Feb 2010 18:57:45 +0000 (18:57 +0000)]
Beautify the listing of registered gwjobs (cangw -L).

14 years agoAdded feature to list created gateway jobs.
Oliver Hartkopp [Mon, 22 Feb 2010 09:57:12 +0000 (09:57 +0000)]
Added feature to list created gateway jobs.
Also added some fixes and removed debug printf's.

14 years agoAdded netlink error message support to be able to provide return values.
Oliver Hartkopp [Sun, 21 Feb 2010 12:34:34 +0000 (12:34 +0000)]
Added netlink error message support to be able to provide return values.
Renamed some structure elements. Updated usage text.

14 years agoMoved kernel parsing of netlink attributes into can_can_parse_attr().
Oliver Hartkopp [Sat, 20 Feb 2010 20:41:24 +0000 (20:41 +0000)]
Moved kernel parsing of netlink attributes into can_can_parse_attr().
Added functionalitiy to remove formerly created CAN GW jobs.

14 years agoAdded cangw netlink gateway configuration tool.
Oliver Hartkopp [Fri, 19 Feb 2010 13:33:59 +0000 (13:33 +0000)]
Added cangw netlink gateway configuration tool.

TODO (in both cangw and can-gw.ko) : Support removal and listing of rules.
So far the gateway jobs are only removed on can-gw.ko module unload or when
the used CAN netdevices disappear.

14 years agoTry to ignore the usual value restrictions of sockopt SO_RCVBUF when running
Oliver Hartkopp [Fri, 15 Jan 2010 19:15:08 +0000 (19:15 +0000)]
Try to ignore the usual value restrictions of sockopt SO_RCVBUF when running
as root (with CAP_NET_ADMIN) by using SO_RCVBUFFORCE if possible.

14 years agoAdded '-d' option to support the receive packet drop counting introduced in
Oliver Hartkopp [Fri, 15 Jan 2010 18:35:37 +0000 (18:35 +0000)]
Added '-d' option to support the receive packet drop counting introduced in
http://git.kernel.org/?p=linux/kernel/git/davem/net-next-2.6.git;a=commitdiff;h=3b885787ea4112eaa80945999ea0901bf742707f

This is done by using recvmsg() instead of recvfrom() to allow the timestamp
and the dropcounter to be received within one syscall.

When the application (here 'candump') ist not fast enough to process the
incomming CAN frames the frames are dropped in the socket receive queue.
When this happens and '-d' is set, we get this info now:
DROPCOUNT: dropped 1 CAN frame on 'xxx' socket (total drops 1)

14 years agofflush the new configurable stdout output to allow proper pipe/netcat setups.
Oliver Hartkopp [Wed, 25 Nov 2009 18:51:31 +0000 (18:51 +0000)]
fflush the new configurable stdout output to allow proper pipe/netcat setups.

14 years agoAllow to specify the name of the IP tunnel netdevice via commandline option '-n ...
Oliver Hartkopp [Wed, 25 Nov 2009 17:15:09 +0000 (17:15 +0000)]
Allow to specify the name of the IP tunnel netdevice via commandline option '-n <name>'

14 years agoRemove feature to quit the isotptun by keypress (from stdin) as it was not possible...
Oliver Hartkopp [Wed, 25 Nov 2009 16:43:17 +0000 (16:43 +0000)]
Remove feature to quit the isotptun by keypress (from stdin) as it was not possible to run it from a start-script.
Added a signal handler to gracefully leave the isotptun.

14 years agocan-utils: canfdtest, a full duplex test to find out-of-order messages
Wolfgang Grandegger [Wed, 25 Nov 2009 11:18:22 +0000 (11:18 +0000)]
can-utils: canfdtest, a full duplex test to find out-of-order messages

This patch is a pepped up version of Valdislav's canecho_gen and
canecho_dut test programs, which have prooved to be useful for
detecting out-of-order message transmisson and reception. Here
is a list of the changes and improvements:

- Both programs have been merged into on test program named
  canfdtest. Message generation can be selected via the command
  line option '-g'.
- The test loop count can be specified.
- A low and high verbosity level has been added.
- send/recv is used instead of write/read.
- The return code of send/recv is checked properly.
- Use Linux coding style.

Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
14 years agoAdded hook to print selected logfile lines on stdout for further processing.
Oliver Hartkopp [Fri, 6 Nov 2009 08:07:45 +0000 (08:07 +0000)]
Added hook to print selected logfile lines on stdout for further processing.

14 years agoIntroduce KERNELDIR variable to allow override when invoking make on commandline.
Oliver Hartkopp [Thu, 10 Sep 2009 08:01:00 +0000 (08:01 +0000)]
Introduce KERNELDIR variable to allow override when invoking make on commandline.

14 years agoMove BCM server into can-utils as it is not test application anymore.
Oliver Hartkopp [Thu, 10 Sep 2009 07:39:33 +0000 (07:39 +0000)]
Move BCM server into can-utils as it is not test application anymore.

14 years agoRemove obsolete 'vcan' tool.
Oliver Hartkopp [Thu, 10 Sep 2009 07:34:06 +0000 (07:34 +0000)]
Remove obsolete 'vcan' tool.

15 years agoAdded slcand daemon contributed by Robert Haddon <robert.haddon@verari.com>
Oliver Hartkopp [Tue, 5 May 2009 09:40:10 +0000 (09:40 +0000)]
Added slcand daemon contributed by Robert Haddon <robert.haddon@verari.com>

15 years agoAdded commandline option '-r' to set the per-socket receive buffer size.
Oliver Hartkopp [Thu, 16 Apr 2009 08:05:42 +0000 (08:05 +0000)]
Added commandline option '-r' to set the per-socket receive buffer size.

15 years agoRemoved the limitation for the number of CAN filters for each interface.
Oliver Hartkopp [Mon, 6 Apr 2009 11:15:27 +0000 (11:15 +0000)]
Removed the limitation for the number of CAN filters for each interface.
Updated Copyright notice.
And finally: Yeah! I did something with malloc :-)

15 years agoAdd functionality to
Oliver Hartkopp [Mon, 6 Apr 2009 08:41:17 +0000 (08:41 +0000)]
Add functionality to
terminate after receiption of <count> CAN frames.

15 years agoSpagetti code cleanup:
Oliver Hartkopp [Sun, 15 Feb 2009 17:40:32 +0000 (17:40 +0000)]
Spagetti code cleanup:
Moved conversions into separate functions can2pty() and pty2can().
Updated and enhanced some comments.
Variable name cleanups inside the separate functions.
Fix handling on wrong pty commands (was a wrong 'continue' statement).

15 years agoAllow SLCAN RTR frames without data length code field.
Oliver Hartkopp [Wed, 4 Feb 2009 16:51:04 +0000 (16:51 +0000)]
Allow SLCAN RTR frames without data length code field.

15 years agoSome more implementation to make it work with a certain application.
Oliver Hartkopp [Wed, 4 Feb 2009 13:18:44 +0000 (13:18 +0000)]
Some more implementation to make it work with a certain application.

15 years agoUse rxbuf[] for acknowledges.
Oliver Hartkopp [Tue, 3 Feb 2009 20:12:34 +0000 (20:12 +0000)]
Use rxbuf[] for acknowledges.

15 years agoImplemented ACK/NACK replies for ASCII commands.
Oliver Hartkopp [Tue, 3 Feb 2009 13:59:17 +0000 (13:59 +0000)]
Implemented ACK/NACK replies for ASCII commands.
Added 'O'pen and 'C'lose functionality.

15 years agoAdded timestamp handling with Z0 or Z1 command.
Oliver Hartkopp [Tue, 3 Feb 2009 11:59:53 +0000 (11:59 +0000)]
Added timestamp handling with Z0 or Z1 command.

15 years agoAdd can_id/can_mask filter handling which is defined in the slcan protocol (m/M).
Oliver Hartkopp [Wed, 21 Jan 2009 09:17:20 +0000 (09:17 +0000)]
Add can_id/can_mask filter handling which is defined in the slcan protocol (m/M).

15 years agoRemoved sanity check for received slcan ASCII data
Oliver Hartkopp [Wed, 21 Jan 2009 07:38:18 +0000 (07:38 +0000)]
Removed  sanity check for received slcan ASCII data
as this is done with ASCII comparision three lines above.

15 years agoAdded a proof of concept tool 'slcanpty' which
Oliver Hartkopp [Tue, 20 Jan 2009 23:06:01 +0000 (23:06 +0000)]
Added a proof of concept tool 'slcanpty' which
creates a pty for applications using the slcan ASCII protocol and
converts the data to a CAN network interface (and vice versa).

This can be used for existing applications to run on SocketCAN.

15 years agoConsistencely allow '-?' to get a help text.
Oliver Hartkopp [Tue, 13 Jan 2009 09:32:45 +0000 (09:32 +0000)]
Consistencely allow '-?' to get a help text.

15 years agodisable default receive filter on the write-only bridge socket.
Oliver Hartkopp [Tue, 6 Jan 2009 09:04:34 +0000 (09:04 +0000)]
disable default receive filter on the write-only bridge socket.

15 years agoFix sloppy CAN_(EFF|RTR)_FLAG handling in can_filter.can_mask .
Oliver Hartkopp [Mon, 1 Dec 2008 07:24:18 +0000 (07:24 +0000)]
Fix sloppy CAN_(EFF|RTR)_FLAG handling in can_filter.can_mask .

Due to a wrong safety check in af_can.c it was not possible to filter
for SFF frames with a specific CAN identifier without getting the
same selected CAN identifier from a received EFF frame also.

This fix has a minimum impact on the CAN filter API as the 'sloppy'
handling is still a correct (and possibly wanted?) use-case.

Please update the can-utils (especially candump) whose filter definition
on the commandline made assumptions to correct the user input that are
probably unwanted now.

Thanks to Kurt van Dijck for pointing at this issue!

Signed-Off-by: Oliver Hartkopp <oliver@hartkopp.net>
15 years agoFixed parse_canframe() with reordering the checks for the can_id
Oliver Hartkopp [Fri, 28 Nov 2008 21:50:24 +0000 (21:50 +0000)]
Fixed parse_canframe() with reordering the checks for the can_id
delimiter. Before this fix the function may have found delimiters in the
string behind the terminating zero.

15 years agoAdded interface name to parameter list in first line.
Oliver Hartkopp [Mon, 17 Nov 2008 10:23:42 +0000 (10:23 +0000)]
Added interface name to parameter list in first line.

15 years agoAdded Id keyword propertiy on new files.
Oliver Hartkopp [Wed, 5 Nov 2008 14:20:52 +0000 (14:20 +0000)]
Added Id keyword propertiy on new files.

15 years agoAdded ISO 15765-2 CAN transport protocol for protocol family CAN.
Oliver Hartkopp [Wed, 5 Nov 2008 11:34:23 +0000 (11:34 +0000)]
Added ISO 15765-2 CAN transport protocol for protocol family CAN.
Including some tools and coarse documentation README.isotp

15 years agoReworked slcan_attach to give slcan setup values directly on the commandline.
Oliver Hartkopp [Tue, 4 Nov 2008 10:47:09 +0000 (10:47 +0000)]
Reworked slcan_attach to give slcan setup values directly on the commandline.

15 years agoPrint non-data stuff (errors, warnings, hints) on stderr.
Oliver Hartkopp [Wed, 29 Oct 2008 09:41:40 +0000 (09:41 +0000)]
Print non-data stuff (errors, warnings, hints) on stderr.

15 years agoAdded support for swapped byte order representation.
Oliver Hartkopp [Wed, 29 Oct 2008 09:23:48 +0000 (09:23 +0000)]
Added support for swapped byte order representation.

15 years agoStart candump in silent mode, when logging into a file.
Oliver Hartkopp [Thu, 2 Oct 2008 13:47:43 +0000 (13:47 +0000)]
Start candump in silent mode, when logging into a file.

15 years agoThe number for the SLCAN line discipline can not be found in
Oliver Hartkopp [Wed, 17 Sep 2008 13:02:49 +0000 (13:02 +0000)]
The number for the SLCAN line discipline can not be found in
<linux/tty.h> anyway but needs to be written as module alias

tty-ldisc-17 slcan

So we remove the annoying #error output and use the correctly defined
'17' from Kernel 2.6.25+ as default.

15 years agoAdded support for comments in logfiles.
Oliver Hartkopp [Tue, 9 Sep 2008 12:56:05 +0000 (12:56 +0000)]
Added support for comments in logfiles.
Added some sanity checks and error messages.

15 years agoCreate an informative error message when detecting a wrong line format.
Oliver Hartkopp [Fri, 25 Jul 2008 06:32:20 +0000 (06:32 +0000)]
Create an informative error message when detecting a wrong line format.

15 years agoChanged comment line recognition:
Oliver Hartkopp [Thu, 24 Jul 2008 19:12:19 +0000 (19:12 +0000)]
Changed comment line recognition:
Everything without a '(' at the beginning of an input line is treated as comment.
Changed buffer size to allow long comment lines & added overflow handling.

15 years agoSupport for comment lines in the logfile:
Oliver Hartkopp [Thu, 24 Jul 2008 13:03:18 +0000 (13:03 +0000)]
Support for comment lines in the logfile:
'#' at the beginning of a line marks comment lines.

15 years agoAdded missing help test.
Oliver Hartkopp [Thu, 10 Jul 2008 11:01:37 +0000 (11:01 +0000)]
Added missing help test.

15 years agoAdded -f option to filter only on the CAN-ID and not on the content.
Oliver Hartkopp [Thu, 10 Jul 2008 10:59:37 +0000 (10:59 +0000)]
Added -f option to filter only on the CAN-ID and not on the content.
This can be useful when the timestamp cyle needs to be displayed.

15 years agoDo not allow to create error frame filters via standard filter sets.
Oliver Hartkopp [Wed, 2 Jul 2008 04:19:07 +0000 (04:19 +0000)]
Do not allow to create error frame filters via standard filter sets.

15 years agoAdded automatic extended frame format recognition.
Oliver Hartkopp [Wed, 2 Jul 2008 04:05:11 +0000 (04:05 +0000)]
Added automatic extended frame format recognition.

Most SocketCAN userspace tools (like cansend) recognize the EFF by the
stringlength of the given CAN-ID: 3 -> SFF , 8 -> EFF.
This was missing in the candump filter definition and therefore the
values had to be specified with the CAN_EFF_FLAG set in the value, e.g.
92345678 for the extended CAN-ID 12345678 - this was not really nice.

Now the filtersets for extended frames can be specified as expected:
12345678:1FFFFFFF to filter for only 12345678 extended CAN-ID
000000AA:1FFFFFFF to filter for only AA extended CAN-ID.

15 years agoAdded silent correction for can_dlc out of range.
Oliver Hartkopp [Tue, 1 Jul 2008 11:31:59 +0000 (11:31 +0000)]
Added silent correction for can_dlc out of range.

15 years agoFixed condition pointed out by Uwe Bonnes:
Oliver Hartkopp [Thu, 26 Jun 2008 14:35:46 +0000 (14:35 +0000)]
Fixed condition pointed out by Uwe Bonnes:
https://lists.berlios.de/pipermail/socketcan-core/2008-June/001625.html

15 years agoFix typo.
Oliver Hartkopp [Fri, 20 Jun 2008 09:19:13 +0000 (09:19 +0000)]
Fix typo.

15 years agoFix commandline parameter handling for fixed canframe.data[] .
Oliver Hartkopp [Fri, 20 Jun 2008 09:16:06 +0000 (09:16 +0000)]
Fix commandline parameter handling for fixed canframe.data[] .

15 years agoIntroduced new functions:
Oliver Hartkopp [Fri, 20 Jun 2008 09:15:13 +0000 (09:15 +0000)]
Introduced new functions:
unsigned char asc2nibble(char c);
int hexstring2candata(char *arg, struct can_frame *cf);
(see documentation in lib.h)
As prerequsite to fix the commandline interface of cangen.

15 years agofixed comment.
Oliver Hartkopp [Wed, 11 Jun 2008 16:38:00 +0000 (16:38 +0000)]
fixed comment.

15 years agoRemoved bad hacks in vcan.c and slcan_attach.c.
Oliver Hartkopp [Wed, 11 Jun 2008 16:35:19 +0000 (16:35 +0000)]
Removed bad hacks in vcan.c and slcan_attach.c.
Giving some hints for users of older kernels than 2.6.25 that a
compilation error is a normal behaviour in these cases.

15 years agoAdded Id properties that gone lost.
Oliver Hartkopp [Tue, 3 Jun 2008 08:52:06 +0000 (08:52 +0000)]
Added Id properties that gone lost.

15 years agoWhitespace fixes. Indented the code following Linux styleguide to fix
Oliver Hartkopp [Tue, 3 Jun 2008 08:46:57 +0000 (08:46 +0000)]
Whitespace fixes. Indented the code following Linux styleguide to fix
the mess between tabs and spaces.