]> rtime.felk.cvut.cz Git - socketcan-devel.git/commit
can: fix NOHZ local_softirq_pending 08 warning
authorhartkopp <hartkopp@030b6a49-0b11-0410-94ab-b0dab22257f2>
Tue, 15 Sep 2009 17:29:13 +0000 (17:29 +0000)
committerhartkopp <hartkopp@030b6a49-0b11-0410-94ab-b0dab22257f2>
Tue, 15 Sep 2009 17:29:13 +0000 (17:29 +0000)
commitb6fa9a5f1671b7f0b7160b4e9edfc9cb202a4517
tree3d107574518c8b3851e0d93c86094cfe8f88edea
parentf5b3b07017dcebba1c7acc49aaeab89e1282e37c
can: fix NOHZ local_softirq_pending 08 warning

When using nanosleep() in an userspace application we get a ratelimit warning

NOHZ: local_softirq_pending 08

for 10 times.

The echo of CAN frames is done from process context and softirq context only.
Therefore the usage of netif_rx() was wrong (for years).

This patch replaces netif_rx() with netif_rx_ni() which has to be used from
process/softirq context. It also adds a missing comment that can_send() must
no be used from hardirq context.

Signed-off-by: Oliver Hartkopp <oliver@hartkopp.net>
Signed-off-by: Urs Thuermann <urs@isnogud.escape.de>
Also in mainline.

git-svn-id: svn://svn.berlios.de//socketcan/trunk@1055 030b6a49-0b11-0410-94ab-b0dab22257f2
kernel/2.4/drivers/net/can/vcan.c
kernel/2.4/net/can/af_can.c
kernel/2.6/drivers/net/can/vcan.c
kernel/2.6/net/can/af_can.c