]> rtime.felk.cvut.cz Git - lisovros/linux_canprio.git/commit
Staging: batman-adv: ensure that eth_type_trans gets linear memory
authorMarek Lindner <lindner_marek@yahoo.de>
Mon, 22 Nov 2010 11:34:49 +0000 (12:34 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 9 Dec 2010 21:33:25 +0000 (13:33 -0800)
commitfc359f622b4ffd5e61d317bde1544bb48b6cd6d4
tree8f4cc8668bc02a55d320f3668c8a1fb871c83da3
parentb0a5972239d8df027b99167a10e9ac0c1f1d3ed5
Staging: batman-adv: ensure that eth_type_trans gets linear memory

commit b6faaae1a15a352d68b3e3cd8b840e56709820bf upstream.

eth_type_trans tries to pull data with the length of the ethernet header
from the skb. We only ensured that enough data for the first ethernet
header and the batman header is available in non-paged memory of the skb
and not for the ethernet after the batman header.

eth_type_trans would fail sometimes with drivers which don't ensure that
all there data is perfectly linearised.

The failure was noticed through a kernel bug Oops generated by the
skb_pull inside eth_type_trans.

Reported-by: Rafal Lesniak <lesniak@eresi-project.org>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/batman-adv/soft-interface.c