]> rtime.felk.cvut.cz Git - lisovros/linux_canprio.git/commit
gdth: integer overflow in ioctl
authorDan Carpenter <error27@gmail.com>
Fri, 8 Oct 2010 07:03:07 +0000 (09:03 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 22 Nov 2010 19:03:16 +0000 (11:03 -0800)
commit962536d9c9b0ed384a4e3bd1011c144f956b6ccb
treeabe628930885a0da4b4f0bfea5987c51929d3fbe
parent990a971cf6443839baad4660abb40844849b89d9
gdth: integer overflow in ioctl

commit f63ae56e4e97fb12053590e41a4fa59e7daa74a4 upstream.

gdth_ioctl_alloc() takes the size variable as an int.
copy_from_user() takes the size variable as an unsigned long.
gen.data_len and gen.sense_len are unsigned longs.
On x86_64 longs are 64 bit and ints are 32 bit.

We could pass in a very large number and the allocation would truncate
the size to 32 bits and allocate a small buffer.  Then when we do the
copy_from_user(), it would result in a memory corruption.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/scsi/gdth.c