From: Michal Sojka <sojka@os.inf.tu-dresden.de>
Date: Fri, 2 Sep 2011 13:38:56 +0000 (+0200)
Subject: doc: Update sfq desc
X-Git-Url: https://rtime.felk.cvut.cz/gitweb/lisovros/iproute2_canprio.git/commitdiff_plain/17e96d483b4adc792c8a58a79adbf9bf62637f1f

doc: Update sfq desc
---

diff --git a/doc/canprio/qdiscs_review.txt b/doc/canprio/qdiscs_review.txt
index 280201e..e679765 100644
--- a/doc/canprio/qdiscs_review.txt
+++ b/doc/canprio/qdiscs_review.txt
@@ -64,10 +64,13 @@ Round-robin dequeuing
 * mq
   -- cons: Only for NICs with more than 1 TX queue.
  
-* SFQ
-  -- cons: Packets with other protocols than TCP, UDP, IPv4, IPv6 (etc.) are 
-           hashed based on the 32bits representation of their destination (skb->dst)
-           and the socket they belong to.
+* sfq (!)
+  -- pros: Divides bandwidth in a fair way between multiple "flows".
+           Packets with other protocols than IPv4, IPv6 assigned to
+           flows based on the socket they originate in.
+  -- cons: If the more logical flows are sent through a single
+           socket, sfq handles them as one flow. This can be improved
+           (if needed) by properly setting skb->dst for CAN frames.
 
 * drr
   -- cons: Seems to be classful although all classes have to be of type "drr".