]> rtime.felk.cvut.cz Git - lisovros/iproute2_canprio.git/commit
iproute2: support dotted-quad netmask notation.
authorAndreas Henriksson <andreas@fatal.se>
Fri, 7 Dec 2007 23:41:34 +0000 (00:41 +0100)
committerStephen Hemminger <shemminger@linux-foundation.org>
Tue, 11 Dec 2007 18:02:34 +0000 (10:02 -0800)
commit5a0d1cbf69269bfcb510a8b861b8a83aed0f6b85
treedf22e5d5a41b61dbdc42fc442c007265f77e016a
parente22b42a2c1f088c09cae071b77b3a57069f196b2
iproute2: support dotted-quad netmask notation.

On tor, 2007-12-06 at 11:53 -0800, Stephen Hemminger wrote:
> On Tue, 4 Dec 2007 14:58:18 +0100
> Andreas Henriksson <andreas@fatal.se> wrote:
>
> > Suggested patch for allowing netmask to be specified in dotted quad format.
> > See http://bugs.debian.org/357172
> >
> > (Known problem: this will not prevent some invalid syntaxes,
> > ie. "255.0.255.0" will be treated as "255.255.255.0")
> >
> > Comments? Suggestions? Improvements?
>
> Fix the bug you mentioned?
>
> [... snip example code ...]

Updated patch, added your netmask validation code but without the check
that made 0.0.0.0 (default) and 255.255.255.255 (one address) invalid
netmasks as they are permitted in CIDR format.

Signed-off-by: Andreas Henriksson <andreas@fatal.se>
Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
lib/utils.c