]> rtime.felk.cvut.cz Git - linux-imx.git/commit
iwlwifi: fix skb usage after free
authorStanislaw Gruszka <sgruszka@redhat.com>
Wed, 20 Apr 2011 13:57:14 +0000 (15:57 +0200)
committerAndi Kleen <ak@linux.intel.com>
Thu, 28 Apr 2011 15:21:15 +0000 (08:21 -0700)
commitf0aa357c5f66cc5befc35d5d438d323182cdeb2a
tree73312adea575ed3e93aae94d61e512c1beae9f6e
parent98081a1026dd80b985a084df2678e7d032729f6d
iwlwifi: fix skb usage after free

[AK: Did some changes for the backport to .35. Stanislaw, please verify
them]

Since

commit a120e912eb51e347f36c71b60a1d13af74d30e83
Author: Stanislaw Gruszka <sgruszka@redhat.com>
Date:   Fri Feb 19 15:47:33 2010 -0800

    iwlwifi: sanity check before counting number of tfds can be free

we use skb->data after calling ieee80211_tx_status_irqsafe(), which
could free skb instantly.

On current kernels I do not observe practical problems related with
bug, but on 2.6.35.y it cause random system hangs when stressing
wireless link.

Cc: stable@kernel.org # 2.6.32+
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
drivers/net/wireless/iwlwifi/iwl-agn-tx.c