]> rtime.felk.cvut.cz Git - linux-imx.git/commit
staging: comedi: pcmda12: cleanup pcmda12_ao_insn_read()
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Tue, 4 Jun 2013 02:04:45 +0000 (19:04 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 5 Jun 2013 22:35:38 +0000 (15:35 -0700)
commitcac10bf92a0678bbc0c336e058f89a4a6e95aa96
treeef9ccfaaa72eb43acf21b458ea165f38b099bb2f
parentb11c5d3ccc7361dc552f689f08b38599fea5a513
staging: comedi: pcmda12: cleanup pcmda12_ao_insn_read()

Remove the boilerplate comment from the 'skel' driver.

To initiate the simultaneaous transfer, only one analog output
register needs to be read. Move the read out of the for() loop.

(*insn_read) functions should return an errno or the number of
samples actually read. Change the final return to insn->n to
make this clear.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/pcmda12.c