]> rtime.felk.cvut.cz Git - linux-imx.git/commit
ALSA: prevent heap corruption in snd_ctl_new()
authorDan Rosenberg <drosenberg@vsecurity.com>
Tue, 28 Sep 2010 18:18:20 +0000 (14:18 -0400)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 29 Oct 2010 04:51:04 +0000 (21:51 -0700)
commitb81cb9277507012a8d44e6b4efbbaba4fce19299
tree4fb78e0be89a0032f48c019a415112b81f4de2d0
parente5d843fbf633dc65353bc08ee28f6b08ce651a4d
ALSA: prevent heap corruption in snd_ctl_new()

commit 5591bf07225523600450edd9e6ad258bb877b779 upstream.

The snd_ctl_new() function in sound/core/control.c allocates space for a
snd_kcontrol struct by performing arithmetic operations on a
user-provided size without checking for integer overflow.  If a user
provides a large enough size, an overflow will occur, the allocated
chunk will be too small, and a second user-influenced value will be
written repeatedly past the bounds of this chunk.  This code is
reachable by unprivileged users who have permission to open
a /dev/snd/controlC* device (on many distros, this is group "audio") via
the SNDRV_CTL_IOCTL_ELEM_ADD and SNDRV_CTL_IOCTL_ELEM_REPLACE ioctls.

Signed-off-by: Dan Rosenberg <drosenberg@vsecurity.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
sound/core/control.c