]> rtime.felk.cvut.cz Git - linux-imx.git/commit
gro: Reset dev pointer on reuse
authorHerbert Xu <herbert@gondor.apana.org.au>
Sun, 30 Jan 2011 04:44:54 +0000 (20:44 -0800)
committerAndi Kleen <ak@linux.intel.com>
Thu, 28 Apr 2011 15:20:59 +0000 (08:20 -0700)
commit760a5d738e7fe9bcdf6dd6a573541edb01a95ac2
tree0debc0722d90c270fba47ef4dddbcc0934e65ffb
parent38a4189d5c25a817018416dee94b52bd9be2e7c5
gro: Reset dev pointer on reuse

commit 66c46d741e2e60f0e8b625b80edb0ab820c46d7a upstream.

On older kernels the VLAN code may zero skb->dev before dropping
it and causing it to be reused by GRO.

Unfortunately we didn't reset skb->dev in that case which causes
the next GRO user to get a bogus skb->dev pointer.

This particular problem no longer happens with the current upstream
kernel due to changes in VLAN processing.

However, for correctness we should still reset the skb->dev pointer
in the GRO reuse function in case a future user does the same thing.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Brandon Philips <bphilips@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
net/core/dev.c