]> rtime.felk.cvut.cz Git - linux-imx.git/commit
p54spi: fix locking warning in p54spi_op_tx
authorChristian Lamparter <chunkeey@web.de>
Mon, 30 Mar 2009 13:55:24 +0000 (15:55 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Thu, 16 Apr 2009 14:39:06 +0000 (10:39 -0400)
commit731c6531684250c46d732e369b25b003356f3947
tree2f6b7f210fea5c093ba0cbb3e592557942aeb4e6
parent540828196e48ec54b64067a2b9defd870bff3ece
p54spi: fix locking warning in p54spi_op_tx

This patch fixes the following waring:
> ------------[ cut here ]------------
>WARNING: at kernel/softirq.c:138 local_bh_enable+0x54/0xbc()
>Modules linked in: p54spi
>[<c0034ff8>] (dump_stack+0x0/0x14)
>[<c005b1a4>] (warn_on_slowpath+0x0/0x68)
>[<c00604c8>] (local_bh_enable+0x0/0xbc)
>[<bf000000>] (p54spi_op_tx+0x0/0x4c [p54spi])
>[<c01a4d34>] (p54_sta_unlock+0x0/0x78)

p54spi_op_tx needs to be called from different locking contexts.
Therefore we have to protect the linked list with irqsave spinlocks.

Reported-by: Max Filippov <jcmvbkbc@gmail.com>
Signed-off-by: Christian Lamparter <chunkeey@web.de>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/p54/p54spi.c