]> rtime.felk.cvut.cz Git - linux-imx.git/commit
drm/i915: kill cargo-culted locking from power well code
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 30 Jan 2013 14:59:57 +0000 (15:59 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 31 Jan 2013 10:50:09 +0000 (11:50 +0100)
commit6b25a88752e8e9dc33c700712059b094d3da3219
tree2da67fb0fbac7eb1777ea8bf887c93bd20d610e5
parent725a5b54028916cd2511a251c5b5b13d1715addc
drm/i915: kill cargo-culted locking from power well code

We may not concurrently change the power wells code. Which
is already guaranteed since modesets aren't concurrent. That
leaves races against setup/teardown/suspend/resume, and for
those we already (try) rather hard not to hit concurrent
modesets.

No debug WARN_ON added since that would require us to grab the
modeset locks in init/suspend code. Which is again just cargo
culting since just grabbing the locks in those paths isn't good
enough, we need the right order of operations, too.

Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_pm.c