]> rtime.felk.cvut.cz Git - linux-imx.git/commit
ncpfs: fix rmdir returns Device or resource busy
authorDave Chiluk <chiluk@canonical.com>
Tue, 28 May 2013 21:06:08 +0000 (16:06 -0500)
committerAl Viro <viro@zeniv.linux.org.uk>
Fri, 7 Jun 2013 16:15:38 +0000 (12:15 -0400)
commit698b8223631472bf982ed570b0812faa61955683
treee983325703886079e4a9cf36866524519f9c7635
parent4d3797d7e1861ac1af150a6189315786c5e1c820
ncpfs: fix rmdir returns Device or resource busy

1d2ef5901483004d74947bbf78d5146c24038fe7 caused a regression in ncpfs such that
directories could no longer be removed.  This was because ncp_rmdir checked
to see if a dentry could be unhashed before allowing it to be removed. Since
1d2ef5901483004d74947bbf78d5146c24038fe7 introduced a change that incremented
dentry->d_count causing it to always be greater than 1 unhash would always
fail.  Thus causing the error path in ncp_rmdir to always be taken.  Removing
this error path is safe as unhashing is still accomplished by calls to dput
from vfs_rmdir.

Signed-off-by: Dave Chiluk <chiluk@canonical.com>
Signed-off-by: Petr Vandrovec <petr@vandrovec.name>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/ncpfs/dir.c