]> rtime.felk.cvut.cz Git - linux-imx.git/commit
tracing/kprobes: Kill probe_enable_lock
authorOleg Nesterov <oleg@redhat.com>
Thu, 20 Jun 2013 17:38:09 +0000 (19:38 +0200)
committerSteven Rostedt <rostedt@goodmis.org>
Tue, 2 Jul 2013 00:34:24 +0000 (20:34 -0400)
commit3fe3d6193e7cd7b4dd2bde10772f048bdefea4ee
treef7623a40ffb23ffab302a8cb9ed6c5716ec1d691
parent288e984e622336bab8bc3dfdf2f190816362d9a1
tracing/kprobes: Kill probe_enable_lock

enable_trace_probe() and disable_trace_probe() should not worry about
serialization, the caller (perf_trace_init or __ftrace_set_clr_event)
holds event_mutex.

They are also called by kprobe_trace_self_tests_init(), but this __init
function can't race with itself or trace_events.c

And note that this code depended on event_mutex even before 41a7dd420c
which introduced probe_enable_lock. In fact it assumes that the caller
kprobe_register() can never race with itself. Otherwise, say, tp->flags
manipulations are racy.

Link: http://lkml.kernel.org/r/20130620173809.GA13158@redhat.com
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
kernel/trace/trace_kprobe.c