]> rtime.felk.cvut.cz Git - linux-imx.git/commit
PCI/ASPM: Warn when driver asks to disable ASPM, but we can't do it
authorBjorn Helgaas <bhelgaas@google.com>
Tue, 21 May 2013 16:56:51 +0000 (10:56 -0600)
committerBjorn Helgaas <bhelgaas@google.com>
Tue, 21 May 2013 16:56:51 +0000 (10:56 -0600)
commit2add0ec14c259471d45d6afd051ca02eef0a4a92
treef863949b30c8a3e0b3096b1284096a6e675069b7
parentde7f2b1bdf02f6b44410dceb7295284c2a75a304
PCI/ASPM: Warn when driver asks to disable ASPM, but we can't do it

Some devices have hardware problems related to using ASPM.  Drivers for
these devices use pci_disable_link_state() to prevent their device from
entering L0s or L1.  But on platforms where the OS doesn't have permission
to manage ASPM, pci_disable_link_state() doesn't actually disable ASPM.

Windows has a similar mechanism ("PciASPMOptOut"), and when the OS doesn't
have control of ASPM, it doesn't actually disable ASPM either.

This patch just adds a warning in dmesg about the fact that
pci_disable_link_state() is doing nothing.

Reported-by: Emmanuel Grumbach <egrumbach@gmail.com>
Reference: https://lkml.kernel.org/r/CANUX_P3F5YhbZX3WGU-j1AGpbXb_T9Bis2ErhvKkFMtDvzatVQ@mail.gmail.com
Reference: https://bugzilla.kernel.org/show_bug.cgi?id=57331
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
drivers/pci/pcie/aspm.c