]> rtime.felk.cvut.cz Git - linux-imx.git/commit
set_task_comm: kill the pointless memset() + wmb()
authorOleg Nesterov <oleg@redhat.com>
Tue, 30 Apr 2013 22:28:19 +0000 (15:28 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 1 May 2013 00:04:07 +0000 (17:04 -0700)
commit12eaaf309a798973d215f7f21aa5a67a760ed7c8
tree6be40c0ec42f7cf8eb5d09c31e1f36cc21499720
parent830e0fc967a7ee5013d5d1cf6a3cea71a8868466
set_task_comm: kill the pointless memset() + wmb()

set_task_comm() does memset() + wmb() before strlcpy().  This buys
nothing and to add to the confusion, the comment is wrong.

- We do not need memset() to be "safe from non-terminating string
  reads", the final char is always zero and we never change it.

- wmb() is paired with nothing, it cannot prevent from printing
  the mixture of the old/new data unless the reader takes the lock.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: John Stultz <johnstul@us.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/exec.c