]> rtime.felk.cvut.cz Git - linux-imx.git/commit
drm/i915: fix gen4 digital port hotplug definitions
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 26 Jul 2013 09:27:49 +0000 (11:27 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 7 Aug 2013 09:57:06 +0000 (11:57 +0200)
commit0ce99f749b3834edeb500e17d6ad17e86b60ff83
tree5c10e96bbe0e40e457d8105b5f5ad40a3fe457bf
parentc095ba7224d8edc71dcef0d655911399a8bd4a3f
drm/i915: fix gen4 digital port hotplug definitions

Apparently Bspec is wrong in this case here even for gm45. Note that
Bspec is horribly misguided on i965g/gm, so we don't have any other
data points besides that it seems to make machines work better.

With this changes all the bits in PORT_HOTPLUG_STAT for the digital
ports are ordered the same way. This seems to agree with what register
dumps from the hpd storm handling code shows, where the LIVE bit and
the short/long pulse STATUS bits light up at the same time with this
enumeration (but no with the one from Bspec).

Also tested on my gm45 which has two DP+ ports, and everything seems
to still work as expected.

References: http://www.mail-archive.com/intel-gfx@lists.freedesktop.org/msg23054.html
Cc: Egbert Eich <eich@suse.com>
Cc: Jan Niggemann <jn@hz6.de>
Tested-by: Jan Niggemann <jn@hz6.de>
[danvet: Add a big warning that Bspec seems to be wrong for these
bits, suggested by Jani.]
Acked-by: Jani Nikula <jani.nikula@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/i915_reg.h