]> rtime.felk.cvut.cz Git - linux-imx.git/commit
Staging: batman-adv: Always synchronize rcu's on module shutdown
authorLinus Lüssing <linus.luessing@web.de>
Sun, 12 Sep 2010 21:21:52 +0000 (23:21 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 14 Sep 2010 23:38:32 +0000 (16:38 -0700)
commit09686b560ff229bc6c87489717dce118c7d2b20b
tree6a50b6518e7e829818ab65dfd628447d0b8eac20
parent6267ea655f141bfd0955910b728571fb2a4ed1df
Staging: batman-adv: Always synchronize rcu's on module shutdown

During the module shutdown procedure in batman_exit(), a rcu callback is
being scheduled (batman_exit -> hardif_remove_interfaces ->
hardif_remove_interfae -> call_rcu). However, when the kernel unloads
the module, the rcu callback might not have been executed yet, resulting
in a "unable to handle kernel paging request" in __rcu_process_callback
afterwards, causing the kernel to freeze.

The synchronize_net and synchronize_rcu in mesh_free are currently
called before the call_rcu in hardif_remove_interface and have no real
effect on it.

Therefore, we should always flush all rcu callback functions scheduled
during the shutdown procedure using synchronize_net. The call to
synchronize_rcu can be omitted because synchronize_net already calls it.

Signed-off-by: Linus Lüssing <linus.luessing@web.de>
Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/batman-adv/main.c