]> rtime.felk.cvut.cz Git - linux-imx.git/blobdiff - drivers/gpu/drm/radeon/btc_dpm.c
drm/radeon/dpm: add dpm_set_power_state failure output (7xx-ni)
[linux-imx.git] / drivers / gpu / drm / radeon / btc_dpm.c
index e0d315e7fd010561ed4adaaaea902c8e77f57aa8..0cbf75e078498fa32cf268e7a056241dbdeaa2b4 100644 (file)
@@ -2178,21 +2178,26 @@ static void btc_apply_state_adjust_rules(struct radeon_device *rdev,
                                           ps->low.mclk, max_limits->vddci, &ps->low.vddci);
        btc_apply_voltage_dependency_rules(&rdev->pm.dpm.dyn_state.vddc_dependency_on_mclk,
                                           ps->low.mclk, max_limits->vddc, &ps->low.vddc);
-       /* XXX validate the voltage required for display */
+       btc_apply_voltage_dependency_rules(&rdev->pm.dpm.dyn_state.vddc_dependency_on_dispclk,
+                                          rdev->clock.current_dispclk, max_limits->vddc, &ps->low.vddc);
+
        btc_apply_voltage_dependency_rules(&rdev->pm.dpm.dyn_state.vddc_dependency_on_sclk,
                                           ps->medium.sclk, max_limits->vddc, &ps->medium.vddc);
        btc_apply_voltage_dependency_rules(&rdev->pm.dpm.dyn_state.vddci_dependency_on_mclk,
                                           ps->medium.mclk, max_limits->vddci, &ps->medium.vddci);
        btc_apply_voltage_dependency_rules(&rdev->pm.dpm.dyn_state.vddc_dependency_on_mclk,
                                           ps->medium.mclk, max_limits->vddc, &ps->medium.vddc);
-       /* XXX validate the voltage required for display */
+       btc_apply_voltage_dependency_rules(&rdev->pm.dpm.dyn_state.vddc_dependency_on_dispclk,
+                                          rdev->clock.current_dispclk, max_limits->vddc, &ps->medium.vddc);
+
        btc_apply_voltage_dependency_rules(&rdev->pm.dpm.dyn_state.vddc_dependency_on_sclk,
                                           ps->high.sclk, max_limits->vddc, &ps->high.vddc);
        btc_apply_voltage_dependency_rules(&rdev->pm.dpm.dyn_state.vddci_dependency_on_mclk,
                                           ps->high.mclk, max_limits->vddci, &ps->high.vddci);
        btc_apply_voltage_dependency_rules(&rdev->pm.dpm.dyn_state.vddc_dependency_on_mclk,
                                           ps->high.mclk, max_limits->vddc, &ps->high.vddc);
-       /* XXX validate the voltage required for display */
+       btc_apply_voltage_dependency_rules(&rdev->pm.dpm.dyn_state.vddc_dependency_on_dispclk,
+                                          rdev->clock.current_dispclk, max_limits->vddc, &ps->high.vddc);
 
        btc_apply_voltage_delta_rules(rdev, max_limits->vddc, max_limits->vddci,
                                      &ps->low.vddc, &ps->low.vddci);
@@ -2264,38 +2269,68 @@ int btc_dpm_set_power_state(struct radeon_device *rdev)
        struct evergreen_power_info *eg_pi = evergreen_get_pi(rdev);
        struct radeon_ps *new_ps = &eg_pi->requested_rps;
        struct radeon_ps *old_ps = &eg_pi->current_rps;
+       int ret;
 
-       btc_disable_ulv(rdev);
+       ret = btc_disable_ulv(rdev);
        btc_set_boot_state_timing(rdev);
-       rv770_restrict_performance_levels_before_switch(rdev);
-
+       ret = rv770_restrict_performance_levels_before_switch(rdev);
+       if (ret) {
+               DRM_ERROR("rv770_restrict_performance_levels_before_switch failed\n");
+               return ret;
+       }
        if (eg_pi->pcie_performance_request)
                cypress_notify_link_speed_change_before_state_change(rdev, new_ps, old_ps);
 
        rv770_set_uvd_clock_before_set_eng_clock(rdev, new_ps, old_ps);
-       rv770_halt_smc(rdev);
+       ret = rv770_halt_smc(rdev);
+       if (ret) {
+               DRM_ERROR("rv770_halt_smc failed\n");
+               return ret;
+       }
        btc_set_at_for_uvd(rdev, new_ps);
        if (eg_pi->smu_uvd_hs)
                btc_notify_uvd_to_smc(rdev, new_ps);
-       cypress_upload_sw_state(rdev, new_ps);
-
-       if (eg_pi->dynamic_ac_timing)
-               cypress_upload_mc_reg_table(rdev, new_ps);
+       ret = cypress_upload_sw_state(rdev, new_ps);
+       if (ret) {
+               DRM_ERROR("cypress_upload_sw_state failed\n");
+               return ret;
+       }
+       if (eg_pi->dynamic_ac_timing) {
+               ret = cypress_upload_mc_reg_table(rdev, new_ps);
+               if (ret) {
+                       DRM_ERROR("cypress_upload_mc_reg_table failed\n");
+                       return ret;
+               }
+       }
 
        cypress_program_memory_timing_parameters(rdev, new_ps);
 
-       rv770_resume_smc(rdev);
-       rv770_set_sw_state(rdev);
+       ret = rv770_resume_smc(rdev);
+       if (ret) {
+               DRM_ERROR("rv770_resume_smc failed\n");
+               return ret;
+       }
+       ret = rv770_set_sw_state(rdev);
+       if (ret) {
+               DRM_ERROR("rv770_set_sw_state failed\n");
+               return ret;
+       }
        rv770_set_uvd_clock_after_set_eng_clock(rdev, new_ps, old_ps);
 
        if (eg_pi->pcie_performance_request)
                cypress_notify_link_speed_change_after_state_change(rdev, new_ps, old_ps);
 
-       btc_set_power_state_conditionally_enable_ulv(rdev, new_ps);
+       ret = btc_set_power_state_conditionally_enable_ulv(rdev, new_ps);
+       if (ret) {
+               DRM_ERROR("btc_set_power_state_conditionally_enable_ulv failed\n");
+               return ret;
+       }
 
 #if 0
        /* XXX */
-       rv770_unrestrict_performance_levels_after_switch(rdev);
+       ret = rv770_unrestrict_performance_levels_after_switch(rdev);
+       if (ret)
+               return ret;
 #endif
 
        return 0;
@@ -2314,6 +2349,7 @@ int btc_dpm_enable(struct radeon_device *rdev)
        struct rv7xx_power_info *pi = rv770_get_pi(rdev);
        struct evergreen_power_info *eg_pi = evergreen_get_pi(rdev);
        struct radeon_ps *boot_ps = rdev->pm.dpm.boot_ps;
+       int ret;
 
        if (pi->gfx_clock_gating)
                btc_cg_clock_gating_default(rdev);
@@ -2329,14 +2365,26 @@ int btc_dpm_enable(struct radeon_device *rdev)
 
        if (pi->voltage_control) {
                rv770_enable_voltage_control(rdev, true);
-               cypress_construct_voltage_tables(rdev);
+               ret = cypress_construct_voltage_tables(rdev);
+               if (ret) {
+                       DRM_ERROR("cypress_construct_voltage_tables failed\n");
+                       return ret;
+               }
        }
 
-       if (pi->mvdd_control)
-               cypress_get_mvdd_configuration(rdev);
+       if (pi->mvdd_control) {
+               ret = cypress_get_mvdd_configuration(rdev);
+               if (ret) {
+                       DRM_ERROR("cypress_get_mvdd_configuration failed\n");
+                       return ret;
+               }
+       }
 
-       if (eg_pi->dynamic_ac_timing)
-               btc_initialize_mc_reg_table(rdev);
+       if (eg_pi->dynamic_ac_timing) {
+               ret = btc_initialize_mc_reg_table(rdev);
+               if (ret)
+                       eg_pi->dynamic_ac_timing = false;
+       }
 
        if (rdev->pm.dpm.platform_caps & ATOM_PP_PLATFORM_CAP_BACKBIAS)
                rv770_enable_backbias(rdev, true);
@@ -2359,18 +2407,35 @@ int btc_dpm_enable(struct radeon_device *rdev)
        if (pi->dynamic_pcie_gen2)
                btc_enable_dynamic_pcie_gen2(rdev, true);
 
-       if (rv770_upload_firmware(rdev))
-               return -EINVAL;
-
-       cypress_get_table_locations(rdev);
-       btc_init_smc_table(rdev, boot_ps);
+       ret = rv770_upload_firmware(rdev);
+       if (ret) {
+               DRM_ERROR("rv770_upload_firmware failed\n");
+               return ret;
+       }
+       ret = cypress_get_table_locations(rdev);
+       if (ret) {
+               DRM_ERROR("cypress_get_table_locations failed\n");
+               return ret;
+       }
+       ret = btc_init_smc_table(rdev, boot_ps);
+       if (ret)
+               return ret;
 
-       if (eg_pi->dynamic_ac_timing)
-               cypress_populate_mc_reg_table(rdev, boot_ps);
+       if (eg_pi->dynamic_ac_timing) {
+               ret = cypress_populate_mc_reg_table(rdev, boot_ps);
+               if (ret) {
+                       DRM_ERROR("cypress_populate_mc_reg_table failed\n");
+                       return ret;
+               }
+       }
 
        cypress_program_response_times(rdev);
        r7xx_start_smc(rdev);
-       cypress_notify_smc_display_change(rdev, false);
+       ret = cypress_notify_smc_display_change(rdev, false);
+       if (ret) {
+               DRM_ERROR("cypress_notify_smc_display_change failed\n");
+               return ret;
+       }
        cypress_enable_sclk_control(rdev, true);
 
        if (eg_pi->memory_transition)
@@ -2391,7 +2456,9 @@ int btc_dpm_enable(struct radeon_device *rdev)
            r600_is_internal_thermal_sensor(rdev->pm.int_thermal_type)) {
                PPSMC_Result result;
 
-               rv770_set_thermal_temperature_range(rdev, R600_TEMP_RANGE_MIN, R600_TEMP_RANGE_MAX);
+               ret = rv770_set_thermal_temperature_range(rdev, R600_TEMP_RANGE_MIN, R600_TEMP_RANGE_MAX);
+               if (ret)
+                       return ret;
                rdev->irq.dpm_thermal = true;
                radeon_irq_set(rdev);
                result = rv770_send_msg_to_smc(rdev, PPSMC_MSG_EnableThermalInterrupt);
@@ -2495,6 +2562,22 @@ int btc_dpm_init(struct radeon_device *rdev)
        if (ret)
                return ret;
 
+       rdev->pm.dpm.dyn_state.vddc_dependency_on_dispclk.entries =
+               kzalloc(4 * sizeof(struct radeon_clock_voltage_dependency_entry), GFP_KERNEL);
+       if (!rdev->pm.dpm.dyn_state.vddc_dependency_on_dispclk.entries) {
+               r600_free_extended_power_table(rdev);
+               return -ENOMEM;
+       }
+       rdev->pm.dpm.dyn_state.vddc_dependency_on_dispclk.count = 4;
+       rdev->pm.dpm.dyn_state.vddc_dependency_on_dispclk.entries[0].clk = 0;
+       rdev->pm.dpm.dyn_state.vddc_dependency_on_dispclk.entries[0].v = 0;
+       rdev->pm.dpm.dyn_state.vddc_dependency_on_dispclk.entries[1].clk = 36000;
+       rdev->pm.dpm.dyn_state.vddc_dependency_on_dispclk.entries[1].v = 800;
+       rdev->pm.dpm.dyn_state.vddc_dependency_on_dispclk.entries[2].clk = 54000;
+       rdev->pm.dpm.dyn_state.vddc_dependency_on_dispclk.entries[2].v = 800;
+       rdev->pm.dpm.dyn_state.vddc_dependency_on_dispclk.entries[3].clk = 72000;
+       rdev->pm.dpm.dyn_state.vddc_dependency_on_dispclk.entries[3].v = 800;
+
        if (rdev->pm.dpm.voltage_response_time == 0)
                rdev->pm.dpm.voltage_response_time = R600_VOLTAGERESPONSETIME_DFLT;
        if (rdev->pm.dpm.backbias_response_time == 0)
@@ -2628,6 +2711,7 @@ void btc_dpm_fini(struct radeon_device *rdev)
        }
        kfree(rdev->pm.dpm.ps);
        kfree(rdev->pm.dpm.priv);
+       kfree(rdev->pm.dpm.dyn_state.vddc_dependency_on_dispclk.entries);
        r600_free_extended_power_table(rdev);
 }