]> rtime.felk.cvut.cz Git - hercules2020/nv-tegra/linux-4.4.git/commit
tmpfs: fix regression hang in fallocate undo
authorHugh Dickins <hughd@google.com>
Sun, 10 Jul 2016 23:46:32 +0000 (16:46 -0700)
committerIshan Mittal <imittal@nvidia.com>
Fri, 6 Jan 2017 10:06:49 +0000 (15:36 +0530)
commit9818a50a74d2eb7c3b000f0d817b0ebfdf6b7ec0
tree549adac3b9408054e2981e0384478f7f72e1c9f7
parent5b8f68716a735af9c9a88d0ac1d15e90e7fc7484
tmpfs: fix regression hang in fallocate undo

commit 7f556567036cb7f89aabe2f0954b08566b4efb53 upstream.

The well-spotted fallocate undo fix is good in most cases, but not when
fallocate failed on the very first page.  index 0 then passes lend -1
to shmem_undo_range(), and that has two bad effects: (a) that it will
undo every fallocation throughout the file, unrestricted by the current
range; but more importantly (b) it can cause the undo to hang, because
lend -1 is treated as truncation, which makes it keep on retrying until
every page has gone, but those already fully instantiated will never go
away.  Big thank you to xfstests generic/269 which demonstrates this.

Fixes: b9b4bb26af01 ("tmpfs: don't undo fallocate past its last page")
Signed-off-by: Hugh Dickins <hughd@google.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mm/shmem.c