]> rtime.felk.cvut.cz Git - hercules2020/nv-tegra/linux-4.4.git/commit
block: add missing group association in bio-cloning functions
authorPaolo Valente <paolo.valente@linaro.org>
Wed, 27 Jul 2016 05:22:05 +0000 (07:22 +0200)
committerIshan Mittal <imittal@nvidia.com>
Fri, 6 Jan 2017 10:08:48 +0000 (15:38 +0530)
commit5f381cb2eebbf39505ce576fb30c86c01ad5c3b8
tree982275bdb3510e3a200e9545885d8c114658b02d
parent84228144358651ad8f05fbcc9260ebaa06d39e3d
block: add missing group association in bio-cloning functions

commit 20bd723ec6a3261df5e02250cd3a1fbb09a343f2 upstream.

When a bio is cloned, the newly created bio must be associated with
the same blkcg as the original bio (if BLK_CGROUP is enabled). If
this operation is not performed, then the new bio is not associated
with any group, and the group of the current task is returned when
the group of the bio is requested.

Depending on the cloning frequency, this may cause a large
percentage of the bios belonging to a given group to be treated
as if belonging to other groups (in most cases as if belonging to
the root group). The expected group isolation may thereby be broken.

This commit adds the missing association in bio-cloning functions.

Fixes: da2f0f74cf7d ("Btrfs: add support for blkio controllers")
Signed-off-by: Paolo Valente <paolo.valente@linaro.org>
Reviewed-by: Nikolay Borisov <kernel@kyup.com>
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Jens Axboe <axboe@fb.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
block/bio.c
fs/btrfs/extent_io.c
include/linux/bio.h