]> rtime.felk.cvut.cz Git - hercules2020/nv-tegra/linux-4.4.git/commit
net: socket: don't set sk_uid to garbage value in ->setattr()
authorEric Biggers <ebiggers@google.com>
Fri, 30 Dec 2016 23:42:32 +0000 (17:42 -0600)
committermobile promotions <svcmobile_promotions@nvidia.com>
Thu, 23 Mar 2017 19:34:59 +0000 (12:34 -0700)
commit5b192af3073be539d62c131c6c1d78254dc288b9
treebdd56a734256b8ab2c452929cbbaace3a992d853
parent0e187b1ae5fb54a6407ae1ee13a49bea284ebe30
net: socket: don't set sk_uid to garbage value in ->setattr()

->setattr() was recently implemented for socket files to sync the socket
inode's uid to the new 'sk_uid' member of struct sock.  It does this by
copying over the ia_uid member of struct iattr.  However, ia_uid is
actually only valid when ATTR_UID is set in ia_valid, indicating that
the uid is being changed, e.g. by chown.  Other metadata operations such
as chmod or utimes leave ia_uid uninitialized.  Therefore, sk_uid could
be set to a "garbage" value from the stack.

Fix this by only copying the uid over when ATTR_UID is set.

[cherry-pick of net e1a3a60a2ebe991605acb14cd58e39c0545e174e]

Bug: 16355602
bug 200281955

Change-Id: I20e53848e54282b72a388ce12bfa88da5e3e9efe
Fixes: 86741ec25462 ("net: core: Add a UID field to struct sock.")
Signed-off-by: Eric Biggers <ebiggers@google.com>
Tested-by: Lorenzo Colitti <lorenzo@google.com>
Acked-by: Lorenzo Colitti <lorenzo@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Reviewed-on: http://git-master/r/1321819
(cherry picked from commit c4dac3f83a635ab8dcb193abd8799e3a54ad3eaa)
Reviewed-on: http://git-master/r/1324832
GVS: Gerrit_Virtual_Submit
Reviewed-by: Manikanta Maddireddy <mmaddireddy@nvidia.com>
Tested-by: Manikanta Maddireddy <mmaddireddy@nvidia.com>
Reviewed-by: Bharat Nihalani <bnihalani@nvidia.com>
net/socket.c