]> rtime.felk.cvut.cz Git - hercules2020/nv-tegra/linux-4.4.git/commit
ASoC: dapm: Fix possible uninitialized variable in snd_soc_dapm_get_volsw()
authorChen-Yu Tsai <wens@csie.org>
Sat, 27 Aug 2016 11:27:58 +0000 (19:27 +0800)
committerIshan Mittal <imittal@nvidia.com>
Fri, 6 Jan 2017 10:16:30 +0000 (15:46 +0530)
commit3dbaf0e6ce32cba368fcc4e80cd01ce3e9fd2b75
tree17542e5388f3a82f7b794df181ee292ac4724feb
parent1aa562df5cf40e53cc98319a22f8475e28aeebd0
ASoC: dapm: Fix possible uninitialized variable in snd_soc_dapm_get_volsw()

commit 01ad5e7de67b408d9b48b437b06a9938ddf460b5 upstream.

If soc_dapm_read() fails, val will be uninitialized, and bogus values
will be written later:

ret = soc_dapm_read(dapm, reg, &val);
val = (val >> shift) & mask;

However, the compiler does not give a warning. Return on error before
val is really used to avoid this.

This is similar to the commit 6912831623c5 ("ASoC: dapm: Fix
uninitialized variable in snd_soc_dapm_get_enum_double()")

Fixes: ce0fc93ae56e (ASoC: Add DAPM support at the component level)
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/soc/soc-dapm.c