Gustavo Zacarias [Thu, 20 Nov 2014 19:18:40 +0000 (16:18 -0300)]
sysvinit/inittab: adjust shutdown
The previous shutdown sequence was basically a no-op, it did't call rcK
to stop anything and dumped users back into shell.
So do the proper thing by calling rcK for levels 0 (halt) and 6
(reboot), then swapoff, then remount ro.
After that call halt for 0 and reboot for 6.
Also make 3 the default runlevel as in normal distributions, for all
intents and purposes it changes nothing except aesthetics/convention.
And make the labels a context sequence rather than just a short form
of the actions which IMHO looks horrible.
Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Gustavo Zacarias [Thu, 20 Nov 2014 17:01:49 +0000 (14:01 -0300)]
system/inittab: adjust shutdown
Drop null id since that means "don't show anything" for busybox init,
hence the shutdown sequence (/etc/init.d/rcK) doesn't show anything
giving the false impression that it's not being run.
If someone wants a really silent console they'll need to adjust much more than
this anyway.
Also swap the root read-only remount with swapoff since the swap can be
a regular (loop) file in the root filesystem and make the operation fail
resulting in a dirty filesystem.
Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Baruch Siach [Thu, 20 Nov 2014 13:21:16 +0000 (15:21 +0200)]
canfestival: disable static build
canfestival doesn't really support static build. The configure script accepts
the --disable-dll parameter that should in theory allow a static build. In
practice this options is not well tested, as it causes the build to fails in
various places.
Jörg Krause [Wed, 12 Nov 2014 23:06:26 +0000 (00:06 +0100)]
package/shairport-sync: fix init script
shairport-sync uses libdaemon for running as daemon and creating the pidfile
which conflicts with start-stop-daemons `-b -m` options. For that reason
shairport-sync does not start using /etc/init.d/S99shairport-sync start.
The issue is fixed by removing the background and pidfile task from
start-stop-daemon and add a daemon option `-d` to shairport-sync.
Signed-off-by: Jörg Krause <jkrause@posteo.de> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Peter Korsgaard [Wed, 19 Nov 2014 19:53:56 +0000 (20:53 +0100)]
x264: disable opencl support
We don't have anything providing opencl support in Buildroot, so this is
just dead code. More importantly, it uses dlopen so it breaks on completely
static configurations.
Peter Korsgaard [Wed, 19 Nov 2014 14:04:50 +0000 (15:04 +0100)]
e2fsprogs: fix static linking issues with libintl
Util-linux (and hence libuuid) links against libintl if
BR2_NEEDS_GETTEXT_IF_LOCALE, so e2fsprogs needs to link against it as when
when statically linking, otherwise the configure test for libuuid (and later
linking) fails.
Gustavo Zacarias [Wed, 19 Nov 2014 00:47:39 +0000 (21:47 -0300)]
ndisc6: use LIBS for libintl
Use LIBS instead of LDFLAGS for "-lintl", otherwise LDFLAGS gets
evaluated to the left of object files and fails to link statically
because of incorrect symbol resolution order. Fixes:
http://autobuild.buildroot.net/results/21b/21bf88c9dbaecc204598e60dd9c7392a85068dd6/
Also rename patch to new naming convention.
Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Francois Perrad [Fri, 14 Nov 2014 17:31:29 +0000 (18:31 +0100)]
perl-cross: bump to version 0.9.4
this release fixes the build when BR2_PREFER_STATIC_LIB
see http://autobuild.buildroot.net/results/057/057a4b9976fd6b9c5cddd117a3f29de51efe719f/build-end.log
see https://github.com/arsv/perl-cross/issues/11
Signed-off-by: Francois Perrad <francois.perrad@gadz.org> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
The config options --without-ssl2 and --without-ssl3 are intended to be used if
nodejs is built with the bundled OpenSSL library for excluding the SSL2 and
SSL3 features.
Both options are actual only evaluated if --without-ssl is not set:
[Peter: adjusted commit text to make it clear that it is a revert] Signed-off-by: Jörg Krause <jkrause@posteo.de> Tested-by: Fabio Porcedda <fabio.porcedda@gmail.com> Acked-by: Fabio Porcedda <fabio.porcedda@gmail.com> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Jörg Krause [Mon, 17 Nov 2014 11:41:55 +0000 (12:41 +0100)]
package/nodejs: fix build error without OpenSSL support
Add a patch to fix broken build of nodejs without OpenSSL support.
Version 0.10.33 of nodejs introduced a bug which prevents us from building
nodejs without OpenSSL support. The bug is reported upstream:
https://github.com/joyent/node/issues/8676
Yann E. MORIN [Tue, 18 Nov 2014 18:38:27 +0000 (19:38 +0100)]
package/tzdata: fix installation commands
If the destination directory already exists (e.g. because of a re-run or
a custom skeleton), then the zoneinfo files will be installed in a
sub-directory of where we are trying to install them.
Fix that by creating the destination directory and copying the content
of the source directory.
Also fix the host install commands to match what we do in the target
install commands.
Reported-by: Martin Dorwig <dorwig@tetronik.com> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Baruch Siach [Tue, 18 Nov 2014 19:07:28 +0000 (21:07 +0200)]
coreutils: avoid prompt on rebuild
The mode bits of coreutils installed binaries are 555. As a result, on
rebuild mv prompts the user to confirm overwrite of non writable binaries.
Force overwrite to skip this prompt.
Signed-off-by: Baruch Siach <baruch@tkos.co.il> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
libgcrypt depends on libgpg-error and the configure script forgets to link
against it breaking static linking. Fix it by using libgcrypt-config
--libs.
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Baruch Siach [Mon, 17 Nov 2014 13:13:39 +0000 (15:13 +0200)]
tstools: disable parallel build
Commit 0e8cbd5902e4 (tstools: fix build failure in parallel (-j) build) didn't
fix, apparently, the parallel build issue. Revert this commit, and just
disable parallel build.
Peter Korsgaard [Tue, 18 Nov 2014 12:24:18 +0000 (13:24 +0100)]
iputils: fix hang issue with ping -f
Patch from upstream git (git://git.linux-ipv6.org/gitroot/iputils.git). We
should probably bump the version to a newer snapshot in the 2015.02 cycle,
but this is a safer option for 2014.11.
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Yann E. MORIN [Sun, 16 Nov 2014 22:56:03 +0000 (23:56 +0100)]
package/rpm: add missing dependency to openssl
We forcibly enable use of an extrernal openssl in rpm, so we must depend
on it.
openssl is correctly selected from kconfig, but there is no build-time
dependency to it.
It was not an issue so far, because openssl always sorts before rpm, so
gets built before. Unless one wants to just build rpm to debug an
autobuilder failure, that is.
Add that build-time dependency to openssl.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Yann E. MORIN [Sun, 16 Nov 2014 16:34:27 +0000 (17:34 +0100)]
package/clamav: fix build with uClibc
clamav wants to use backtrace, and decides whether it can use it if it
detects a glibc >= 2.1.
But uClibc does impersonate a glibc >= 2.1, so clamav concludes it is
possible to use backtrace. So it includes execinfo.h, which is missing
in our default uClibc config file.
So, just extend the test so that backtrace support is disable on uClibc,
unless it has been configured with backtrace support.
A far better solution would be to add a ./configure check for backtrace,
but this patch is sufficient enough.
Yann E. MORIN [Sun, 16 Nov 2014 14:04:33 +0000 (15:04 +0100)]
package/duma: add missing define when installing
Commit 3ab9774 (package/duma: do not let Makefile guess OS) added a
define to not let duma's build system guess the OS, mostly to avoid a
warning, but forgot to add that same define to the install commands.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Yann E. MORIN [Sun, 16 Nov 2014 15:15:10 +0000 (16:15 +0100)]
package/aircrack-ng: fix static build
Two fixes in one:
- openssl's libcrypto needs -lz, but because aircrack-ng does not use
pkg-config, it misses this dependency. The proper fix would be to
use pkg-config, like is done for pcre with patch
0001-Makefile-use-pkg-config-to-find-libpcre-it-s-more-cros.patch
but adding -lz is much easier.
- sqlite needs -lpthread, so -lpthread must be added _after_ -lsqlite,
but we currently add it before. So, force -lpthread after -lsqlite
when we are doing a static build.
Thomas Petazzoni [Thu, 13 Nov 2014 21:23:23 +0000 (22:23 +0100)]
python3: don't use wcsftime() on uClibc
As investigated in bug #7646, wcsftime() doesn't work properly with
uClibc. Until it gets fixed in uClibc, let's tell Python 3 to not use
it. Python 3 will fall back to strftime(), which works properly.
[Peter: fix typo in comment] Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Cc: Beyonlo <beyonlo@gmail.com> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Gustavo Zacarias [Thu, 13 Nov 2014 11:11:57 +0000 (08:11 -0300)]
libmemcached: disable sanitizer
The tests are flawed and we don't generally enable a dozen hardening
CFLAGS automatically. Fixes:
http://autobuild.buildroot.net/results/a84/a84ab4f0fdea6bbab971ba379e3066cddb25bfaa/
Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Peter Korsgaard [Thu, 13 Nov 2014 15:10:24 +0000 (16:10 +0100)]
qt5base: unconditionally install network, sql, xml and test modules to target
The qt5 build system currently unconditionally builds and installs into
staging these libraries, so ensure they also get installed into target to
make sure we don't end up with dynamic linker errors at runtime.
Peter Korsgaard [Thu, 13 Nov 2014 14:45:41 +0000 (15:45 +0100)]
qt5base: unconditionally install Qt5printSupport if widgets are enabled
The qt5 build system currently unconditionally builds and installs into
staging Qt5PrintSupport if widgets are enabled, so ensure it also gets
installed into target to make sure we don't end up with dynamic linker
errors at runtime:
test: error while loading shared libraries: libQt5PrintSupport.so.5: cannot
open shared object file: No such file or directory
There are many build failures caused by schifra, due to upstream
changing the tarball without doing new releases. Since has been an
on-going problem for some time, and is now the #1 issue in the
autobuilders. So let's mark this package broken, until someone cares
enough to fix it, or until we remove it.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Jörg Krause [Tue, 4 Nov 2014 13:04:29 +0000 (14:04 +0100)]
package/shairport-sync: fix avahi dependency
shairport-sync uses mDNS to pubish its service. This task is implemented
(among others) in avahi and tinysvcmdns.
To use avahi as the mDNS backend, shairport-sync requires libavahi-client or
libdns_sd. Both will work, but libavahi-client is sufficient.
To get libavahi-client support from avahi BR2_PACKAGE_AVAHI_DAEMON and
BR2_PACKAGE_DBUS needs to be selected. Unfortunatly this is not immediately
obvious if you've not checked avahis configure file. A
BR2_PACKAGE_LIBAVAHI_CLIENT config symbol may help here for clarification,
but is not present yet.
Thomas Petazzoni [Mon, 10 Nov 2014 19:50:26 +0000 (20:50 +0100)]
configs/apf9328: bump to a modern kernel
Since the apf9238 support is in the mainline kernel, we can bump to
kernel 3.17.2.
The patches can be removed because:
- linux-3.1.1-0001-fixes_arm_mach-types_for_apf9328.patch is no
longer needed, since the machine number for apf9328 is now
upstream.
- linux-3.1.1-0002-add_missing_config_option_for_apf9328.patch is no
longer needed, because the MTD_CFI_INTELEXT option is selected by
the imx_v4_v5_defconfig.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Thomas Petazzoni [Mon, 10 Nov 2014 19:50:25 +0000 (20:50 +0100)]
configs/apf9328: use default gcc version
The gcc 4.4 version has been deprecated recently, so we cannot use it
anymore. Since this platform is just using a normal ARM processor with
nothing special, we can expect the default gcc version to just work.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Baruch Siach [Tue, 11 Nov 2014 10:23:03 +0000 (12:23 +0200)]
tcpdump: fix static build
Commit 746116d1eb2e (tcpdump: use libpcap shared library) broke static build
of tcpdump, because its configure script doesn't take into account indirect
dependencies of libpcap. Add these dependencies to the LIBS configure
parameter.
Gustavo Zacarias [Tue, 11 Nov 2014 21:17:11 +0000 (18:17 -0300)]
aircrack-ng: security bump to version 1.2-rc1
Fixes:
CVE-2014-8321 - gps_tracer stack overflow
CVE-2014-8322 - tcp_test length parameter inconsistency
CVE-2014-8323 - buddy-ng missing check in data format
CVE-2014-8324 - net_get missing check for invalid values
Previous CVE patch dropped since the fix is upstream.
Also add hash file.
Drop iw runtime dep since it's only one of many required by airmon-zc (a
script) which require a ton of conditionals for just that tool.
It will tell somewhat nicely if they're missing. These would be:
awk - from busybox or gawk
ethtool
grep - from busybox or grep
ip or ifconfig - from busybox, iproute2 or net-tools
iw
lspci - from pciutils (needs full variant)
lsusb - from usbutils (needs full variant)
modprobe/modinfo - from busybox or kmod
uname - from busybox or coreutils
[Peter: drop double -lpthread from sqlite conditional] Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Gustavo Zacarias [Tue, 11 Nov 2014 20:29:15 +0000 (17:29 -0300)]
zeromq: security bump to version 4.0.5
Fixes:
CVE-2014-7202 - stream_engine.cpp in libzmq (aka ZeroMQ/C++)) 4.0.5
before 4.0.5 allows man-in-the-middle attackers to conduct downgrade
attacks via a crafted connection request.
CVE-2014-7203 - libzmq (aka ZeroMQ/C++) 4.0.x before 4.0.5 does not
ensure that nonces are unique, which allows man-in-the-middle attackers
to conduct replay attacks via unspecified vectors.
Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Yann E. MORIN [Tue, 11 Nov 2014 18:33:56 +0000 (19:33 +0100)]
docs/manual: cleanup github helper docs
Explicitly state that the github helper should not be used when there is
a release tarball.
Properly render the list by separating it from the previous paragraph.
[Peter: fix typo as pointed out by Maxime] Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Cc: Maxime Hadjinlian <maxime.hadjinlian@gmail.com> Acked-by: Samuel Martin <s.martin49@gmail.com> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
alsa-utils needs to link with intl if the toolchain needs gettext and
locale is set. Otherwise we will see an error like this one:
alsamixer-cli.o: In function `main':
cli.c:(.text.startup+0x4d): undefined reference to `libintl_textdomain'
cli.c:(.text.startup+0xc1): undefined reference to `libintl_gettext'
cli.c:(.text.startup+0xd5): undefined reference to `libintl_gettext'
cli.c:(.text.startup+0xe9): undefined reference to `libintl_gettext'
cli.c:(.text.startup+0x1fd): undefined reference to `libintl_gettext'
cli.c:(.text.startup+0x223): undefined reference to `libintl_gettext'
Thomas Petazzoni [Mon, 10 Nov 2014 19:45:41 +0000 (20:45 +0100)]
util-linux: re-enable libmount and binaries on Microblaze
In commit 442aa88f95d6c4a921aa3d4de91f54d50bd0cd35 ("util-linux: bump
version and revamp options"), Gustavo disabled util-linux libmount and
binaries on microblaze, as it was not building properly.
However, as mentionned in the comment, these options were disabled on
Microblaze due to "libc lacks UTIME_NOW & UTIME_COMMIT for
libmount". This was true specifically for the microblaze external
toolchain that we were using at the time. But we are no longer using
this external toolchain (which proved to be broken in many ways), and
have microblaze support in our internal backend.
I have verified that with our internal toolchain, util-linux with
libmount and the binaries enabled builds fine.
Those options are not selected by anything else in Buildroot, so
there's no other package impacted by this dependency change.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Thomas Petazzoni [Mon, 10 Nov 2014 10:06:31 +0000 (11:06 +0100)]
toolchain-external: update Linaro toolchains
Bump the ARM, ARMeb and AArch64 Linaro toolchains from 14.08 to
14.09. We can't bump to 14.10, because they completely changed the
toolchains and they are now completely broken: they switched from
Crosstool-NG to a new build tool to generate the toolchain, and now
the sysroot handling is completely borked.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Alexey Brodkin [Mon, 10 Nov 2014 09:59:08 +0000 (12:59 +0300)]
rt-tests: bump version to 0.89
With this change we're moving to the latest version of rt-tests.
Existing patches were updated so they apply on sources without errors and
warnings.
In "01-fix-build-system.patch" CFLAGS substitution was removed because
now external CFLAGS are accepted:
http://git.kernel.org/cgit/linux/kernel/git/clrkwllms/rt-tests.git/commit/?id=dfcef6e557b7980a33aa30b45bde196ed1780eb1
Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Cc: Peter Korsgaard <peter@korsgaard.com> Cc: Arnout Vandecappelle <arnout@mind.be> Cc: Gustavo Zacarias <gustavo@zacarias.com.ar> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Alexey Brodkin [Mon, 10 Nov 2014 09:59:07 +0000 (12:59 +0300)]
rt-tests: switch site from Debian snapshot to Linux's git
Origin of "rt-tests" is:
git://git.kernel.org/pub/scm/linux/kernel/git/clrkwllms/rt-tests.git
Switching to this new "origin" simplifies version bumping because there's
no need in updating Debian snapshot folder as it was done already here:
http://git.buildroot.net/buildroot/commit/package/rt-tests?id=da330e508c2d95e898ac52a2aa39426a5f6d0506
Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Cc: Peter Korsgaard <peter@korsgaard.com> Cc: Arnout Vandecappelle <arnout@mind.be> Cc: Gustavo Zacarias <gustavo@zacarias.com.ar> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Gustavo Zacarias [Tue, 11 Nov 2014 13:08:56 +0000 (10:08 -0300)]
dhcp: fix bad --enable/disable-debug logic
It interprets disable as enable and wreaks havoc since it changes the
behaviour of the build, for instance not using configured leases files
paths.
Thanks to Nathaniel Roach for pointing me to this problem.
Alexey Brodkin [Tue, 11 Nov 2014 13:56:48 +0000 (16:56 +0300)]
rt-tests: allow building subset of tests with non-NPTL toolchains
Some architectures are still stuck with non-NPTL toolchains.
These are for example ARC, Blackfin, Xtensa etc.
Still rt-tests are very good benchmarks and it would be good to enable use of
at least selected (those that will be built) tests on those architectures.
This change makes it possible to only build subset of tests that don't require
NPTL calls.
Following tests will be built with non-NPTL toolchain:
* signaltest
* ptsematest
* sigwaittest
* svsematest
* sendme
* hackbench
Still it's required to have a toolchain with threads support because most of
mentioned tests use threads.
03-fix-non-nptl-buil.patch was submitted upstream:
https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg762958.html
so as soon as it is accepted with the next version bump this patch should be
removed.
[Thomas: fix the rt-tests.mk test on NPTL to use positive logic.]
Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Cc: Peter Korsgaard <peter@korsgaard.com> Cc: Arnout Vandecappelle <arnout@mind.be> Cc: Gustavo Zacarias <gustavo@zacarias.com.ar> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Gustavo Zacarias [Mon, 10 Nov 2014 12:48:01 +0000 (09:48 -0300)]
gnutls: security bump to version 3.2.20
Fixes:
CVE-2014-8564 / GNUTLS-SA-2014-5 - Sean Burford reported that the
encoding of elliptic curves parameters GnuTLS 3 is vulnerable to a
denial of service (heap corruption). It affects clients and servers
which print information about the peer's certificate, e.g., the key ID,
and can be exploited via a specially crafted X.509 certificate.
Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
The aim of this patch is to fix bug #7574, i.e fix the static linking
of the quota package. It does so by introducing a patch to the quota
build system that generalizes the use of $(LIBS), and then changes
quota.mk to use LIBS instead of LDFLAGS to link against intl and tirpc
when needed.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
The dependency on util-linux is only present in Config.in, and not in
quota.mk, and quota indeed builds properly without util-linux. It
could be a runtime dependency, but there is no indication that it is
the case, and I don't see why quota would run-time depend on
util-linux utilities.
Looking back at when the quota package was introduced, in one of the
preliminary patch, he following explanation was given by the original
author:
[Update: I added check for util-linux mount because
it support usrquota and grpquota mount options.]
But I still don't see why usrquota and grpquota mount options would be
the source of a dependency of the quota utilities on util-linux. Here
is what the util-linux mount man page says about those two mount
options:
grpquota|noquota|quota|usrquota
These options are accepted but ignored. (However, quota
utilities may react to such strings in /etc/fstab.)
So indeed, the quota tools will look at /proc/mounts and see if those
options are used for certain mount points, but that doesn't create a
dependency of quota on util-linux.
Therefore, this commit gets rid of the dependency of quota on
util-linux. It allows to re-enable quota on Microblaze, since this
dependency was inherited from util-linux.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>