From: Yann E. MORIN Date: Mon, 27 Nov 2017 10:48:55 +0000 (+0100) Subject: package/dvb-apps: is not parallel-safe X-Git-Tag: 2017.08.2~4 X-Git-Url: https://rtime.felk.cvut.cz/gitweb/coffee/buildroot.git/commitdiff_plain/bce795fbdc61f7c17aefadae1cab47c52dc5236b package/dvb-apps: is not parallel-safe This is invisible because the timings make it excessively difficult to hit, but the Makefile is inherently flawed for parallel build, as it contains: $(objects): atsc_psip_section.c atsc_psip_section.h atsc_psip_section.c atsc_psip_section.h: perl section_generate.pl atsc_psip_section.pl and the perl script section_generate.pl will create both the .c and .h files in one go, but given the construct above, there can be two such script that run in parallel, which can clobber the generated .c and/or .h files. So, make dvb-apps a MAKE1 package. Signed-off-by: "Yann E. MORIN" Signed-off-by: Thomas Petazzoni (cherry picked from commit ba6796c7ccb856fc34a7983c9ac031168f1e0b65) Signed-off-by: Peter Korsgaard --- diff --git a/package/dvb-apps/dvb-apps.mk b/package/dvb-apps/dvb-apps.mk index 8ba1501d5c..95af87f10e 100644 --- a/package/dvb-apps/dvb-apps.mk +++ b/package/dvb-apps/dvb-apps.mk @@ -25,7 +25,7 @@ DVB_APPS_INSTALL_STAGING = YES define DVB_APPS_BUILD_CMDS $(TARGET_CONFIGURE_OPTS) LDLIBS="$(DVB_APPS_LDLIBS)" \ - $(MAKE) -C $(@D) CROSS_ROOT=$(STAGING_DIR) \ + $(MAKE1) -C $(@D) CROSS_ROOT=$(STAGING_DIR) \ $(DVB_APPS_MAKE_OPTS) endef