]> rtime.felk.cvut.cz Git - coffee/buildroot.git/commit
core: always pass full path to strip command
authorYann E. MORIN <yann.morin.1998@free.fr>
Sat, 1 Jul 2017 07:42:05 +0000 (09:42 +0200)
committerPeter Korsgaard <peter@korsgaard.com>
Sun, 2 Jul 2017 15:46:21 +0000 (17:46 +0200)
commitdc5af298046683ebc1cbd4502b9ecc23431093cf
tree92305d82b87112e2b7a8b6183c033103e17ded6e
parent825e5da72e5f73be9d312dc639dbf040b1b2473d
core: always pass full path to strip command

In some cases, passing STRIP=true is not sufficient to disable striping
altogether, as some (incorrectly generated?) configure scripts will
ignore a ${STRIP} that is not a full path.

This is the case, for example, for nmap, which ends up using the host
strip command when we pass STRIP=true:

    checking for arm-buildroot-linux-gnueabihf-strip... no
    checking for strip... /usr/bin/strip
    configure: WARNING: using cross tools not prefixed with host triplet
    [--SNIP--]
    /usr/bin/install -c -c -m 755 nping /home/ymorin/dev/buildroot/O/target/usr/bin/nping
    /usr/bin/strip -x /home/ymorin/dev/buildroot/O/target/usr/bin/nping
    /usr/bin/strip: Unable to recognise the format of the input file `/home/ymorin/dev/buildroot/O/target/usr/bin/nping'

We fix that by forcing a full path to the strip sommand when it is
disabled: STRIP=/bin/true

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
(cherry picked from commit d5dcc76d9e5f9d22e881517ccc805dfd54499a74)
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
package/Makefile.in