From 4807e2236741b4822f9b5f9240da33970174805a Mon Sep 17 00:00:00 2001 From: Ankita Garg Date: Tue, 25 Aug 2015 16:15:03 -0700 Subject: [PATCH] HID: hidraw: Fix potential memory leak in list->buffer Bug 1677312 Change-Id: I4fe6296b3d944c7ebf81f3af2aa73256688a4613 Signed-off-by: Ankita Garg Reviewed-on: http://git-master/r/789231 (cherry picked from commit 78d9ee9ad113e31193fdfae30f3743a0febcb8ca) Signed-off-by: Ankita Garg Reviewed-on: http://git-master/r/791185 GVS: Gerrit_Virtual_Submit Reviewed-by: Raymond Poudrier Reviewed-by: Eric Chuang --- drivers/hid/hidraw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hidraw.c b/drivers/hid/hidraw.c index 36a6bef03de..f4eadf172fe 100644 --- a/drivers/hid/hidraw.c +++ b/drivers/hid/hidraw.c @@ -7,7 +7,7 @@ * use a transport-specific userspace libhid/libusb libraries. * * Copyright (c) 2007 Jiri Kosina - * Copyright (c) 2014, NVIDIA CORPORATION. All rights reserved. + * Copyright (c) 2014-2015, NVIDIA CORPORATION. All rights reserved. */ /* @@ -482,6 +482,7 @@ int hidraw_report_event(struct hid_device *hid, u8 *data, int len) if (new_head == list->tail) continue; + kfree(list->buffer[list->head].value); if (!(list->buffer[list->head].value = kmemdup(data, len, GFP_ATOMIC))) { ret = -ENOMEM; break; -- 2.39.2