]> rtime.felk.cvut.cz Git - sojka/nv-tegra/linux-3.10.git/commit
media: nec-decoder: remove trailer_space state
authorDaniel Fu <danifu@nvidia.com>
Fri, 30 Jan 2015 17:31:09 +0000 (17:31 +0000)
committermobile promotions <svcmobile_promotions@nvidia.com>
Thu, 15 Oct 2015 14:31:41 +0000 (07:31 -0700)
commitfd7d7fe864a17bec84dac98e26402dd940e87e16
treefed11c0c73d016484ad94ee1c6f2d1385276b26c
parent7276efe366e59748374d40aba66ff739626d0bd2
media: nec-decoder: remove trailer_space state

Remove STATE_TRAILER_SPACE from state machine.
Causing 2 issue:
- can not decode the keycode, if it didn't following with
  another keycode/repeat code
- will generate one more code in curreent logic.
  i.e. key_right + repeat code + key_left + repeat code.
  expect: key_right, key_left.
  Result: key_right, key_right, key_right.
  Reason: when receive repeat code of key_right, state machine will
  stay in STATE_TRAILER_SPACE state, then wait for a new interrupt,
  if an interrupt came after keyup_timer, then will generate another
  fake key.

According to the NEC protocol, it don't need a trailer space. Remove it.

Bug 1601127

Change-Id: I7b990e94c4fc26b4387dcbbb68ae6c4e4af4dd46
Signed-off-by: Daniel Fu <danifu@nvidia.com>
Reviewed-on: http://git-master/r/679574
(cherry picked from commit d6027e7ad132f42d066371773efb48257789774b)
Reviewed-on: http://git-master/r/816585
GVS: Gerrit_Virtual_Submit
Reviewed-by: Vinayak Pane <vpane@nvidia.com>
drivers/media/rc/ir-nec-decoder.c