]> rtime.felk.cvut.cz Git - sojka/lightdm.git/blobdiff - src/seat.c
Have seat listen to greeter active username
[sojka/lightdm.git] / src / seat.c
index 3ffd37d995cd389c174d8c370ef4e11d1bcf5017..39d77cb1dacf63b1acde8dabf91eeac53c0d02f8 100644 (file)
@@ -17,6 +17,7 @@
 #include "configuration.h"
 #include "guest-account.h"
 #include "greeter.h"
+#include "session-config.h"
 
 enum {
     SESSION_ADDED,
@@ -44,8 +45,17 @@ struct SeatPrivate
     /* The sessions on this seat */
     GList *sessions;
 
+    /* The last session set to active */
+    Session *active_session;
+
+    /* The session belonging to the active greeter user */
+    Session *next_session;
+
     /* The session to set active when it starts */
     Session *session_to_activate;
+  
+    /* TRUE once we have started */
+    gboolean started;
 
     /* TRUE if stopping this seat (waiting for displays to stop) */
     gboolean stopping;
@@ -69,7 +79,7 @@ typedef struct
 static GHashTable *seat_modules = NULL;
 
 // FIXME: Make a get_display_server() that re-uses display servers if supported
-static DisplayServer *create_display_server (Seat *seat);
+static DisplayServer *create_display_server (Seat *seat, const gchar *session_type);
 static Greeter *create_greeter_session (Seat *seat);
 static void start_session (Seat *seat, Session *session);
 
@@ -175,6 +185,10 @@ seat_set_active_session (Seat *seat, Session *session)
 
     g_return_if_fail (seat != NULL);
 
+    /* Unlock this session */
+    if (session != seat->priv->active_session && !IS_GREETER (session))
+        session_unlock (session);
+
     SEAT_GET_CLASS (seat)->set_active_session (seat, session);
 
     /* Stop any greeters */
@@ -191,6 +205,15 @@ seat_set_active_session (Seat *seat, Session *session)
             session_stop (s);
         }
     }
+
+    /* Lock previous sessions */
+    if (seat->priv->active_session)
+    {
+        if (session != seat->priv->active_session && !IS_GREETER (seat->priv->active_session))
+            session_lock (seat->priv->active_session);
+        g_object_unref (seat->priv->active_session);
+    }
+    seat->priv->active_session = g_object_ref (session);
 }
 
 Session *
@@ -200,6 +223,13 @@ seat_get_active_session (Seat *seat)
     return SEAT_GET_CLASS (seat)->get_active_session (seat);
 }
 
+Session *
+seat_get_next_session (Seat *seat)
+{
+    g_return_val_if_fail (seat != NULL, NULL);
+    return seat->priv->next_session;
+}
+
 gboolean
 seat_get_can_switch (Seat *seat)
 {
@@ -300,6 +330,12 @@ check_stopped (Seat *seat)
     }
 }
 
+static gboolean
+get_start_local_sessions (Seat *seat)
+{
+    return SEAT_GET_CLASS (seat)->get_start_local_sessions (seat);
+}
+
 static void
 display_server_stopped_cb (DisplayServer *display_server, Seat *seat)
 {
@@ -311,7 +347,7 @@ display_server_stopped_cb (DisplayServer *display_server, Seat *seat)
     g_signal_handlers_disconnect_matched (display_server, G_SIGNAL_MATCH_DATA, 0, 0, NULL, NULL, seat);
     seat->priv->display_servers = g_list_remove (seat->priv->display_servers, display_server);
 
-    if (seat->priv->stopping)
+    if (seat->priv->stopping || !seat->priv->started)
     {
         check_stopped (seat);
         g_object_unref (display_server);
@@ -343,7 +379,7 @@ display_server_stopped_cb (DisplayServer *display_server, Seat *seat)
     }
     g_list_free_full (list, g_object_unref);
 
-    if (!seat->priv->stopping && display_server_get_start_local_sessions (display_server))
+    if (!seat->priv->stopping && get_start_local_sessions (seat))
     {
         /* If we were the active session, switch to a greeter */
         active_session = seat_get_active_session (seat);
@@ -357,6 +393,12 @@ display_server_stopped_cb (DisplayServer *display_server, Seat *seat)
     g_object_unref (display_server);
 }
 
+static gboolean
+can_share_display_server (Seat *seat, DisplayServer *display_server)
+{
+    return seat->priv->share_display_server && display_server_get_can_share (display_server);
+}
+
 static void
 switch_to_greeter_from_failed_session (Seat *seat, Session *session)
 {
@@ -371,13 +413,13 @@ switch_to_greeter_from_failed_session (Seat *seat, Session *session)
         g_object_unref (seat->priv->session_to_activate);
     seat->priv->session_to_activate = g_object_ref (greeter_session);
 
-    if (seat->priv->share_display_server)
+    if (can_share_display_server (seat, session_get_display_server (session)))
         session_set_display_server (SESSION (greeter_session), session_get_display_server (session));
     else
     {
         DisplayServer *display_server;
 
-        display_server = create_display_server (seat);
+        display_server = create_display_server (seat, session_get_session_type (session));
         if (!display_server_start (display_server))
         {
             g_debug ("Failed to start display server for greeter");
@@ -396,6 +438,20 @@ switch_to_greeter_from_failed_session (Seat *seat, Session *session)
 static void
 start_session (Seat *seat, Session *session)
 {
+    /* Use system location for greeter log file */
+    if (IS_GREETER (session))
+    {
+        gchar *log_dir, *filename, *log_filename;
+
+        log_dir = config_get_string (config_get_instance (), "LightDM", "log-directory");
+        filename = g_strdup_printf ("%s-greeter.log", display_server_get_name (session_get_display_server (session)));
+        log_filename = g_build_filename (log_dir, filename, NULL);
+        g_free (log_dir);
+        g_free (filename);
+        session_set_log_file (session, log_filename);
+        g_free (log_filename);
+    }
+
     if (session_start (session))
         return;
 
@@ -427,7 +483,10 @@ run_session (Seat *seat, Session *session)
     }
 
     if (!IS_GREETER (session))
+    {
         g_signal_emit (seat, signals[RUNNING_USER_SESSION], 0, session);
+        emit_upstart_signal ("desktop-session-start");
+    }
 
     session_run (session);
 
@@ -441,6 +500,41 @@ run_session (Seat *seat, Session *session)
     }
 }
 
+static Session *
+find_user_session (Seat *seat, const gchar *username)
+{
+    GList *link;
+
+    if (!username)
+        return NULL;
+
+    for (link = seat->priv->sessions; link; link = link->next)
+    {
+        Session *session = link->data;
+
+        if (!session_get_is_stopping (session) && strcmp (session_get_username (session), username) == 0)
+            return session;
+    }
+
+    return NULL;
+}
+
+static void
+greeter_active_username_changed_cb (Greeter *greeter, GParamSpec *pspec, Seat *seat)
+{
+    Session *session;
+
+    session = find_user_session (seat, greeter_get_active_username (greeter));
+    if (session)
+    {
+        if (seat->priv->next_session)
+            g_object_unref (seat->priv->next_session);
+        seat->priv->next_session = g_object_ref (session);
+
+        SEAT_GET_CLASS (seat)->set_next_session (seat, session);
+    }
+}
+
 static void
 session_authentication_complete_cb (Session *session, Seat *seat)
 {
@@ -468,7 +562,30 @@ session_stopped_cb (Session *session, Seat *seat)
 
     g_debug ("Session stopped");
 
+    g_signal_handlers_disconnect_matched (session, G_SIGNAL_MATCH_DATA, 0, 0, NULL, NULL, seat);
+    seat->priv->sessions = g_list_remove (seat->priv->sessions, session);
+    if (session == seat->priv->active_session)
+    {
+        g_object_unref (seat->priv->active_session);
+        seat->priv->active_session = NULL;
+    }
+    if (session == seat->priv->next_session)
+    {
+        g_object_unref (seat->priv->next_session);
+        seat->priv->next_session = NULL;
+    }
+    if (session == seat->priv->session_to_activate)
+    {
+        g_object_unref (seat->priv->session_to_activate);
+        seat->priv->session_to_activate = NULL;
+    }
+
     display_server = session_get_display_server (session);
+    if (!display_server)
+    {
+        g_object_unref (session);
+        return;
+    }
 
     /* Cleanup */
     if (!IS_GREETER (session))
@@ -479,9 +596,6 @@ session_stopped_cb (Session *session, Seat *seat)
             run_script (seat, display_server, script, session_get_user (session));
     }
 
-    g_signal_handlers_disconnect_matched (session, G_SIGNAL_MATCH_DATA, 0, 0, NULL, NULL, seat);
-    seat->priv->sessions = g_list_remove (seat->priv->sessions, session);
-
     /* We were waiting for this session, but it didn't start :( */
     // FIXME: Start a greeter on this?
     if (session == seat->priv->session_to_activate)
@@ -498,7 +612,8 @@ session_stopped_cb (Session *session, Seat *seat)
     }
 
     /* If this is the greeter session then re-use this display server */
-    if (IS_GREETER (session) && seat->priv->share_display_server &&
+    if (IS_GREETER (session) &&
+        can_share_display_server (seat, display_server) &&
         greeter_get_start_session (GREETER (session)))
     {
         GList *link;
@@ -595,11 +710,13 @@ set_session_env (Session *session)
 }
 
 static Session *
-create_session (Seat *seat, gboolean autostart)
+create_session (Seat *seat, gboolean autostart, const gchar *username)
 {
     Session *session;
+    Session *user_session;
 
-    session = SEAT_GET_CLASS (seat)->create_session (seat);
+    user_session = find_user_session (seat, username);
+    session = SEAT_GET_CLASS (seat)->create_session (seat, user_session);
     seat->priv->sessions = g_list_append (seat->priv->sessions, session);
     if (autostart)
         g_signal_connect (session, "authentication-complete", G_CALLBACK (session_authentication_complete_cb), seat);
@@ -613,48 +730,29 @@ create_session (Seat *seat, gboolean autostart)
 }
 
 static gchar **
-get_session_argv_from_filename (const gchar *filename, const gchar *session_wrapper)
+get_session_argv (SessionConfig *session_config, const gchar *session_wrapper)
 {
-    GKeyFile *session_desktop_file;
     gboolean result;
     int argc;
-    gchar *command = NULL, **argv, *path;
+    gchar **argv, *path;
     GError *error = NULL;
 
-    /* Read the command from the .desktop file */
-    session_desktop_file = g_key_file_new ();
-    result = g_key_file_load_from_file (session_desktop_file, filename, G_KEY_FILE_NONE, &error);
-    if (error)
-        g_debug ("Failed to load session file %s: %s", filename, error->message);
-    g_clear_error (&error);
-    if (result)
-    {
-        command = g_key_file_get_string (session_desktop_file, G_KEY_FILE_DESKTOP_GROUP, G_KEY_FILE_DESKTOP_KEY_EXEC, NULL);
-        if (!command)
-            g_debug ("No command in session file %s", filename);
-    }
-    g_key_file_free (session_desktop_file);
-
-    if (!command)
-        return NULL;
-
     /* If configured, run sessions through a wrapper */
     if (session_wrapper)
     {
         argv = g_malloc (sizeof (gchar *) * 3);
         path = g_find_program_in_path (session_wrapper);
         argv[0] = path ? path : g_strdup (session_wrapper);
-        argv[1] = command;
+        argv[1] = g_strdup (session_config_get_command (session_config));
         argv[2] = NULL;
         return argv;
     }
 
     /* Split command into an array listing and make command absolute */
-    result = g_shell_parse_argv (command, &argc, &argv, &error);
+    result = g_shell_parse_argv (session_config_get_command (session_config), &argc, &argv, &error);
     if (error)
-        g_debug ("Invalid session command '%s': %s", command, error->message);
+        g_debug ("Invalid session command '%s': %s", session_config_get_command (session_config), error->message);
     g_clear_error (&error);
-    g_free (command);
     if (!result)
         return NULL;
     path = g_find_program_in_path (argv[0]);
@@ -667,11 +765,13 @@ get_session_argv_from_filename (const gchar *filename, const gchar *session_wrap
     return argv;
 }
 
-static gchar **
-get_session_argv (const gchar *sessions_dir, const gchar *session_name, const gchar *session_wrapper)
+static SessionConfig *
+find_session_config (const gchar *sessions_dir, const gchar *session_name)
 {
-    gchar **dirs, **argv = NULL;
+    gchar **dirs;
+    SessionConfig *session_config = NULL;
     int i;
+    GError *error = NULL;
 
     g_return_val_if_fail (sessions_dir != NULL, NULL);
     g_return_val_if_fail (session_name != NULL, NULL);
@@ -684,24 +784,31 @@ get_session_argv (const gchar *sessions_dir, const gchar *session_name, const gc
         filename = g_strdup_printf ("%s.desktop", session_name);
         path = g_build_filename (dirs[i], filename, NULL);
         g_free (filename);
-        argv = get_session_argv_from_filename (path, session_wrapper);
+        session_config = session_config_new_from_file (path, &error);
         g_free (path);
-        if (argv)
+        if (session_config)
             break;
+
+        if (dirs[i+1] == NULL)
+            g_debug ("Failed to find session configuration %s", session_name);
+        g_clear_error (&error);
     }
     g_strfreev (dirs);
 
-    return argv;
+    return session_config;
 }
 
 static Session *
 create_user_session (Seat *seat, const gchar *username)
 {
     User *user;
-    gchar *sessions_dir, **argv;
+    gchar *sessions_dir;
     const gchar *session_name, *language;
+    SessionConfig *session_config;
     Session *session = NULL;
 
+    g_debug ("Creating user session");
+
     /* Load user preferences */
     user = accounts_get_user_by_name (username);
     if (!user)
@@ -715,13 +822,20 @@ create_user_session (Seat *seat, const gchar *username)
     if (!session_name)
         session_name = seat_get_string_property (seat, "user-session");
     sessions_dir = config_get_string (config_get_instance (), "LightDM", "sessions-directory");
-    argv = get_session_argv (sessions_dir, session_name, seat_get_string_property (seat, "session-wrapper"));
+    session_config = find_session_config (sessions_dir, session_name);
     g_free (sessions_dir);
-    if (argv)
+    if (session_config)
     {
-        session = create_session (seat, TRUE);
+        const gchar *desktop_name;
+        gchar **argv;
+
+        session = create_session (seat, TRUE, username);
+        session_set_session_type (session, session_config_get_session_type (session_config));
         session_set_env (session, "DESKTOP_SESSION", session_name);
         session_set_env (session, "GDMSESSION", session_name);
+        desktop_name = session_config_get_desktop_name (session_config);
+        if (desktop_name)
+            session_set_env (session, "XDG_CURRENT_DESKTOP", desktop_name);
         if (language && language[0] != '\0')
         {
             session_set_env (session, "LANG", language);
@@ -730,11 +844,16 @@ create_user_session (Seat *seat, const gchar *username)
         session_set_pam_service (session, AUTOLOGIN_SERVICE);
         session_set_username (session, username);
         session_set_do_authenticate (session, TRUE);
-        session_set_argv (session, argv);     
+        argv = get_session_argv (session_config, seat_get_string_property (seat, "session-wrapper"));
+        session_set_argv (session, argv);
+        g_strfreev (argv);
+
+        g_object_unref (session_config);
     }
     else
         g_debug ("Can't find session '%s'", seat_get_string_property (seat, "user-session"));
 
+
     g_object_unref (user);
 
     return session;
@@ -744,33 +863,37 @@ static Session *
 create_guest_session (Seat *seat)
 {
     gchar *sessions_dir, **argv;
+    SessionConfig *session_config;
     Session *session;
 
     sessions_dir = config_get_string (config_get_instance (), "LightDM", "sessions-directory");
-    argv = get_session_argv (sessions_dir,
-                             seat_get_string_property (seat, "user-session"),
-                             seat_get_string_property (seat, "session-wrapper"));
+    session_config = find_session_config (sessions_dir, seat_get_string_property (seat, "user-session"));
     g_free (sessions_dir);
-    if (!argv)
+    if (!session_config)
     {
         g_debug ("Can't find session '%s'", seat_get_string_property (seat, "user-session"));
         return NULL;
     }
 
-    session = create_session (seat, TRUE);
+    session = create_session (seat, TRUE, NULL);
+    session_set_session_type (session, session_config_get_session_type (session_config));
     session_set_do_authenticate (session, TRUE);
     session_set_is_guest (session, TRUE);
+    argv = get_session_argv (session_config, seat_get_string_property (seat, "session-wrapper"));
+    g_object_unref (session_config);
     session_set_argv (session, argv);
+    g_strfreev (argv);
   
     return session;
 }
 
 static Session *
-greeter_create_session_cb (Greeter *greeter, Seat *seat)
+greeter_create_session_cb (Greeter *greeter, Seat *seat, const gchar *username)
 {
     Session *session;
 
-    session = create_session (seat, FALSE);
+    session = create_session (seat, FALSE, username);
+    session_set_session_type (session, session_get_session_type (SESSION (greeter)));
     session_set_display_server (session, session_get_display_server (SESSION (greeter)));
 
     return g_object_ref (session);
@@ -793,33 +916,16 @@ prepend_argv (gchar ***argv, const gchar *value)
     *argv = new_argv;
 }
 
-static Session *
-find_user_session (Seat *seat, const gchar *username)
-{
-    GList *link;
-
-    if (!username)
-        return NULL;
-
-    for (link = seat->priv->sessions; link; link = link->next)
-    {
-        Session *session = link->data;
-
-        if (!session_get_is_stopping (session) && strcmp (session_get_username (session), username) == 0)
-            return session;
-    }
-
-    return NULL;
-}
-
 static gboolean
 greeter_start_session_cb (Greeter *greeter, SessionType type, const gchar *session_name, Seat *seat)
 {
     Session *session, *existing_session;
     const gchar *username, *language = NULL;
+    SessionConfig *session_config;
     User *user;
     gchar *sessions_dir = NULL;
     gchar **argv;
+    DisplayServer *display_server;
 
     /* Get the session to use */
     if (greeter_get_guest_authenticated (greeter))
@@ -873,15 +979,16 @@ greeter_start_session_cb (Greeter *greeter, SessionType type, const gchar *sessi
     if (user)
         user_set_xsession (session_get_user (session), session_name);
 
-    argv = get_session_argv (sessions_dir, session_name, seat_get_string_property (seat, "session-wrapper"));
+    session_config = find_session_config (sessions_dir, session_name);
     g_free (sessions_dir);
-  
-    if (!argv)
+    if (!session_config)
     {
         g_debug ("Can't find session '%s'", seat_get_string_property (seat, "user-session"));
         return FALSE;
     }
 
+    session_set_session_type (session, session_config_get_session_type (session_config));
+    argv = get_session_argv (session_config, seat_get_string_property (seat, "session-wrapper"));
     session_set_argv (session, argv);
     g_strfreev (argv);
     session_set_env (session, "DESKTOP_SESSION", session_name);
@@ -892,13 +999,19 @@ greeter_start_session_cb (Greeter *greeter, SessionType type, const gchar *sessi
         session_set_env (session, "GDM_LANG", language);
     }
 
+    g_object_unref (session_config);
+
     /* If can re-use the display server, stop the greeter first */
-    if (seat->priv->share_display_server)
+    display_server = session_get_display_server (SESSION (greeter));
+    if (can_share_display_server (seat, display_server) &&
+        strcmp (display_server_get_session_type (display_server), session_get_session_type (session)) == 0)
     {
+        g_debug ("Stopping greeter; display server will be re-used for user session");
+
         /* Run on the same display server after the greeter has stopped */
-        session_set_display_server (session, session_get_display_server (SESSION (greeter)));
+        session_set_display_server (session, display_server);
 
-        g_debug ("Stopping greeter");
+        /* Stop the greeter */
         session_stop (SESSION (greeter));
 
         return TRUE;
@@ -906,13 +1019,13 @@ greeter_start_session_cb (Greeter *greeter, SessionType type, const gchar *sessi
     /* Otherwise start a new display server for this session */
     else
     {
-        DisplayServer *display_server;
-
-        display_server = create_display_server (seat);
+        display_server = create_display_server (seat, session_get_session_type (session));
+        session_set_display_server (session, display_server);
         if (!display_server_start (display_server))
+        {
+            g_debug ("Failed to start display server for new session");
             return FALSE;
-
-        session_set_display_server (session, display_server);
+        }
 
         return TRUE;
     }
@@ -922,18 +1035,20 @@ static Greeter *
 create_greeter_session (Seat *seat)
 {
     gchar *sessions_dir, **argv;
+    SessionConfig *session_config;
     Greeter *greeter_session;
     gchar *greeter_user;
     const gchar *greeter_wrapper;
 
+    g_debug ("Creating greeter session");
+
     sessions_dir = config_get_string (config_get_instance (), "LightDM", "greeters-directory");
-    argv = get_session_argv (sessions_dir,
-                             seat_get_string_property (seat, "greeter-session"),
-                             NULL);
+    session_config = find_session_config (sessions_dir, seat_get_string_property (seat, "greeter-session"));
     g_free (sessions_dir);
-    if (!argv)
+    if (!session_config)
         return NULL;
 
+    argv = get_session_argv (session_config, NULL);
     greeter_wrapper = seat_get_string_property (seat, "greeter-wrapper");
     if (greeter_wrapper)
     {
@@ -944,7 +1059,9 @@ create_greeter_session (Seat *seat)
     }
 
     greeter_session = SEAT_GET_CLASS (seat)->create_greeter_session (seat);
+    session_set_session_type (SESSION (greeter_session), session_config_get_session_type (session_config));
     seat->priv->sessions = g_list_append (seat->priv->sessions, SESSION (greeter_session));
+    g_signal_connect (greeter_session, "notify::active-username", G_CALLBACK (greeter_active_username_changed_cb), seat);
     g_signal_connect (greeter_session, "authentication-complete", G_CALLBACK (session_authentication_complete_cb), seat);
     g_signal_connect (greeter_session, "stopped", G_CALLBACK (session_stopped_cb), seat);
   
@@ -955,6 +1072,7 @@ create_greeter_session (Seat *seat)
     session_set_username (SESSION (greeter_session), greeter_user);
     g_free (greeter_user);
     session_set_argv (SESSION (greeter_session), argv);
+    g_strfreev (argv);
 
     greeter_set_pam_services (greeter_session, USER_SERVICE, AUTOLOGIN_SERVICE);
     g_signal_connect (greeter_session, "create-session", G_CALLBACK (greeter_create_session_cb), seat);
@@ -968,6 +1086,8 @@ create_greeter_session (Seat *seat)
     greeter_set_hint (greeter_session, "show-remote-login", seat_get_boolean_property (seat, "greeter-show-remote-login") ? "true" : "false");
     greeter_set_hint (greeter_session, "has-guest-account", seat_get_allow_guest (seat) && seat_get_boolean_property (seat, "greeter-allow-guest") ? "true" : "false");
 
+    g_object_unref (session_config);
+
     return greeter_session;
 }
 
@@ -1002,7 +1122,7 @@ display_server_ready_cb (DisplayServer *display_server, Seat *seat)
     }
 
     /* Stop if don't need to run a session */
-    if (!display_server_get_start_local_sessions (display_server))
+    if (!get_start_local_sessions (seat))
         return;
 
     emit_upstart_signal ("login-session-start");
@@ -1030,11 +1150,16 @@ display_server_ready_cb (DisplayServer *display_server, Seat *seat)
 }
 
 static DisplayServer *
-create_display_server (Seat *seat)
+create_display_server (Seat *seat, const gchar *session_type)
 {
     DisplayServer *display_server;
 
-    display_server = SEAT_GET_CLASS (seat)->create_display_server (seat, "");
+    g_debug ("Creating display server of type %s", session_type);
+
+    display_server = SEAT_GET_CLASS (seat)->create_display_server (seat, session_type);
+    if (!display_server)
+        return NULL;
+
     seat->priv->display_servers = g_list_append (seat->priv->display_servers, display_server);
     g_signal_connect (display_server, "ready", G_CALLBACK (display_server_ready_cb), seat);
     g_signal_connect (display_server, "stopped", G_CALLBACK (display_server_stopped_cb), seat);
@@ -1082,7 +1207,7 @@ seat_switch_to_greeter (Seat *seat)
         g_object_unref (seat->priv->session_to_activate);
     seat->priv->session_to_activate = g_object_ref (greeter_session);
 
-    display_server = create_display_server (seat);
+    display_server = create_display_server (seat, session_get_session_type (SESSION (greeter_session)));
     session_set_display_server (SESSION (greeter_session), display_server);
     if (!display_server_start (display_server))
         return FALSE;
@@ -1120,7 +1245,7 @@ seat_switch_to_user (Seat *seat, const gchar *username, const gchar *session_nam
     seat->priv->session_to_activate = g_object_ref (session);
     session_set_pam_service (session, USER_SERVICE);
 
-    display_server = create_display_server (seat);
+    display_server = create_display_server (seat, session_get_session_type (session));
     session_set_display_server (session, display_server);
     if (!display_server_start (display_server))
         return FALSE;
@@ -1163,13 +1288,14 @@ seat_switch_to_guest (Seat *seat, const gchar *session_name)
         return TRUE;
     }
 
-    display_server = create_display_server (seat);
-    if (!display_server_start (display_server))
-        return FALSE;
-
     session = create_guest_session (seat);
     if (!session)
         return FALSE;
+
+    display_server = create_display_server (seat, session_get_session_type (session));
+    if (!display_server_start (display_server))
+        return FALSE;
+
     if (seat->priv->session_to_activate)
         g_object_unref (seat->priv->session_to_activate);
     seat->priv->session_to_activate = g_object_ref (session);
@@ -1201,11 +1327,14 @@ seat_lock (Seat *seat, const gchar *username)
         return TRUE;
     }
 
-    display_server = create_display_server (seat);
+    greeter_session = create_greeter_session (seat);
+    if (!greeter_session)
+        return FALSE;
+
+    display_server = create_display_server (seat, session_get_session_type (SESSION (greeter_session)));
     if (!display_server_start (display_server))
         return FALSE;
 
-    greeter_session = create_greeter_session (seat);
     if (seat->priv->session_to_activate)
         g_object_unref (seat->priv->session_to_activate);
     seat->priv->session_to_activate = g_object_ref (greeter_session);
@@ -1237,6 +1366,12 @@ seat_get_is_stopping (Seat *seat)
     return seat->priv->stopping;
 }
 
+static gboolean
+seat_real_get_start_local_sessions (Seat *seat)
+{
+    return TRUE;
+}
+
 static void
 seat_real_setup (Seat *seat)
 {
@@ -1249,16 +1384,17 @@ seat_real_start (Seat *seat)
     int autologin_timeout;
     gboolean autologin_guest;
     gboolean autologin_in_background;
-    Session *session = NULL;
-    DisplayServer *display_server;
+    Session *session = NULL, *background_session = NULL;
 
     g_debug ("Starting seat");
 
-    display_server = create_display_server (seat);
-
     /* If this display server doesn't have a session running on it, just start it */
-    if (!display_server_get_start_local_sessions (display_server))
+    if (!get_start_local_sessions (seat))
+    {
+        DisplayServer *display_server;
+        display_server = create_display_server (seat, "x"); // FIXME: Not necessarily an X seat, but not sure what to put here
         return display_server_start (display_server);
+    }
 
     /* Get autologin settings */
     autologin_username = seat_get_string_property (seat, "autologin-user");
@@ -1275,27 +1411,35 @@ seat_real_start (Seat *seat)
             session = create_guest_session (seat);
         else if (autologin_username != NULL)
             session = create_user_session (seat, autologin_username);
-      
+
         if (session)
-        {
-            if (seat->priv->session_to_activate)
-                g_object_unref (seat->priv->session_to_activate);
-            seat->priv->session_to_activate = g_object_ref (session);
             session_set_pam_service (session, AUTOLOGIN_SERVICE);
-        }
 
         /* Load in background if required */
         if (autologin_in_background && session)
         {
-            DisplayServer *background_display_server;
+            background_session = session;
+            session = NULL;
+        }
+      
+        if (session)
+        {
+            DisplayServer *display_server;
 
-            background_display_server = create_display_server (seat);
-            session_set_display_server (session, background_display_server);
-            if (!display_server_start (background_display_server))
-                return FALSE;
+            if (seat->priv->session_to_activate)
+                g_object_unref (seat->priv->session_to_activate);
+            seat->priv->session_to_activate = g_object_ref (session);
 
-            /* Start a greeter as well */
-            session = NULL;
+            display_server = create_display_server (seat, session_get_session_type (session));
+            session_set_display_server (session, display_server);
+            if (!display_server || !display_server_start (display_server))
+            {
+                g_debug ("Can't create display server for automatic login");
+                session_stop (session);
+                if (display_server)
+                    display_server_stop (display_server);
+                session = NULL;
+            }
         }
     }
 
@@ -1303,8 +1447,15 @@ seat_real_start (Seat *seat)
     if (!session)
     {
         Greeter *greeter_session;
+        DisplayServer *display_server;
 
         greeter_session = create_greeter_session (seat);
+        if (!greeter_session)
+        {
+            g_debug ("Failed to create greeter session");
+            return FALSE;
+        }
+
         if (seat->priv->session_to_activate)
             g_object_unref (seat->priv->session_to_activate);
         seat->priv->session_to_activate = g_object_ref (greeter_session);
@@ -1322,6 +1473,17 @@ seat_real_start (Seat *seat)
             if (autologin_guest)
                 greeter_set_hint (greeter_session, "autologin-guest", "true");
         }
+
+        display_server = create_display_server (seat, session_get_session_type (session));
+        session_set_display_server (session, display_server);
+        if (!display_server || !display_server_start (display_server))
+        {
+            g_debug ("Can't create display server for greeter");
+            session_stop (session);
+            if (display_server)
+                display_server_stop (display_server);
+            session = NULL;
+        }
     }
 
     /* Fail if can't start a session */
@@ -1331,18 +1493,31 @@ seat_real_start (Seat *seat)
         return FALSE;
     }
 
-    /* Start display server to show session on */
-    session_set_display_server (session, display_server);
-    if (!display_server_start (display_server))
-        return FALSE;
+    /* Start background session */
+    if (background_session)
+    {
+        DisplayServer *background_display_server;
 
+        background_display_server = create_display_server (seat, session_get_session_type (background_session));
+        session_set_display_server (background_session, background_display_server);
+        if (!display_server_start (background_display_server))
+            g_warning ("Failed to start display server for background session");
+    }
+
+    seat->priv->started = TRUE;
     return TRUE;
 }
 
-static DisplayServer *
-seat_real_create_display_server (Seat *seat, const gchar *session_type)
+static Greeter *
+seat_real_create_greeter_session (Seat *seat)
 {
-    return NULL;
+    return greeter_new ();
+}
+
+static Session *
+seat_real_create_session (Seat *seat, Session *user_session)
+{
+    return session_new ();
 }
 
 static void
@@ -1350,6 +1525,11 @@ seat_real_set_active_session (Seat *seat, Session *session)
 {
 }
 
+static void
+seat_real_set_next_session (Seat *seat, Session *session)
+{
+}
+
 static Session *
 seat_real_get_active_session (Seat *seat)
 {
@@ -1424,6 +1604,10 @@ seat_finalize (GObject *object)
         g_signal_handlers_disconnect_matched (session, G_SIGNAL_MATCH_DATA, 0, 0, NULL, NULL, self);
     }
     g_list_free_full (self->priv->sessions, g_object_unref);
+    if (self->priv->active_session)
+        g_object_unref (self->priv->active_session);
+    if (self->priv->next_session)
+        g_object_unref (self->priv->next_session);
     if (self->priv->session_to_activate)
         g_object_unref (self->priv->session_to_activate);
 
@@ -1435,11 +1619,14 @@ seat_class_init (SeatClass *klass)
 {
     GObjectClass *object_class = G_OBJECT_CLASS (klass);
 
+    klass->get_start_local_sessions = seat_real_get_start_local_sessions;
     klass->setup = seat_real_setup;
     klass->start = seat_real_start;
-    klass->create_display_server = seat_real_create_display_server;
+    klass->create_greeter_session = seat_real_create_greeter_session;
+    klass->create_session = seat_real_create_session;
     klass->set_active_session = seat_real_set_active_session;
     klass->get_active_session = seat_real_get_active_session;
+    klass->set_next_session = seat_real_set_next_session;
     klass->run_script = seat_real_run_script;
     klass->stop = seat_real_stop;