]> rtime.felk.cvut.cz Git - pes-rpp/rpp-test-sw.git/blobdiff - rpp-test-sw/commands/cmd_hout.c
hout: Do not use variably sized local array
[pes-rpp/rpp-test-sw.git] / rpp-test-sw / commands / cmd_hout.c
index 71a5a75c78d15bde19ff402f3e2a857294e516bf..9a37e9d02f4cb71a3cd941e4f90be65774f52f2d 100644 (file)
@@ -42,9 +42,10 @@ int cmd_do_read_hout_ifbk_values(cmd_io_t *cmd_io, const struct cmd_des *des, ch
 {
        uint32_t i;
        const struct port_desc *port = &port_desc[PORT_ID_HOUTIFBK];
-       uint16_t values[port->numchn];
+       uint16_t values[6];
        int ret;
 
+       assert(ARRAY_SIZE(values) == port->numchn);
 
        ret = port->get(port, values, sizeof(values));
        if (ret < 0)
@@ -126,7 +127,7 @@ int cmd_do_hout_pwm(cmd_io_t *cmd_io, const struct cmd_des *des, char *param[])
                double period = hout_pwm_get_period(pin);
                uint32_t duty = hout_pwm_get_duty(pin);
 
-               rpp_sci_printf("houtpwm%d_period=%g\r\nhoutpwm%d_duty=%u%%", pin+1, period, pin+1, duty);
+               rpp_sci_printf("houtpwm%d_period=%g\r\nhoutpwm%d_duty=%u%%\n", pin+1, period, pin+1, duty);
                return 0;
        }
 }
@@ -270,7 +271,7 @@ cmd_des_t const cmd_des_hout_pwm = {
        "\n"
        "    --> houtpwm1\n"
        "    houtpwm1_period=1000\n"
-       "    houtpwm1_duty=25\n"
+       "    houtpwm1_duty=25%\n"
        "\n"
        "Prints the actual period of HOUT1 PWM in microseconds and the duty\n"
        "cycle in percents.\n",