From: Michal Sojka <sojkam1@fel.cvut.cz>
Date: Tue, 25 Nov 2014 11:01:25 +0000 (+0100)
Subject: Change target connection warning to error
X-Git-Tag: 20141125~1
X-Git-Url: http://rtime.felk.cvut.cz/gitweb/novaboot.git/commitdiff_plain/44e4e6fda486ad18f192e2ab473be9f309be7311

Change target connection warning to error

In the previous commit I argued that it is a valid use case to override
target connection option from command line. I realized that this is not
true, because the implementation does not know which option was given
last and the effective option is determined by the implementation and
not by the position on the command line. Therefore, it is almost always
an error to specify target connection option multiple times.
---

diff --git a/novaboot b/novaboot
index c2e391e..0dd1beb 100755
--- a/novaboot
+++ b/novaboot
@@ -263,7 +263,7 @@ if ($ider) {
 		      '--amt'	     => \$amt);
     my @opts = grep(defined(${$input_opts{$_}}) , keys %input_opts);
 
-    print STDERR "novaboot: Warning: More than one target connection option: ".join(', ', @opts) if scalar @opts > 1;
+    die("novaboot: More than one target connection option: ".join(', ', @opts)) if scalar @opts > 1;
 }
 
 # Default options