From be55acf4f0379b964e8c85cb20e2834b25842f4d Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Thu, 9 Jun 2016 22:20:56 +0300 Subject: [PATCH] test/notmuch-test: simple streamlining A few simple things that applies well to test/notmuch-test.sh - Shell does pathname expansion also without doing `echo ...` in subshell. - Redirections >/dev/null 2>/dev/null hide (improbable but) potential serious errors; adding -f to rm instead. - Inter-file capitalization consistency in comments. - Unnecesary space removal. --- test/notmuch-test | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/notmuch-test b/test/notmuch-test index 988dce6c..e7d3151c 100755 --- a/test/notmuch-test +++ b/test/notmuch-test @@ -17,14 +17,14 @@ fi cd "$(dirname "$0")" -TESTS=${NOTMUCH_TESTS:-`echo T[0-9][0-9][0-9]-*.sh`} +TESTS=${NOTMUCH_TESTS:-T[0-9][0-9][0-9]-*.sh} # Clean up any results from a previous run -rm -r test-results >/dev/null 2>/dev/null +rm -rf test-results -# test for timeout utility +# Test for timeout utility if command -v timeout >/dev/null; then - TEST_TIMEOUT_CMD="timeout 2m " + TEST_TIMEOUT_CMD="timeout 2m" echo "INFO: using 2 minute timeout for tests" else TEST_TIMEOUT_CMD="" -- 2.39.2