From: Tomi Ollila Date: Wed, 25 May 2016 21:04:32 +0000 (+0300) Subject: Makefile.local: use $(wildcard) to check existence of ${srcdir}/.git X-Git-Url: http://rtime.felk.cvut.cz/gitweb/notmuch.git/commitdiff_plain/e0e6a17675a4f4f56f2c6891aaf7eb50f404ffd2?hp=17341ec798b4cb2fe192824bcf8b7e78236e4121 Makefile.local: use $(wildcard) to check existence of ${srcdir}/.git With this GNU Make construct one shell invocation can be skipped and code looks shorter (narrower). This would now match to .git being other file type than regular file or directory (or symlink to those), but that is not a use case anyone should expect users to do. --- diff --git a/Makefile.local b/Makefile.local index 20041947..5587cd2c 100644 --- a/Makefile.local +++ b/Makefile.local @@ -10,7 +10,7 @@ # repository), we let git append identification of the actual commit. PACKAGE=notmuch -IS_GIT:=$(shell if [ -d ${srcdir}/.git -o -f ${srcdir}/.git ] ; then echo yes ; else echo no; fi) +IS_GIT:=$(if $(wildcard ${srcdir}/.git),yes,no) ifeq ($(IS_GIT),yes) DATE:=$(shell git --git-dir=${srcdir}/.git log --date=short -1 --pretty=format:%cd)