]> rtime.felk.cvut.cz Git - lisovros/qemu_apohw.git/commit
util/error: Save errno from clobbering
authorMax Reitz <mreitz@redhat.com>
Thu, 7 Nov 2013 19:10:29 +0000 (20:10 +0100)
committerKevin Wolf <kwolf@redhat.com>
Thu, 28 Nov 2013 09:30:52 +0000 (10:30 +0100)
commitb276d2499428795629eee8ee93ba1ea100bb1bc9
treed81a972f092b0d0f35b26a00601382a24eb4dcd1
parent5a37b60a61c4c334e3b194758871f41494317d42
util/error: Save errno from clobbering

There may be calls to error_setg() and especially error_setg_errno()
which blindly (and until now wrongly) assume these functions not to
clobber errno (e.g., they pass errno to error_setg_errno() and return
-errno afterwards). Instead of trying to find and fix all of these
constructs, just make sure error_setg() and error_setg_errno() indeed do
not clobber errno.

Suggested-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
util/error.c