]> rtime.felk.cvut.cz Git - lisovros/qemu_apohw.git/commit
vt82c686: avoid out-of-bounds read
authorPaolo Bonzini <pbonzini@redhat.com>
Wed, 10 Dec 2014 09:17:36 +0000 (10:17 +0100)
committerMichael Tokarev <mjt@tls.msk.ru>
Thu, 15 Jan 2015 07:44:13 +0000 (10:44 +0300)
commit9feb8adeaa850d15b930c30f22c1ed2f2f695172
treed35334179830c5f9344ae9af290de2167d73cc61
parentb629a38a13745d62d44de8ebb00f4e38ec6d8f7e
vt82c686: avoid out-of-bounds read

superio_ioport_readb can read the 256th element of the array.
Coverity reports an out-of-bounds write in superio_ioport_writeb,
but it does not show the corresponding out-of-bounds read
because it cannot prove that it can happen.  Fix the root
cause of the problem (zhanghailang's patch instead fixes
the logic in superio_ioport_writeb).

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-stable@nongnu.org
hw/isa/vt82c686.c