]> rtime.felk.cvut.cz Git - lisovros/qemu_apohw.git/commit
virtio-9p: fixed LE-to-host conversion bug when QEMU is called from guest
authorAlexey Kardashevskiy <aik@ozlabs.ru>
Thu, 7 Apr 2011 03:02:03 +0000 (13:02 +1000)
committerStefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Thu, 7 Apr 2011 13:25:53 +0000 (14:25 +0100)
commit4e37bfc1f0fcd17e48bfae233e0b45066830e126
tree3b6c94154cce64cb2c7a88748675befc80296ed4
parentfa227023f044552ec48ca851411dba2f268a912c
virtio-9p: fixed LE-to-host conversion bug when QEMU is called from guest

The 9p code already contains an attempt at the necessary endian
conversions, but it's broken.

The code which does conversion from host to guest does it correctly
and this code was copied to the function which does guest to host
conversion.  However the copied code hasn't been correctly updated, so
it first endian converts some garbage on the stack and then overwrites
it with a field from incoming packet without conversion.

The patch fixes the mistakes.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
hw/virtio-9p.c