]> rtime.felk.cvut.cz Git - lisovros/qemu_apohw.git/commit
vnc: Fix tight_detect_smooth_image() for lossless case
authorMarkus Armbruster <armbru@redhat.com>
Fri, 21 Feb 2014 15:42:52 +0000 (16:42 +0100)
committerGerd Hoffmann <kraxel@redhat.com>
Mon, 10 Mar 2014 11:35:04 +0000 (12:35 +0100)
commit2e7bcdb99adbd8fc10ad9ddcf93bd2bf3c0f1f2d
treecafb54a850ceec1a0a29289ce76d993d6e67751a
parentf53f3d0a00b6df39ce8dfca942608e5b6a9a4f71
vnc: Fix tight_detect_smooth_image() for lossless case

VncTight member uint8_t quality is either (uint8_t)-1 for lossless or
less than 10 for lossy.

tight_detect_smooth_image() first promotes it to int, then compares
with -1.  Always unequal, so we always execute the lossy code.  Reads
beyond tight_conf[] and returns crap when quality is actually
lossless.

Compare to (uint8_t)-1 instead, like we do elsewhere.

Spotted by Coverity.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
ui/vnc-enc-tight.c