]> rtime.felk.cvut.cz Git - lisovros/qemu_apohw.git/commit
chardev: clear O_NONBLOCK on SCM_RIGHTS file descriptors
authorStefan Hajnoczi <stefanha@redhat.com>
Thu, 4 Apr 2013 14:18:31 +0000 (16:18 +0200)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Thu, 4 Apr 2013 20:17:32 +0000 (15:17 -0500)
commit27c71355fbf7f999f3fbb8ec42ec88210211b6f4
tree640d9047ac6a097f911511d2cfb14793d31b3226
parent283b7de6a57ff96db89d46874cfdb6fc590760dc
chardev: clear O_NONBLOCK on SCM_RIGHTS file descriptors

When we receive a file descriptor over a UNIX domain socket the
O_NONBLOCK flag is preserved.  Clear the O_NONBLOCK flag and rely on
QEMU file descriptor users like migration, SPICE, VNC, block layer, and
others to set non-blocking only when necessary.

This change ensures we don't accidentally expose O_NONBLOCK in the QMP
API.  QMP clients should not need to get the non-blocking state
"correct".

A recent real-world example was when libvirt passed a non-blocking TCP
socket for migration where we expected a blocking socket.  The source
QEMU produced a corrupted migration stream since its code did not cope
with non-blocking sockets.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
(cherry picked from commit e374f7f816171f9783c1d9d00a041f26379f1ac6)

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
qemu-char.c