]> rtime.felk.cvut.cz Git - lisovros/qemu_apohw.git/commit
block: for HMP commit() operations on 'all', skip non-COW drives
authorJeff Cody <jcody@redhat.com>
Tue, 26 Feb 2013 14:55:48 +0000 (09:55 -0500)
committerStefan Hajnoczi <stefanha@redhat.com>
Mon, 4 Mar 2013 08:54:17 +0000 (09:54 +0100)
commit272d2d8e1241b92ab9be87b2c8fb590fd84987a8
tree58c9564f3ab0afcd1a357037776ee56df35cee50
parent1b8bbb46e7593b92ded74cc2a5461202c2b6c05c
block: for HMP commit() operations on 'all', skip non-COW drives

During a commit of 'all' using the HMP non-live commit, the operation
is aborted and returns error on the first error enountered.  When
non-COW drives are in use (e.g. ejected floppy, cdrom, or drives without
a backing parent), that means a commit all will return an error of either
-ENOMEDIUM or -ENOTSUP.  This is not desirable, so for the 'all' commit
case, only attempt the commit if both bs->drv and bs->backing_hd are
present.

More succinctly: 'commit all' now means a commit on all COW drives.

This means an individual commit to a specific non-COW drive will still
return the appropriate error (-ENOMEDIUM if eject / not present, -ENOTSUP
if no backing file).

Reported-by: Jan Kiszka <jan.kiszka@web.de>
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
block.c