]> rtime.felk.cvut.cz Git - lisovros/linux_canprio.git/commit
block: Fix race during disk initialization
authorJan Kara <jack@suse.cz>
Thu, 16 Sep 2010 18:36:36 +0000 (20:36 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 9 Dec 2010 21:31:54 +0000 (13:31 -0800)
commit3dc40311eaf91cde40f29d799f430dc6a00c2a7c
tree116362bf5dda20b3e6e5351c165104665bfb6753
parent25e5735b6f05daa6c12f6483f458313ad6175b9a
block: Fix race during disk initialization

commit 01ea50638bc04ca5259f5711fcdedefcdde1cf43 upstream.

When a new disk is being discovered, add_disk() first ties the bdev to gendisk
(via register_disk()->blkdev_get()) and only after that calls
bdi_register_bdev(). Because register_disk() also creates disk's kobject, it
can happen that userspace manages to open and modify the device's data (or
inode) before its BDI is properly initialized leading to a warning in
__mark_inode_dirty().

Fix the problem by registering BDI early enough.

This patch addresses https://bugzilla.kernel.org/show_bug.cgi?id=16312

Reported-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
block/genhd.c