From fcbd0165fcf6d0efdfb02220ac77342ce0c0e224 Mon Sep 17 00:00:00 2001 From: Thomas Jarosch Date: Wed, 23 Nov 2011 22:15:19 +0100 Subject: [PATCH] tc: Use correct variable type for get_distribution() result get_distribution() returns an int. cppcheck reported: [tc/q_netem.c:243]: (style) Checking if unsigned variable 'dist_size' is less than zero. The mismatch actually rendered the error checking after get_distribution() ineffective. Signed-off-by: Thomas Jarosch --- tc/q_netem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tc/q_netem.c b/tc/q_netem.c index 01639a8..6dc40bd 100644 --- a/tc/q_netem.c +++ b/tc/q_netem.c @@ -125,7 +125,7 @@ static int get_ticks(__u32 *ticks, const char *str) static int netem_parse_opt(struct qdisc_util *qu, int argc, char **argv, struct nlmsghdr *n) { - size_t dist_size = 0; + int dist_size = 0; struct rtattr *tail; struct tc_netem_qopt opt; struct tc_netem_corr cor; -- 2.39.2