]> rtime.felk.cvut.cz Git - linux-lin.git/blobdiff - sllin/sllin.c
sllin: slave: don't forget to wait for the checksum
[linux-lin.git] / sllin / sllin.c
index 4f4da0f143ea9f79eb5aa4ef13c1663223eb6e90..b97219e565bad8ad2bc975a4267f9c36acecf0a8 100644 (file)
@@ -46,7 +46,6 @@
 #include <linux/module.h>
 #include <linux/moduleparam.h>
 
-#include <asm/system.h>
 #include <linux/uaccess.h>
 #include <linux/bitops.h>
 #include <linux/string.h>
@@ -80,7 +79,7 @@ MODULE_AUTHOR("Pavel Pisa <pisa@cmp.felk.cvut.cz>");
 #define SLLIN_MAGIC            0x53CA
 /* #define BREAK_BY_BAUD */
 
-static int master = true;
+static bool master = true;
 static int baudrate; /* Use LIN_DEFAULT_BAUDRATE when not set */
 
 module_param(master, bool, 0);
@@ -320,8 +319,7 @@ static void sllin_write_wakeup(struct tty_struct *tty)
        } while (unlikely(test_bit(SLF_TXBUFF_RQ, &sl->flags)));
 
        if ((remains > 0) && (actual >= 0)) {
-               pr_debug("sllin: sllin_write_wakeup sent %d, "
-                       "remains %d, waiting\n",
+               netdev_dbg(sl->dev, "sllin_write_wakeup sent %d, remains %d, waiting\n",
                        sl->tx_cnt, sl->tx_lim - sl->tx_cnt);
                return;
        }
@@ -330,7 +328,7 @@ static void sllin_write_wakeup(struct tty_struct *tty)
        set_bit(SLF_TXEVENT, &sl->flags);
        wake_up(&sl->kwt_wq);
 
-       pr_debug("sllin: sllin_write_wakeup sent %d, wakeup\n", sl->tx_cnt);
+       netdev_dbg(sl->dev, "sllin_write_wakeup sent %d, wakeup\n", sl->tx_cnt);
 }
 
 /**
@@ -349,11 +347,11 @@ static netdev_tx_t sll_xmit(struct sk_buff *skb, struct net_device *dev)
 
        spin_lock(&sl->lock);
        if (!netif_running(dev))  {
-               printk(KERN_WARNING "%s: xmit: iface is down\n", dev->name);
+               netdev_warn(sl->dev, "xmit: iface is down\n");
                goto err_out_unlock;
        }
        if (sl->tty == NULL) {
-               printk(KERN_WARNING "%s: xmit: no tty device connected\n", dev->name);
+               netdev_warn(sl->dev, "xmit: no tty device connected\n");
                goto err_out_unlock;
        }
 
@@ -407,7 +405,7 @@ static int sll_open(struct net_device *dev)
 {
        struct sllin *sl = netdev_priv(dev);
 
-       pr_debug("sllin: %s() invoked\n", __func__);
+       netdev_dbg(sl->dev, "%s() invoked\n", __func__);
 
        if (sl->tty == NULL)
                return -ENODEV;
@@ -445,7 +443,7 @@ static void sll_setup(struct net_device *dev)
 
        /* New-style flags. */
        dev->flags              = IFF_NOARP;
-       dev->features           = NETIF_F_NO_CSUM;
+       dev->features           = NETIF_F_HW_CSUM; /* NETIF_F_NO_CSUM;*/
 }
 
 /******************************************
@@ -459,7 +457,7 @@ static void sllin_master_receive_buf(struct tty_struct *tty,
        /* Read the characters out of the buffer */
        while (count--) {
                if (fp && *fp++) {
-                       pr_debug("sllin: sllin_receive_buf char 0x%02x ignored "
+                       netdev_dbg(sl->dev, "sllin_master_receive_buf char 0x%02x ignored "
                                "due marker 0x%02x, flags 0x%lx\n",
                                *cp, *(fp-1), sl->flags);
 
@@ -474,13 +472,13 @@ static void sllin_master_receive_buf(struct tty_struct *tty,
 #ifndef BREAK_BY_BAUD
                /* We didn't receive Break character -- fake it! */
                if ((sl->rx_cnt == SLLIN_BUFF_BREAK) && (*cp == 0x55)) {
-                       pr_debug("sllin: LIN_RX[%d]: 0x00\n", sl->rx_cnt);
+                       netdev_dbg(sl->dev, "LIN_RX[%d]: 0x00\n", sl->rx_cnt);
                        sl->rx_buff[sl->rx_cnt++] = 0x00;
                }
 #endif /* BREAK_BY_BAUD */
 
                if (sl->rx_cnt < SLLIN_BUFF_LEN) {
-                       pr_debug("sllin: LIN_RX[%d]: 0x%02x\n", sl->rx_cnt, *cp);
+                       netdev_dbg(sl->dev, "LIN_RX[%d]: 0x%02x\n", sl->rx_cnt, *cp);
                        sl->rx_buff[sl->rx_cnt++] = *cp++;
                }
        }
@@ -489,9 +487,9 @@ static void sllin_master_receive_buf(struct tty_struct *tty,
        if (sl->rx_cnt >= sl->rx_expect) {
                set_bit(SLF_RXEVENT, &sl->flags);
                wake_up(&sl->kwt_wq);
-               pr_debug("sllin: sllin_receive_buf count %d, wakeup\n", sl->rx_cnt);
+               netdev_dbg(sl->dev, "sllin_receive_buf count %d, wakeup\n", sl->rx_cnt);
        } else {
-               pr_debug("sllin: sllin_receive_buf count %d, waiting\n", sl->rx_cnt);
+               netdev_dbg(sl->dev, "sllin_receive_buf count %d, waiting\n", sl->rx_cnt);
        }
 }
 
@@ -507,7 +505,7 @@ static void sllin_slave_receive_buf(struct tty_struct *tty,
        /* Read the characters out of the buffer */
        while (count--) {
                if (fp && *fp++) {
-                       pr_debug("sllin: sllin_receive_buf char 0x%02x ignored "
+                       netdev_dbg(sl->dev, "sllin_slave_receive_buf char 0x%02x ignored "
                                "due marker 0x%02x, flags 0x%lx\n",
                                *cp, *(fp-1), sl->flags);
 
@@ -519,18 +517,16 @@ static void sllin_slave_receive_buf(struct tty_struct *tty,
                }
 
                if (sl->rx_cnt < SLLIN_BUFF_LEN) {
-                       pr_debug("sllin: LIN_RX[%d]: 0x%02x\n", sl->rx_cnt, *cp);
+                       netdev_dbg(sl->dev, "LIN_RX[%d]: 0x%02x\n", sl->rx_cnt, *cp);
 
                        /* We did not receive break (0x00) character */
                        if ((sl->rx_cnt == SLLIN_BUFF_BREAK) && (*cp == 0x55)) {
                                sl->rx_buff[sl->rx_cnt++] = 0x00;
-                               sl->rx_buff[sl->rx_cnt++] = 0x55;
-                               cp++;
                        }
 
                        if (sl->rx_cnt == SLLIN_BUFF_SYNC) {
                                /* 'Duplicated' break character -- ignore */
-                               if ((*cp == 0x00) && (*(cp + 1) == 0x55)) {
+                               if (*cp == 0x00) {
                                        cp++;
                                        continue;
                                }
@@ -551,9 +547,10 @@ static void sllin_slave_receive_buf(struct tty_struct *tty,
                        sce = &sl->linfr_cache[lin_id];
 
                        spin_lock_irqsave(&sl->linfr_lock, flags);
+
                        /* Is the length of data set in frame cache? */
-                       if (sce->frame_fl & LIN_LOC_SLAVE_CACHE) {
-                               sl->rx_expect += sce->dlc;
+                       if (sce->frame_fl & LIN_CACHE_RESPONSE) {
+                               sl->rx_expect += sce->dlc + 1; /* + checksum */
                                sl->rx_len_unknown = false;
                        } else {
                                sl->rx_expect += SLLIN_DATA_MAX + 1; /* + checksum */
@@ -562,6 +559,7 @@ static void sllin_slave_receive_buf(struct tty_struct *tty,
                        spin_unlock_irqrestore(&sl->linfr_lock, flags);
 
                        sl->header_received = true;
+
                        sll_send_rtr(sl);
                        continue;
                }
@@ -572,7 +570,7 @@ static void sllin_slave_receive_buf(struct tty_struct *tty,
                        ((sl->rx_len_unknown == true) && (count == 0)))) {
 
                        sll_bump(sl);
-                       pr_debug("sllin: Received LIN header & LIN response. "
+                       netdev_dbg(sl->dev, "Received LIN header & LIN response. "
                                        "rx_cnt = %u, rx_expect = %u\n", sl->rx_cnt,
                                        sl->rx_expect);
 
@@ -589,7 +587,7 @@ static void sllin_receive_buf(struct tty_struct *tty,
                              const unsigned char *cp, char *fp, int count)
 {
        struct sllin *sl = (struct sllin *) tty->disc_data;
-       pr_debug("sllin: sllin_receive_buf invoked, count = %u\n", count);
+       netdev_dbg(sl->dev, "sllin_receive_buf invoked, count = %u\n", count);
 
        if (!sl || sl->magic != SLLIN_MAGIC || !netif_running(sl->dev))
                return;
@@ -611,7 +609,7 @@ static void sllin_receive_buf(struct tty_struct *tty,
  * @sl:
  * @err: Error flag to be sent.
  */
-void sllin_report_error(struct sllin *sl, int err)
+static void sllin_report_error(struct sllin *sl, int err)
 {
        switch (err) {
        case LIN_ERR_CHECKSUM:
@@ -643,12 +641,12 @@ static int sllin_configure_frame_cache(struct sllin *sl, struct can_frame *cf)
        unsigned long flags;
        struct sllin_conf_entry *sce;
 
-       if (!(cf->can_id & LIN_ID_CONF))
+       if (!(cf->can_id & LIN_CTRL_FRAME))
                return -1;
 
        sce = &sl->linfr_cache[cf->can_id & LIN_ID_MASK];
-       pr_debug("sllin: Setting frame cache with EFF CAN frame. "
-               "LIN ID = %d\n", cf->can_id & LIN_ID_MASK);
+       netdev_dbg(sl->dev, "Setting frame cache with EFF CAN frame. LIN ID = %d\n",
+               cf->can_id & LIN_ID_MASK);
 
        spin_lock_irqsave(&sl->linfr_lock, flags);
 
@@ -696,7 +694,7 @@ static inline unsigned sllin_checksum(unsigned char *data, int length, int enhan
 #define SLLIN_STPMSG_CHCKSUM_CLS       (1 << 1)
 #define SLLIN_STPMSG_CHCKSUM_ENH       (1 << 2)
 
-int sllin_setup_msg(struct sllin *sl, int mode, int id,
+static int sllin_setup_msg(struct sllin *sl, int mode, int id,
                unsigned char *data, int len)
 {
        if (id > LIN_ID_MASK)
@@ -717,8 +715,9 @@ int sllin_setup_msg(struct sllin *sl, int mode, int id,
        if ((data != NULL) && len) {
                sl->tx_lim += len;
                memcpy(sl->tx_buff + SLLIN_BUFF_DATA, data, len);
-               sl->tx_buff[sl->tx_lim++] = sllin_checksum(sl->tx_buff,
+               sl->tx_buff[sl->tx_lim] = sllin_checksum(sl->tx_buff,
                                sl->tx_lim, mode & SLLIN_STPMSG_CHCKSUM_ENH);
+               sl->tx_lim++;
        }
        if (len != 0)
                sl->rx_lim = SLLIN_BUFF_DATA + len + 1;
@@ -737,7 +736,7 @@ static void sllin_reset_buffs(struct sllin *sl)
        sl->data_to_send = false;
 }
 
-int sllin_send_tx_buff(struct sllin *sl)
+static int sllin_send_tx_buff(struct sllin *sl)
 {
        struct tty_struct *tty = sl->tty;
        int remains;
@@ -779,7 +778,7 @@ int sllin_send_tx_buff(struct sllin *sl)
                        sl->tx_cnt += res;
                }
 
-               pr_debug("sllin: sllin_send_tx_buff sent %d, remains %d\n",
+               netdev_dbg(sl->dev, "sllin_send_tx_buff sent %d, remains %d\n",
                                sl->tx_cnt, remains);
 
                clear_bit(SLF_TXBUFF_INPR, &sl->flags);
@@ -796,7 +795,7 @@ error_in_write:
 }
 
 #ifdef BREAK_BY_BAUD
-int sllin_send_break(struct sllin *sl)
+static int sllin_send_break(struct sllin *sl)
 {
        struct tty_struct *tty = sl->tty;
        unsigned long break_baud;
@@ -821,7 +820,7 @@ int sllin_send_break(struct sllin *sl)
 }
 #else /* BREAK_BY_BAUD */
 
-int sllin_send_break(struct sllin *sl)
+static int sllin_send_break(struct sllin *sl)
 {
        struct tty_struct *tty = sl->tty;
        int retval;
@@ -854,7 +853,7 @@ int sllin_send_break(struct sllin *sl)
 
        sl->tx_cnt = SLLIN_BUFF_SYNC;
 
-       pr_debug("sllin: Break sent.\n");
+       netdev_dbg(sl->dev, "Break sent.\n");
        set_bit(SLF_RXEVENT, &sl->flags);
        wake_up(&sl->kwt_wq);
 
@@ -917,7 +916,7 @@ static int sllin_rx_validate(struct sllin *sl)
  *  sllin_kwthread - kernel worker thread
  *****************************************/
 
-int sllin_kwthread(void *ptr)
+static int sllin_kwthread(void *ptr)
 {
        struct sllin *sl = (struct sllin *)ptr;
        struct tty_struct *tty = sl->tty;
@@ -925,7 +924,7 @@ int sllin_kwthread(void *ptr)
        int tx_bytes = 0; /* Used for Network statistics */
 
 
-       pr_debug("sllin: sllin_kwthread started.\n");
+       netdev_dbg(sl->dev, "sllin_kwthread started.\n");
        sched_setscheduler(current, SCHED_FIFO, &schparam);
 
        clear_bit(SLF_ERROR, &sl->flags);
@@ -955,14 +954,14 @@ int sllin_kwthread(void *ptr)
                                && test_bit(SLF_MSGEVENT, &sl->flags)));
 
                if (test_and_clear_bit(SLF_RXEVENT, &sl->flags)) {
-                       pr_debug("sllin: sllin_kthread RXEVENT\n");
+                       netdev_dbg(sl->dev, "sllin_kthread RXEVENT\n");
                }
 
                if (test_and_clear_bit(SLF_ERROR, &sl->flags)) {
                        unsigned long usleep_range_min;
                        unsigned long usleep_range_max;
                        hrtimer_cancel(&sl->rx_timer);
-                       pr_debug("sllin: sllin_kthread ERROR\n");
+                       netdev_dbg(sl->dev, "sllin_kthread ERROR\n");
 
                        if (sl->lin_state != SLSTATE_IDLE)
                                sllin_report_error(sl, LIN_ERR_FRAMING);
@@ -976,11 +975,11 @@ int sllin_kwthread(void *ptr)
                }
 
                if (test_and_clear_bit(SLF_TXEVENT, &sl->flags)) {
-                       pr_debug("sllin: sllin_kthread TXEVENT\n");
+                       netdev_dbg(sl->dev, "sllin_kthread TXEVENT\n");
                }
 
                if (test_and_clear_bit(SLF_TMOUTEVENT, &sl->flags)) {
-                       pr_debug("sllin: sllin_kthread TMOUTEVENT\n");
+                       netdev_dbg(sl->dev, "sllin_kthread TMOUTEVENT\n");
                        sllin_reset_buffs(sl);
 
                        sl->lin_state = SLSTATE_IDLE;
@@ -998,17 +997,17 @@ int sllin_kwthread(void *ptr)
                                unsigned long flags;
                                struct sllin_conf_entry *sce;
 
-                               pr_debug("sllin: %s: RTR SFF CAN frame, ID = %x\n",
+                               netdev_dbg(sl->dev, "%s: RTR SFF CAN frame, ID = %x\n",
                                        __func__, cf->can_id & LIN_ID_MASK);
 
                                sce = &sl->linfr_cache[cf->can_id & LIN_ID_MASK];
                                spin_lock_irqsave(&sl->linfr_lock, flags);
 
                                /* Is there Slave response in linfr_cache to be sent? */
-                               if ((sce->frame_fl & LIN_LOC_SLAVE_CACHE)
+                               if ((sce->frame_fl & LIN_CACHE_RESPONSE)
                                        && (sce->dlc > 0)) {
 
-                                       pr_debug("sllin: Sending LIN response from linfr_cache\n");
+                                       netdev_dbg(sl->dev, "Sending LIN response from linfr_cache\n");
 
                                        lin_data = sce->data;
                                        lin_dlc = sce->dlc;
@@ -1023,7 +1022,7 @@ int sllin_kwthread(void *ptr)
                                spin_unlock_irqrestore(&sl->linfr_lock, flags);
 
                        } else { /* SFF NON-RTR CAN frame -> LIN header + LIN response */
-                               pr_debug("sllin: %s: NON-RTR SFF CAN frame, ID = %x\n",
+                               netdev_dbg(sl->dev, "%s: NON-RTR SFF CAN frame, ID = %x\n",
                                        __func__, (int)cf->can_id & LIN_ID_MASK);
 
                                lin_data = cf->data;
@@ -1095,7 +1094,7 @@ slstate_response_wait:
                                lin_buff = (sl->lin_master) ? sl->tx_buff : sl->rx_buff;
                                if (cf->can_id == (lin_buff[SLLIN_BUFF_ID] & LIN_ID_MASK)) {
                                        hrtimer_cancel(&sl->rx_timer);
-                                       pr_debug("sllin: received LIN response in a CAN frame.\n");
+                                       netdev_dbg(sl->dev, "received LIN response in a CAN frame.\n");
                                        if (sllin_setup_msg(sl, SLLIN_STPMSG_RESPONLY,
                                                cf->can_id & LIN_ID_MASK,
                                                cf->data, cf->can_dlc) != -1) {
@@ -1128,16 +1127,15 @@ slstate_response_wait:
                                continue;
 
                        hrtimer_cancel(&sl->rx_timer);
-                       pr_debug("sllin: response received ID %d len %d\n",
+                       netdev_dbg(sl->dev, "response received ID %d len %d\n",
                                sl->rx_buff[SLLIN_BUFF_ID], sl->rx_cnt - SLLIN_BUFF_DATA - 1);
 
                        if (sllin_rx_validate(sl) == -1) {
-                               pr_debug("sllin: RX validation failed.\n");
+                               netdev_dbg(sl->dev, "RX validation failed.\n");
                                sllin_report_error(sl, LIN_ERR_CHECKSUM);
                        } else {
                                /* Send CAN non-RTR frame with data */
-                               pr_debug("sllin: sending NON-RTR CAN"
-                                       "frame with LIN payload.");
+                               netdev_dbg(sl->dev, "sending NON-RTR CAN frame with LIN payload.");
                                sll_bump(sl); /* send packet to the network layer */
                        }
 
@@ -1152,7 +1150,7 @@ slstate_response_sent:
 
                        hrtimer_cancel(&sl->rx_timer);
                        sll_bump(sl); /* send packet to the network layer */
-                       pr_debug("sllin: response sent ID %d len %d\n",
+                       netdev_dbg(sl->dev, "response sent ID %d len %d\n",
                                sl->rx_buff[SLLIN_BUFF_ID], sl->rx_cnt - SLLIN_BUFF_DATA - 1);
 
                        sl->id_to_send = false;
@@ -1162,7 +1160,7 @@ slstate_response_sent:
        }
 
        hrtimer_cancel(&sl->rx_timer);
-       pr_debug("sllin: sllin_kwthread stopped.\n");
+       netdev_dbg(sl->dev, "sllin_kwthread stopped.\n");
 
        return 0;
 }
@@ -1257,6 +1255,7 @@ static int sllin_open(struct tty_struct *tty)
 {
        struct sllin *sl;
        int err;
+
        pr_debug("sllin: %s() invoked\n", __func__);
 
        if (!capable(CAP_NET_ADMIN))
@@ -1294,12 +1293,10 @@ static int sllin_open(struct tty_struct *tty)
        if (!test_bit(SLF_INUSE, &sl->flags)) {
                /* Perform the low-level SLLIN initialization. */
                sl->lin_master = master;
-#ifdef DEBUG
                if (master)
                        pr_debug("sllin: Configured as MASTER\n");
                else
                        pr_debug("sllin: Configured as SLAVE\n");
-#endif
 
                sllin_reset_buffs(sl);
 
@@ -1433,14 +1430,14 @@ static int __init sllin_init(void)
 
        sllin_devs = kzalloc(sizeof(struct net_device *)*maxdev, GFP_KERNEL);
        if (!sllin_devs) {
-               printk(KERN_ERR "sllin: can't allocate sllin device array!\n");
+               pr_err("sllin: can't allocate sllin device array!\n");
                return -ENOMEM;
        }
 
        /* Fill in our line protocol discipline, and register it */
        status = tty_register_ldisc(N_SLLIN, &sll_ldisc);
        if (status)  {
-               printk(KERN_ERR "sllin: can't register line discipline\n");
+               pr_err("sllin: can't register line discipline\n");
                kfree(sllin_devs);
        }
 
@@ -1496,8 +1493,7 @@ static void __exit sllin_exit(void)
 
                sl = netdev_priv(dev);
                if (sl->tty) {
-                       printk(KERN_ERR "%s: tty discipline still running\n",
-                              dev->name);
+                       netdev_dbg(sl->dev, "tty discipline still running\n");
                        /* Intentionally leak the control block. */
                        dev->destructor = NULL;
                }
@@ -1510,7 +1506,7 @@ static void __exit sllin_exit(void)
 
        i = tty_unregister_ldisc(N_SLLIN);
        if (i)
-               printk(KERN_ERR "sllin: can't unregister ldisc (err %d)\n", i);
+               pr_err("sllin: can't unregister ldisc (err %d)\n", i);
 }
 
 module_init(sllin_init);