]> rtime.felk.cvut.cz Git - linux-imx.git/commit
x86, kmmio/mmiotrace: Fix double free of kmmio_fault_pages
authorMarcin Slusarz <marcin.slusarz@gmail.com>
Sun, 13 Jun 2010 21:56:54 +0000 (23:56 +0200)
committerIngo Molnar <mingo@elte.hu>
Fri, 18 Jun 2010 09:30:09 +0000 (11:30 +0200)
commit8b8f79b927b6b302bb65fb8c56e7a19be5fbdbef
tree5e8cdb23232975f55661998956eb45c3e793a7c6
parent7e27d6e778cd87b6f2415515d7127eba53fe5d02
x86, kmmio/mmiotrace: Fix double free of kmmio_fault_pages

After every iounmap mmiotrace has to free kmmio_fault_pages, but
it can't do it directly, so it defers freeing by RCU.

It usually works, but when mmiotraced code calls ioremap-iounmap
multiple times without sleeping between (so RCU won't kick in
and start freeing) it can be given the same virtual address, so
at every iounmap mmiotrace will schedule the same pages for
release. Obviously it will explode on second free.

Fix it by marking kmmio_fault_pages which are scheduled for
release and not adding them second time.

Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Tested-by: Marcin Kocielnicki <koriakin@0x04.net>
Tested-by: Shinpei KATO <shinpei@il.is.s.u-tokyo.ac.jp>
Acked-by: Pekka Paalanen <pq@iki.fi>
Cc: Stuart Bennett <stuart@freedesktop.org>
Cc: Marcin Kocielnicki <koriakin@0x04.net>
Cc: nouveau@lists.freedesktop.org
Cc: <stable@kernel.org>
LKML-Reference: <20100613215654.GA3829@joi.lan>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
arch/x86/mm/kmmio.c
arch/x86/mm/testmmiotrace.c