]> rtime.felk.cvut.cz Git - linux-imx.git/commit
Btrfs: only do the tree_mod_log_free_eb if this is our last ref
authorJosef Bacik <jbacik@fusionio.com>
Mon, 1 Jul 2013 20:10:16 +0000 (16:10 -0400)
committerJosef Bacik <jbacik@fusionio.com>
Tue, 2 Jul 2013 15:51:20 +0000 (11:51 -0400)
commit7fb7d76f96bfcbea25007d190ba828b18e13d29d
tree398fdd51ec1de1b298eafe0f46419520c7a2b2ee
parentf1ca7e98a67da618d8595866e0860308525154da
Btrfs: only do the tree_mod_log_free_eb if this is our last ref

There is another bug in the tree mod log stuff in that we're calling
tree_mod_log_free_eb every single time a block is cow'ed.  The problem with this
is that if this block is shared by multiple snapshots we will call this multiple
times per block, so if we go to rewind the mod log for this block we'll BUG_ON()
in __tree_mod_log_rewind because we try to rewind a free twice.  We only want to
call tree_mod_log_free_eb if we are actually freeing the block.  With this patch
I no longer hit the panic in __tree_mod_log_rewind.  Thanks,

Cc: stable@vger.kernel.org
Reviewed-by: Jan Schmidt <list.btrfs@jan-o-sch.net>
Signed-off-by: Josef Bacik <jbacik@fusionio.com>
fs/btrfs/ctree.c