From: Jan Kiszka Date: Thu, 16 Jun 2016 08:30:49 +0000 (+0200) Subject: arm: Remove unused return code of irqchip_set_pending X-Git-Url: http://rtime.felk.cvut.cz/gitweb/jailhouse.git/commitdiff_plain/f5dcc13bcf89d190d35b99cf79a8586ea7c1a93d?hp=b77b9793126fd278ec3839cbead5bf21a389bdd0 arm: Remove unused return code of irqchip_set_pending No caller evaluated it so far, and none of them has a use case for it. Signed-off-by: Jan Kiszka --- diff --git a/hypervisor/arch/arm/include/asm/irqchip.h b/hypervisor/arch/arm/include/asm/irqchip.h index 8b4b035..c4b8289 100644 --- a/hypervisor/arch/arm/include/asm/irqchip.h +++ b/hypervisor/arch/arm/include/asm/irqchip.h @@ -86,7 +86,7 @@ void irqchip_eoi_irq(u32 irqn, bool deactivate); void irqchip_inject_pending(struct per_cpu *cpu_data); int irqchip_insert_pending(struct per_cpu *cpu_data, struct pending_irq *irq); int irqchip_remove_pending(struct per_cpu *cpu_data, struct pending_irq *irq); -int irqchip_set_pending(struct per_cpu *cpu_data, u32 irq_id, bool try_inject); +void irqchip_set_pending(struct per_cpu *cpu_data, u32 irq_id, bool try_inject); bool spi_in_cell(struct cell *cell, unsigned int spi); diff --git a/hypervisor/arch/arm/irqchip.c b/hypervisor/arch/arm/irqchip.c index 1e2a4e4..7ace354 100644 --- a/hypervisor/arch/arm/irqchip.c +++ b/hypervisor/arch/arm/irqchip.c @@ -129,16 +129,16 @@ int irqchip_insert_pending(struct per_cpu *cpu_data, struct pending_irq *irq) return 0; } -int irqchip_set_pending(struct per_cpu *cpu_data, u32 irq_id, bool try_inject) +void irqchip_set_pending(struct per_cpu *cpu_data, u32 irq_id, bool try_inject) { struct pending_irq pending; pending.virt_id = irq_id; if (try_inject && irqchip.inject_irq(cpu_data, &pending) == 0) - return 0; + return; - return irqchip_insert_pending(cpu_data, &pending); + irqchip_insert_pending(cpu_data, &pending); } /*