]> rtime.felk.cvut.cz Git - git.git/commit
read_and_strip_branch: fix typo'd address-of operator
authorJeff King <peff@peff.net>
Wed, 28 Jan 2015 17:57:35 +0000 (12:57 -0500)
committerJunio C Hamano <gitster@pobox.com>
Wed, 28 Jan 2015 20:42:44 +0000 (12:42 -0800)
commit66ec904b4e5779c2ffd68d3bb8071cc15b2287c7
tree8836ceeb5e3f7e2c2c69d087110451f23f3ce733
parent8b87cfd000c7c98f58279cff698f6e8c7892c059
read_and_strip_branch: fix typo'd address-of operator

When we are chomping newlines from the end of a strbuf, we
must check "sb.len != 0" before accessing "sb.buf[sb.len - 1]".
However, this code mistakenly checks "&sb.len", which is
always true (it is a part of an auto struct, so the address
is always non-zero). This could lead to us accessing memory
outside the strbuf when we read an empty file.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
wt-status.c