From 29d5b79b739f88b78d997b4c9a9d7b4bc9e9ff09 Mon Sep 17 00:00:00 2001 From: "Arnout Vandecappelle (Essensium/Mind)" Date: Tue, 6 Feb 2018 22:40:59 +0100 Subject: [PATCH] utils/genrandconfig: check core-dependencies When generating a random configuration, also check the host dependencies for that configuration and error out if it fails. This is mainly intended for the autobuilders, so they don't try to build a configuration for which the necessary host packages are not installed. Instead of erroring out, we could also generate a different random config. However: - When called for the autobuilders, the autobuild-run script will anyway just attempt another build. The only difference is that a warning will be printed in this autobuild log now. This warning is in fact quite useful to hint that the autobuilder could benefit from intalling this additional host package. - When called manually, the user may in fact want to install the missing host package and continue with the saved random config. Fixes: http://autobuild.buildroot.net/results/d7c/d7c12e873a71fef1e0b5e19cfad45024050614e1 http://autobuild.buildroot.net/results/a0a/a0a105c1ec2d0517112b02932a85831d4b597b9f http://autobuild.buildroot.net/results/96c/96cc6cedc64c777e993671204809599a1498472a and many others... Cc: Thomas Petazzoni Signed-off-by: Arnout Vandecappelle (Essensium/Mind) Signed-off-by: Thomas Petazzoni --- utils/genrandconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/utils/genrandconfig b/utils/genrandconfig index 883322552c..0d08570bc5 100755 --- a/utils/genrandconfig +++ b/utils/genrandconfig @@ -401,7 +401,8 @@ def gen_config(args): subprocess.check_call(["make", "O=%s" % args.outputdir, "-C", args.buildrootdir, "savedefconfig"]) - return 0 + return subprocess.call(["make", "O=%s" % args.outputdir, "-C", args.buildrootdir, + "core-dependencies"]) if __name__ == '__main__': -- 2.39.2