]> rtime.felk.cvut.cz Git - coffee/buildroot.git/commit
package/libsoil: fix build using old versions of patch
authorRicardo Martincoski <ricardo.martincoski@gmail.com>
Sun, 24 Jan 2016 13:19:52 +0000 (11:19 -0200)
committerThomas Petazzoni <thomas.petazzoni@free-electrons.com>
Mon, 25 Jan 2016 22:34:30 +0000 (23:34 +0100)
commit8461906db4e5c1af84bf99458e9905a6d4d58c3e
treebe9a6ebbba68978d333e6c313d6064c97c99af3f
parentacf3785e8fe9031a083cd086a28b69caeffd7dd7
package/libsoil: fix build using old versions of patch

Well-formed patch fails to apply
- patch v2.6:
Hunk #1 FAILED at 1.
Hunk #2 FAILED at 23.
- patch v2.6.1:
can't find file to patch at input line 11
Perhaps you used the wrong -p or --strip option?
[snip]
No file to patch.  Skipping patch.
2 out of 2 hunks ignored
Patch failed!  Please fix 0001-fix-makefile.patch!

Old versions of the tool "patch" cannot handle spaces in filenames.
The same does not occur using "patch" v2.7 or any later.

Workaround: when a file with space in the name needs to be patched,
one or two hooks must be used.
A pre-patch or post-extract hook renames the file to replace spaces
with underscores.
The patch file must be generated using diff between two source-trees
that have the file renamed with spaces replaced by underscores.
A post-patch hook could rename the file to its original name if needed.

Fixes:
http://autobuild.buildroot.net/results/8ff/8ff91ab8e52000eb34dd8f662520cf1b31490cf5/
http://autobuild.buildroot.net/results/ea7/ea77d6b23aca0cb1cf527e6c16ddf5eba957a69c/

Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
package/libsoil/0001-fix-makefile.patch
package/libsoil/libsoil.mk