]> rtime.felk.cvut.cz Git - coffee/buildroot.git/commit
core/reproducible: do not override SOURCE_DATE_EPOCH
authorYann E. MORIN <yann.morin.1998@free.fr>
Sun, 5 Nov 2017 09:14:56 +0000 (10:14 +0100)
committerPeter Korsgaard <peter@korsgaard.com>
Sun, 5 Nov 2017 10:43:19 +0000 (11:43 +0100)
commit0437d2f8f6ef8c10b529c154f4534453ce34607b
treef6daa59d04e851b221ec9a8110c91b3cdfa9ecb1
parent89d525186161d4651366379ac21e80eead6a754e
core/reproducible: do not override SOURCE_DATE_EPOCH

SOURCE_DATE_EPOCH is currently forcibly set (to either the git commit
date, or the last release date).

However, the spec mandates that it should not be modified if already
set: https://reproducible-builds.org/specs/source-date-epoch/

    Build systems MUST NOT overwrite this variable for child
    processes to consume if it is already present.

Abide by the rule, and only set it if not already set.

This will allow users to pass it from an upper-layer buildsystem (e.g. a
jenkins or gitlab-ci job, for example), when they have a reson to do so.

Reported-by: Peter Korsgaard <peter@korsgaard.com>
Reported-by: Einar Jón Gunnarsson <tolvupostur@gmail.com>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Peter Korsgaard <peter@korsgaard.com>
Cc: Einar Jón Gunnarsson <tolvupostur@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Arnout Vandecappelle <arnout@mind.be>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Makefile