]> rtime.felk.cvut.cz Git - can-eth-gw-linux.git/log
can-eth-gw-linux.git
11 years agoiio: adc: Add Texas Instruments ADC081C021/027 support
Thierry Reding [Fri, 23 Nov 2012 15:13:00 +0000 (15:13 +0000)]
iio: adc: Add Texas Instruments ADC081C021/027 support

Add support for reading conversion results from the ADC and provide them
through a single IIO channel. A proper scaling factor is also exported
based on the reference voltage provided by a regulator.

Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio:ad7793: Add support for the ad7796 and ad7797
Lars-Peter Clausen [Wed, 21 Nov 2012 16:27:00 +0000 (16:27 +0000)]
iio:ad7793: Add support for the ad7796 and ad7797

The ad7796 and ad7797 are similar to the ad7792 and ad7793 but only have a
single differential input instead of two. Also some other features are missing
like the programmable gain amplifier and also not all sampling frequencies
supported by the ad7792/ad7793 are supported by the ad7796/ad7797. This patch
adds new feature flags for the features not present in the ad7796/ad7797. The
patch also adds a struct iio_info field to the chip_info struct, this becomes
necessary since the ad7796/ad7797 needs a special set of sysfs attributes.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio:ad7793: Add support for the ad7798 and ad7799
Lars-Peter Clausen [Wed, 21 Nov 2012 16:27:00 +0000 (16:27 +0000)]
iio:ad7793: Add support for the ad7798 and ad7799

The ad7798 and ad7799 are similar to the ad7792 and ad7793 but are missing some
features like the temperature sensor, being able to use an external clocksource
and a few other things. This patch adds a new 'flags' fields to the chip_info
struct which allows to specify which features a certain chip variant supports.
The setup code will then ignore any platform data fields which are related to
non supported features.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agostaging:iio: Move ad7793 driver out of staging
Lars-Peter Clausen [Wed, 21 Nov 2012 16:27:00 +0000 (16:27 +0000)]
staging:iio: Move ad7793 driver out of staging

The driver does not expose any custom API to userspace and none of the standard
static code checker tools report any issues, so move it out of staging.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agostaging:iio:ad7793: Implement stricter id checking
Lars-Peter Clausen [Wed, 21 Nov 2012 16:27:00 +0000 (16:27 +0000)]
staging:iio:ad7793: Implement stricter id checking

Instead of checking whether the id of the current device matches the id of any
device supported by the driver, check whether it matches the id of the device
which the driver was instantiated for. This makes sure that the driver is not
accidentally instantiated for the wrong device.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agostaging:iio:ad7793: Move register definitions from header to source
Lars-Peter Clausen [Wed, 21 Nov 2012 16:27:00 +0000 (16:27 +0000)]
staging:iio:ad7793: Move register definitions from header to source

The only user of the register definitions is the driver itself, so move them
from the header file to the driver source file. The header file now only
contains the platform data struct.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agostaging:iio:ad7793: Rework regulator handling
Lars-Peter Clausen [Wed, 21 Nov 2012 16:27:00 +0000 (16:27 +0000)]
staging:iio:ad7793: Rework regulator handling

Rework the regulator handling of the driver to match more closely what we do in
other drivers. Make the regulator non-optional if a external reference is used.
Also dispose the option of specifying the reference voltage via platform data.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agostaging:iio:ad7793: Rework platform data
Lars-Peter Clausen [Wed, 21 Nov 2012 16:27:00 +0000 (16:27 +0000)]
staging:iio:ad7793: Rework platform data

Currently the platform data for the ad7793 consist just out of the raw default
register settings. This has some downsides, for one we actually don't want to
make all bits configurable and secondly not all register settings are actually
valid. This patch exposes all the options which should be configurable via
platform data as induvidual platform data struct fields. This also allows us to
document the different settings via proper kernel doc.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agostaging:iio:ad7793: Use kstrtol instead of strict_strtol
Lars-Peter Clausen [Wed, 21 Nov 2012 16:27:00 +0000 (16:27 +0000)]
staging:iio:ad7793: Use kstrtol instead of strict_strtol

strict_strtol is deprecated in favor of kstrtol.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agostaging:iio:ad7793: Use usleep_range instead of msleep
Lars-Peter Clausen [Wed, 21 Nov 2012 16:27:00 +0000 (16:27 +0000)]
staging:iio:ad7793: Use usleep_range instead of msleep

It is recommended to use usleep_range instead of msleep for durations smaller
than a 20ms.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agostaging:iio:ad7793: Fix temperature scale
Lars-Peter Clausen [Wed, 21 Nov 2012 16:27:00 +0000 (16:27 +0000)]
staging:iio:ad7793: Fix temperature scale

The temperature scale was off by a factor of 1000.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agostaging:iio:ad7793: Fix VDD monitor scale
Lars-Peter Clausen [Wed, 21 Nov 2012 16:27:00 +0000 (16:27 +0000)]
staging:iio:ad7793: Fix VDD monitor scale

The VDD monitor scale was off by a factor of 10.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agostaging: gdm72xx: unlock on error in init_usb()
Dan Carpenter [Thu, 29 Nov 2012 14:17:25 +0000 (17:17 +0300)]
staging: gdm72xx: unlock on error in init_usb()

We recently added locking here and there was an error path which is
missing an unlock.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: panel: pass correct lengths to keypad_send_key()
Dan Carpenter [Thu, 29 Nov 2012 14:38:35 +0000 (17:38 +0300)]
staging: panel: pass correct lengths to keypad_send_key()

We changed the sizeof() statements in 429ccf058b "staging:panel: Fixed
coding conventions." so that they could fit inside the 80 character
line limit.  Unfortunately, the new sizeof() statements are a smaller
size.  This reverts it.

There isn't a nice way to stay within the 80 character limit without
a re-work so I've gone over.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: addi_apci_2032: fix interrupt support
H Hartley Sweeten [Fri, 30 Nov 2012 01:21:24 +0000 (18:21 -0700)]
staging: comedi: addi_apci_2032: fix interrupt support

This board supports two interrupt sources:

VCC : detects when the external supply voltage drops below 5V
CC  : over temperature diagnostic

Currently the interrupt support is tied into the digital output
subdevice. It's also broken since it does not follow the comedi
API.

Create a new digital input subdevice to handle the interrupts.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: addi_apci_2032: move i_APCI2032_ConfigDigitalOutput()
H Hartley Sweeten [Fri, 30 Nov 2012 01:21:06 +0000 (18:21 -0700)]
staging: comedi: addi_apci_2032: move i_APCI2032_ConfigDigitalOutput()

For aesthetic reasons, move this function.

This function has nothing to do with the digital outputs. It's used
to enable the interrupt sources that the board can generate.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: addi_apci_2032: remove the timer s->range_table
H Hartley Sweeten [Fri, 30 Nov 2012 01:20:50 +0000 (18:20 -0700)]
staging: comedi: addi_apci_2032: remove the timer s->range_table

The timer subdevice does not have a digital range. Its range of
0 to 0xff is the value used to set the reload timer.

Remove the setting of s->range_table. The comedi core will then
set it to range_unknown.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: addi_apci_2032: cleanup the subdevice init
H Hartley Sweeten [Fri, 30 Nov 2012 01:20:35 +0000 (18:20 -0700)]
staging: comedi: addi_apci_2032: cleanup the subdevice init

For aesthetic reasons, add some whitespace to the subdevice init.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: addi_apci_2032: fix the watchdog timer subdevice
H Hartley Sweeten [Fri, 30 Nov 2012 01:20:19 +0000 (18:20 -0700)]
staging: comedi: addi_apci_2032: fix the watchdog timer subdevice

The watchdog timer on this board functions exactly like the one on
the apci_1516 board. Fix the i_APCI2032_StartStopWriteWatchdog and
i_APCI2032_ConfigWatchdo functions so that the watchdog follows the
comedi API.

Rename the CamelCase function i_APCI2032_StartStopWriteWatchdog to
apci2032_wdog_insn_writ. This function is used to "ping" the watchdog.

Rename the CamelCase function i_APCI2032_ConfigWatchdog to
apci2032_wdog_insn_config. This function is used to enable/disable
the watchdog and set the timeout.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: addi_apci_2032: remove need for addi-data/addi_common.h
H Hartley Sweeten [Fri, 30 Nov 2012 01:20:04 +0000 (18:20 -0700)]
staging: comedi: addi_apci_2032: remove need for addi-data/addi_common.h

Only the ADDIDATA_ENABLE define is used from this header. Just
open-code the value to remove the dependency and remove the include.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: addi_apci_2032: remove use of struct addi_private
H Hartley Sweeten [Fri, 30 Nov 2012 01:19:41 +0000 (18:19 -0700)]
staging: comedi: addi_apci_2032: remove use of struct addi_private

The only data in addi_private used in this driver is:

tsk_Current - used with send_sig to signal userspace when an interrupt
has occurred. Interrupt support in this driver does not follow the
standard comedi API so this functionality is currently broken. This
will be addressed.

b_OutputMemoryStatus - used in the addi-data "common" code to enable
reading of the eeprom. Eeprom support is not needed by this driver
and has been removed.

Since this data is not needed, remove the use of struct addi_private.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: addi_apci_2032: fix i_APCI2032_ReadWatchdog()
H Hartley Sweeten [Fri, 30 Nov 2012 01:19:25 +0000 (18:19 -0700)]
staging: comedi: addi_apci_2032: fix i_APCI2032_ReadWatchdog()

This function is used by the watchdog subdevice to read the status of
the watchdog. Rename the CamelCase function to apci2032_wdog_insn_read
and fix the function to return the status value insn->n times like
the comedi core expects.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: addi_apci_2032: cleanup register map defines
H Hartley Sweeten [Fri, 30 Nov 2012 01:19:07 +0000 (18:19 -0700)]
staging: comedi: addi_apci_2032: cleanup register map defines

Cleanup the defines a bit and add the missing information for the
bits in the registers.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: addi_apci_2032: merge in hwdrv_apci2032.c
H Hartley Sweeten [Fri, 30 Nov 2012 01:18:51 +0000 (18:18 -0700)]
staging: comedi: addi_apci_2032: merge in hwdrv_apci2032.c

Merge the code from hwdrv_apci2032.c into the driver and delete the
now unused file.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: addi_apci_2032: cleanup the s->subdev_flags
H Hartley Sweeten [Fri, 30 Nov 2012 01:18:35 +0000 (18:18 -0700)]
staging: comedi: addi_apci_2032: cleanup the s->subdev_flags

The flags SDF_GROUND and SDF_COMMON only have meaning for analog
input/output subdevices. Remove these flags from the digital
output and timer subdevices in this driver.

The digital output subdevice does not need the SDF_READABLE flag.
Remove it.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: addi_apci_2032: remove boardinfo
H Hartley Sweeten [Fri, 30 Nov 2012 01:18:19 +0000 (18:18 -0700)]
staging: comedi: addi_apci_2032: remove boardinfo

This driver only supports a single board type. Remove the boardinfo
and just use the information directly where used.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: addi_apci_2032: only allocate needed subdevices
H Hartley Sweeten [Fri, 30 Nov 2012 01:18:03 +0000 (18:18 -0700)]
staging: comedi: addi_apci_2032: only allocate needed subdevices

The addi-data "common" code always allocated 7 subdevices. This driver
only requires 2. Change the allocation and remove the unused subdevices.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: addi_apci_2032: remove use of devpriv->s_EeParameters
H Hartley Sweeten [Fri, 30 Nov 2012 01:17:47 +0000 (18:17 -0700)]
staging: comedi: addi_apci_2032: remove use of devpriv->s_EeParameters

This driver no longer reads the eeprom to find the board specific data,
all the necessary data is in the boardinfo. Use the boardinfo directly
instead of passing through devpriv->s_EeParameters.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: addi_apci_2032: don't read the unused PCI bars
H Hartley Sweeten [Fri, 30 Nov 2012 01:17:30 +0000 (18:17 -0700)]
staging: comedi: addi_apci_2032: don't read the unused PCI bars

This driver only uses PCI bar 1 (dev->iobase), doon't bother reading
the unused PCI bars.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: addi_apci_2032: remove devpriv->iobase usage
H Hartley Sweeten [Fri, 30 Nov 2012 01:17:15 +0000 (18:17 -0700)]
staging: comedi: addi_apci_2032: remove devpriv->iobase usage

The iobase address stored in devpriv->iobase is also stored in dev->iobase.
Use that instead.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: addi_apci_2032: remove unnecessary info from boardinfo
H Hartley Sweeten [Fri, 30 Nov 2012 01:17:00 +0000 (18:17 -0700)]
staging: comedi: addi_apci_2032: remove unnecessary info from boardinfo

The i_IorangeBase[012], i_PCIEeprom, and pc_EepromChip data in the
boardinfo was only needed to work out the usage of the PCI bars.
This is no longer needed so remove the data.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: addi_apci_2032: simplify the PCI bar reading
H Hartley Sweeten [Fri, 30 Nov 2012 01:16:45 +0000 (18:16 -0700)]
staging: comedi: addi_apci_2032: simplify the PCI bar reading

The board supported by this driver has a 93c76 eeprom. Knowing this
information allows simplifying the code that reads the PCI bars to
get the iobase address.

Also, since the 'dw_AiBase' is not ioremap'ed we can remove the iounmap
in the detach.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: addi_apci_2032: absorb i_APCI2032_Reset()
H Hartley Sweeten [Fri, 30 Nov 2012 01:16:27 +0000 (18:16 -0700)]
staging: comedi: addi_apci_2032: absorb i_APCI2032_Reset()

This is the only 'reset' function used by the driver, remove it
from the boardinfo and absorb the code from hwdrv_apci2032.c into
the driver.

Rename the CamelCase function i_ADDI_Reset() to apci2032_reset().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: addi_apci_2032: remove unnecessary include
H Hartley Sweeten [Fri, 30 Nov 2012 01:16:10 +0000 (18:16 -0700)]
staging: comedi: addi_apci_2032: remove unnecessary include

This include is no longer needed.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: addi_apci_2032: remove eeprom support code
H Hartley Sweeten [Fri, 30 Nov 2012 01:15:45 +0000 (18:15 -0700)]
staging: comedi: addi_apci_2032: remove eeprom support code

Reading the eeprom on the board supported by this driver is not
necessary. All the information required is in the boardinfo.

Remove the eeprom support code since it's not really interesting
or useful.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: addi_apci_2032: board does not have analog inputs
H Hartley Sweeten [Fri, 30 Nov 2012 01:15:28 +0000 (18:15 -0700)]
staging: comedi: addi_apci_2032: board does not have analog inputs

The board supported by this driver does not have analog inputs. Remove
the subdevice init for it.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: addi_apci_2032: board does not have analog outputs
H Hartley Sweeten [Fri, 30 Nov 2012 01:15:05 +0000 (18:15 -0700)]
staging: comedi: addi_apci_2032: board does not have analog outputs

The board supported by this driver does not have analog outputs. Remove
the subdevice init for it.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: addi_apci_2032: board does not have digital inputs
H Hartley Sweeten [Fri, 30 Nov 2012 01:14:48 +0000 (18:14 -0700)]
staging: comedi: addi_apci_2032: board does not have digital inputs

The board supported by this driver does not have digital inputs. Remove
the subdevice init for it.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: addi_apci_2032: board does not have ttl i/o
H Hartley Sweeten [Fri, 30 Nov 2012 01:14:31 +0000 (18:14 -0700)]
staging: comedi: addi_apci_2032: board does not have ttl i/o

The board supported by this driver does not have ttl i/o. Remove the
subdevice init for it.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: addi_apci_2032: separate from addi_common.c
H Hartley Sweeten [Fri, 30 Nov 2012 01:14:13 +0000 (18:14 -0700)]
staging: comedi: addi_apci_2032: separate from addi_common.c

This driver is for a simple 32 channel digital output board. Using the
addi-data "common" code introduces a lot of bloat.

Copy the code in addi_common.c to this driver and remove the #include
that caused addi_common.c to be compiled with this driver. This will
allow removing the bloat.

Rename the attach_pci and detach functions so they have namespace
associated with this driver.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: r8712u: Fix possible buffer overrun
Larry Finger [Tue, 27 Nov 2012 18:08:44 +0000 (12:08 -0600)]
staging: r8712u: Fix possible buffer overrun

In routine r8712_report_sec_ie(), the code could set the length
of the buffer to 256; however, that value is one larger than the
corresponding memory allocation.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: gdm72xx: use %pI4 format to print IPv4 address and remove last usage of...
Shan Wei [Wed, 28 Nov 2012 02:54:31 +0000 (10:54 +0800)]
staging: gdm72xx: use %pI4 format to print IPv4 address and remove last usage of NIP6

commit cf4ca4874fc45 removed the definition of NIPQUAD and NIPQUAD_FMT,
and NIP6 also is out of date.

commit 2874762b31d8d replace deprecated NIPQUAD marco to C code, but we can use %pI4 to
print IPv4 address more simply. And remove constant condition judge.

Because DEBUG_SDU is not defined in gdm_wimax.h, no error message when compiling.

Signed-off-by: Shan Wei <davidshan@tencent.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_rx.c
YAMANE Toshiaki [Wed, 28 Nov 2012 13:21:07 +0000 (22:21 +0900)]
staging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_rx.c

The following warnings fixed.
- WARNING: please, no spaces at the start of a line
- WARNING: please, no space before tabs

Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_rx.c
YAMANE Toshiaki [Wed, 28 Nov 2012 13:20:53 +0000 (22:20 +0900)]
staging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_rx.c

The following warnings fixed.
- WARNING: braces {} are not necessary for single statement blocks

Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/rtl8187se: Use netdev_ printks in ieee80211/ieee80211_rx.c
YAMANE Toshiaki [Wed, 28 Nov 2012 13:20:40 +0000 (22:20 +0900)]
staging/rtl8187se: Use netdev_ printks in ieee80211/ieee80211_rx.c

The following warnings fixed.
- WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then pr_debug(...  to printk(KERN_DEBUG ...
- WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then pr_warn(...  to printk(KERN_WARNING ...
- WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then pr_info(...  to printk(KERN_INFO ...

Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_rx.c
YAMANE Toshiaki [Wed, 28 Nov 2012 13:20:27 +0000 (22:20 +0900)]
staging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_rx.c

The following errors fixed.
- ERROR: "foo* bar" should be "foo *bar"

Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_rx.c
YAMANE Toshiaki [Wed, 28 Nov 2012 13:20:13 +0000 (22:20 +0900)]
staging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_rx.c

The following warnings fixed.
- ERROR: space required before the open parenthesis '('
- ERROR: that open brace { should be on the previous line
- ERROR: space required before the open brace '{'
- ERROR: else should follow close brace '}'
- ERROR: space prohibited before that close parenthesis ')'

Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_rx.c
YAMANE Toshiaki [Wed, 28 Nov 2012 13:19:59 +0000 (22:19 +0900)]
staging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_rx.c

The following warnings fixed.
-- ERROR: space required after that ',' (ctx:VxV)
-- ERROR: spaces required around that '&&' (ctx:VxV)
-- ERROR: space prohibited before that '++' (ctx:WxO)
-- ERROR: spaces required around that '?' (ctx:VxV)
-- ERROR: spaces required around that ':' (ctx:VxV)
-- ERROR: spaces required around that '!=' (ctx:VxW)
-- ERROR: need consistent spacing around '-' (ctx:WxV)
-- ERROR: spaces required around that '=' (ctx:VxW)
-- ERROR: spaces required around that '||' (ctx:ExV)

Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_rx.c
YAMANE Toshiaki [Wed, 28 Nov 2012 13:19:05 +0000 (22:19 +0900)]
staging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_rx.c

The following warnings fixed.
- WARNING: suspect code indent for conditional statements

Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/rtl8187se: Fix include file issue in ieee80211/ieee80211_rx.c
YAMANE Toshiaki [Wed, 28 Nov 2012 13:15:50 +0000 (22:15 +0900)]
staging/rtl8187se: Fix include file issue in ieee80211/ieee80211_rx.c

The following warning fixed.
- WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>

Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/rtl8187se: Use netdev_ printks in ieee80211/ieee80211_softmac_wx.c
YAMANE Toshiaki [Tue, 27 Nov 2012 12:10:14 +0000 (21:10 +0900)]
staging/rtl8187se: Use netdev_ printks in ieee80211/ieee80211_softmac_wx.c

The following warning fixed.
- WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then pr_info(...  to printk(KERN_INFO ...

Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_softmac_wx.c
YAMANE Toshiaki [Tue, 27 Nov 2012 12:10:00 +0000 (21:10 +0900)]
staging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_softmac_wx.c

The following wanings fixed.
- WARNING: please, no spaces at the start of a line

Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_softmac_wx.c
YAMANE Toshiaki [Tue, 27 Nov 2012 12:09:46 +0000 (21:09 +0900)]
staging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_softmac_wx.c

The following errors fixed.
- ERROR: spaces required around that '=' (ctx:VxV)

Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_softmac_wx.c
YAMANE Toshiaki [Tue, 27 Nov 2012 12:09:31 +0000 (21:09 +0900)]
staging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_softmac_wx.c

The following wanings fixed.
- WARNING: braces {} are not necessary for any arm of this statement

Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_softmac_wx.c
YAMANE Toshiaki [Tue, 27 Nov 2012 12:09:16 +0000 (21:09 +0900)]
staging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_softmac_wx.c

The following errors fixed.
- ERROR: space prohibited after that ',' (ctx:WxW)

Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_softmac_wx.c
YAMANE Toshiaki [Tue, 27 Nov 2012 12:09:02 +0000 (21:09 +0900)]
staging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_softmac_wx.c

The following warnings fixed.
- WARNING: suspect code indent for conditional statements

Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_softmac_wx.c
YAMANE Toshiaki [Tue, 27 Nov 2012 12:08:47 +0000 (21:08 +0900)]
staging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_softmac_wx.c

The following errors fixed.
- ERROR: space required before the open brace '{'
- ERROR: space required before the open parenthesis '('
- ERROR: space prohibited before that close parenthesis ')'
- ERROR: space required after that close brace '}'

Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_softmac_wx.c
YAMANE Toshiaki [Tue, 27 Nov 2012 12:07:45 +0000 (21:07 +0900)]
staging/rtl8187se: Fix spacing coding style in ieee80211/ieee80211_softmac_wx.c

The following errors fixed.
- ERROR: space prohibited after that '&' (ctx:WxW)

Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: gdm72xx: fix unused variable warning in gdm_usb_send
Ben Chan [Tue, 27 Nov 2012 04:18:45 +0000 (20:18 -0800)]
staging: gdm72xx: fix unused variable warning in gdm_usb_send

This patch fixes an unused variable warning in gdm_usb_send
(when CONFIG_WIMAX_GDM72XX_K_MODE=n), which was introduced in
commit 1a276b80466bbd195cf94ec7178f68f2ab351467 (staging:
gdm72xx: protect access of rx / tx structs).

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Ben Chan <benchan@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/fwserial: Fix build breakage when !CONFIG_BUG
Peter Hurley [Tue, 27 Nov 2012 14:30:45 +0000 (09:30 -0500)]
staging/fwserial: Fix build breakage when !CONFIG_BUG

Use WARN() as intended.

Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: remove unnecessary '#define __NO_VERSION__'
H Hartley Sweeten [Tue, 27 Nov 2012 00:34:29 +0000 (17:34 -0700)]
staging: comedi: remove unnecessary '#define __NO_VERSION__'

This define is no longer required for multi-file modules.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: remove unnecessary '#define _GNU_SOURCE'
H Hartley Sweeten [Tue, 27 Nov 2012 00:34:11 +0000 (17:34 -0700)]
staging: comedi: remove unnecessary '#define _GNU_SOURCE'

This define is not needed.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: vt6656: wpa_set_keys remove fcpfkernel
Malcolm Priestley [Sat, 24 Nov 2012 14:56:09 +0000 (14:56 +0000)]
staging: vt6656: wpa_set_keys remove fcpfkernel

Only TRUE is ever called, remove FALSE code.

Since copy_from_user has been removed, the unlock..lock spin locks have been removed.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: vt6656: send SIOCGIWSCAN at end of all scanning events.
Malcolm Priestley [Sat, 24 Nov 2012 14:53:07 +0000 (14:53 +0000)]
staging: vt6656: send SIOCGIWSCAN at end of all scanning events.

wpa supplicant can become confused if the scanning has ended on
active scanning.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: vt6656: extend wireless definitions to v22
Malcolm Priestley [Sat, 24 Nov 2012 14:50:00 +0000 (14:50 +0000)]
staging: vt6656: extend wireless definitions to v22

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: vt6656: remove redundant IWEVCUSTOM events.
Malcolm Priestley [Sat, 24 Nov 2012 14:47:11 +0000 (14:47 +0000)]
staging: vt6656: remove redundant IWEVCUSTOM events.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: vt6656: cleanup of device_ioctl/net_device_stats
Malcolm Priestley [Sat, 24 Nov 2012 14:44:29 +0000 (14:44 +0000)]
staging: vt6656: cleanup of device_ioctl/net_device_stats

Also remove IOCTL_CMD_TEST.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: vt6656: dead code remove ioctl.c/h
Malcolm Priestley [Sat, 24 Nov 2012 14:40:57 +0000 (14:40 +0000)]
staging: vt6656: dead code remove ioctl.c/h

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: vt6656: dead code removal : wpactl.c/h
Malcolm Priestley [Sat, 24 Nov 2012 14:36:12 +0000 (14:36 +0000)]
staging: vt6656: dead code removal : wpactl.c/h

Relates to redundant viawget, a proprietary version of wpa supplicant.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: vt6656: remove wpahdr from driver.
Malcolm Priestley [Sat, 24 Nov 2012 14:24:24 +0000 (14:24 +0000)]
staging: vt6656: remove wpahdr from driver.

wpahdr relates to redundant viawget, a proprietary version of wpa supplicant.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: vt6656: move move all commands to iw_handler.
Malcolm Priestley [Sat, 24 Nov 2012 14:22:08 +0000 (14:22 +0000)]
staging: vt6656: move move all commands to iw_handler.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: vt6656: fix headers and add cfg80211.
Malcolm Priestley [Sat, 24 Nov 2012 14:19:34 +0000 (14:19 +0000)]
staging: vt6656: fix headers and add cfg80211.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: ced1401: Fix typo in staging/ced1401
Masanari Iida [Thu, 22 Nov 2012 15:47:54 +0000 (00:47 +0900)]
staging: ced1401: Fix typo in staging/ced1401

Correct spelling typo in comments within staging/ced1401

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: ni_tio.h fixed coding style issue with pointer variables
Matt Phillips [Mon, 26 Nov 2012 05:53:21 +0000 (23:53 -0600)]
staging: comedi: ni_tio.h fixed coding style issue with pointer variables

Fixed coding style issues with pointers

Signed-off-by: Matt Phillips <mathewrphillips@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: gdm72xx: protect access of rx / tx structs
Ben Chan [Sun, 25 Nov 2012 03:35:36 +0000 (19:35 -0800)]
staging: gdm72xx: protect access of rx / tx structs

This patch applies spinlock to protect access to rx / tx structs in
certain call sites, which fixes the following crash in gdm_suspend.
It also fixes usb_set_intfdata() in gdm_usb_probe to avoid setting an
already freed phy_dev.

<5>[ 4996.815018] [<7f0074b0>] (gdm_suspend+0x1c/0x2b4 [gdmwm]) from [<803020a4>] (usb_suspend_both+0x80/0x1a0)
<5>[ 4996.815055] [<803020a4>] (usb_suspend_both+0x80/0x1a0) from [<80302c84>] (usb_runtime_suspend+0x38/0x64)
<5>[ 4996.815089] [<80302c84>] (usb_runtime_suspend+0x38/0x64) from [<802becc0>] (__rpm_callback+0x48/0x78)
<5>[ 4996.815118] [<802becc0>] (__rpm_callback+0x48/0x78) from [<802bf8dc>] (rpm_suspend+0x394/0x5ec)
<5>[ 4996.815145] [<802bf8dc>] (rpm_suspend+0x394/0x5ec) from [<802c0550>] (pm_runtime_work+0x8c/0xa4)
<5>[ 4996.815177] [<802c0550>] (pm_runtime_work+0x8c/0xa4) from [<800456cc>] (process_one_work+0x264/0x438)
<5>[ 4996.815209] [<800456cc>] (process_one_work+0x264/0x438) from [<80045acc>] (worker_thread+0x22c/0x3b8)
<5>[ 4996.815239] [<80045acc>] (worker_thread+0x22c/0x3b8) from [<8004a43c>] (kthread+0x9c/0xa8)
<5>[ 4996.815270] [<8004a43c>] (kthread+0x9c/0xa8) from [<8000f160>] (kernel_thread_exit+0x0/0x8)
<0>[ 4996.815295] Code: e92d4000 e8bd4000 e2800020 eb4ab9a1 (e5905000)

Signed-off-by: Ben Chan <benchan@chromium.org>
Signed-off-by: Sameer Nanda <snanda@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: ft1000: remove assigments of ret and initialise it in beginning
Devendra Naga [Sat, 24 Nov 2012 10:01:06 +0000 (05:01 -0500)]
staging: ft1000: remove assigments of ret and initialise it in beginning

as ret is every time assigned to EINVAL in fail cases, initialise it at
the beginning.

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: line6: drop unused dumprequest code
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:25 +0000 (20:49 +0100)]
staging: line6: drop unused dumprequest code

The line6 drive no longer requests MIDI dumps from the device so
dumprequest.c is not needed.

Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: line6: drop dump requests from pod startup
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:24 +0000 (20:49 +0100)]
staging: line6: drop dump requests from pod startup

The pod startup procedure dumps model data.  This is no longer useful
since the sysfs attrs which expose this information to userspace have
been removed.  The dump request wasn't been processed anymore.

Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: line6: drop dump requests from variax startup
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:23 +0000 (20:49 +0100)]
staging: line6: drop dump requests from variax startup

The variax startup procedure dumps model data.  This is no longer useful
since the sysfs attrs which expose this information to userspace have
been removed.  The dump request wasn't been processed anymore.

Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: line6: drop variax model_data field
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:22 +0000 (20:49 +0100)]
staging: line6: drop variax model_data field

The sysfs attrs to access the model dump have been removed so it's safe
to drop the model_data field.  The next step will be to simplify the
startup process since we no longer need to fetch this data via dump
requests, but that will be done in a later patch.

Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: line6: drop unused pod atomic_flags field
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:21 +0000 (20:49 +0100)]
staging: line6: drop unused pod atomic_flags field

Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: line6: drop pod prog_data buffers
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:20 +0000 (20:49 +0100)]
staging: line6: drop pod prog_data buffers

The driver no longer keeps state of MIDI-accessible device parameters.
Drop the buffers but be careful to keep the device startup procedure
working even though we no longer store the contents of the dump request.
The startup procedure will be simplified in a later patch.

Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: line6: drop MIDI parameter sysfs attrs
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:19 +0000 (20:49 +0100)]
staging: line6: drop MIDI parameter sysfs attrs

Both pod.c and variax.c expose the device's MIDI parameters as sysfs
attrs.  Knowledge of MIDI constants should be in userspace, not in the
driver.  Drop the sysfs attrs and let userspace interpret parameters it
cares about instead.

Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: line6: drop amp/effects dump request triggers
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:18 +0000 (20:49 +0100)]
staging: line6: drop amp/effects dump request triggers

Since the driver no longer needs to keep state of device parameters it
is no longer necessary to refresh state when messages that affect other
parameters are sent.  Drop the code to trigger a dump when amp/effects
are changed.

Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: line6: drop CONFIG_LINE6_USB_RAW
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:17 +0000 (20:49 +0100)]
staging: line6: drop CONFIG_LINE6_USB_RAW

Now that both pod.c and variax.c have removed their raw sysfs attrs, the
CONFIG_LINE6_USB_RAW config option can be dropped.  The drivers are
being stripped down to just PCM and MIDI I/O so there is less state and
filtering.  Therefore it's no longer necessary to have a special sysfs
attr to bypass the filtering ("raw").

Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: line6: drop variax raw sysfs attrs
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:16 +0000 (20:49 +0100)]
staging: line6: drop variax raw sysfs attrs

Note that VARIAX_SYSEX_ACTIVATE was never used so drop it along with the
other VARIAX_SYSEX_* constants which are now unused.

Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: line6: drop variax guitar sysfs attr
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:15 +0000 (20:49 +0100)]
staging: line6: drop variax guitar sysfs attr

Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: line6: drop variax active sysfs attr
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:14 +0000 (20:49 +0100)]
staging: line6: drop variax active sysfs attr

The get_string() function has no other callers so remove it too.

Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: line6: drop variax dump sysfs attr
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:13 +0000 (20:49 +0100)]
staging: line6: drop variax dump sysfs attr

Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: line6: drop variax bank sysfs attr
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:12 +0000 (20:49 +0100)]
staging: line6: drop variax bank sysfs attr

The get_string() function is no longer used so drop it too.

Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: line6: drop variax name sysfs attr
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:11 +0000 (20:49 +0100)]
staging: line6: drop variax name sysfs attr

Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: line6: drop variax tone sysfs attr
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:10 +0000 (20:49 +0100)]
staging: line6: drop variax tone sysfs attr

Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: line6: drop variax volume sysfs attr
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:09 +0000 (20:49 +0100)]
staging: line6: drop variax volume sysfs attr

Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: line6: drop variax model sysfs attr
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:08 +0000 (20:49 +0100)]
staging: line6: drop variax model sysfs attr

Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: line6: drop tuner param filtering
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:07 +0000 (20:49 +0100)]
staging: line6: drop tuner param filtering

The pod_set_system_param_int() helper function is only used to set the
monitor level.  Previously it was also used to control the tuner and has
special checks.  These checks can now be dropped, along with the tuner
constants.

Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: line6: drop pod.c raw sysfs attr
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:06 +0000 (20:49 +0100)]
staging: line6: drop pod.c raw sysfs attr

The raw sysfs attr transmits MIDI messages with less filtering.  This
was a useful debugging tool while the staging driver still had a lot of
state and filtering.  It is not useful anymore since the filtering is
being dropped.

Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: line6: drop midi_postprocess flag
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:05 +0000 (20:49 +0100)]
staging: line6: drop midi_postprocess flag

It is no longer necessary to trigger on MIDI transmit messages that will
change the state of the device since:

1. We've dropped the midi_postprocess sysfs attr in a previous commit so
   it is not possible to activate this feature anymore.

2. The other sysfs attrs that could inspect the state after a dump
   request have been dropped.

Therefore we can safely remove this dead code.

Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: line6: drop midi_mask_transmit
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:04 +0000 (20:49 +0100)]
staging: line6: drop midi_mask_transmit

The midi_mask_transmit sysfs attribute selects the MIDI channels on
which to transmit messages.  If ALSA wants to transmit a message that
does not match an allowed channel, the message will be dropped.  This
driver feature is not really used and applications don't know how to
take advantage of it.  Therefore we drop it and rely on applications or
MIDI sequencers to select the channels used for communication.

Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: line6: drop midi_mask_receive
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:03 +0000 (20:49 +0100)]
staging: line6: drop midi_mask_receive

The midi_mask_receive sysfs attribute selects the MIDI channels on which
to receive messages.  There is no need to do this at the driver level,
instead the MIDI application endpoints decide which channels to use.
Other drivers don't implement midi_mask_receive so applications cannot
make use of this feature.  Therefore we drop it as part of the effort to
clean up the staging driver.

Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: line6: drop midi_postprocess sysfs attr
Stefan Hajnoczi [Thu, 22 Nov 2012 19:49:02 +0000 (20:49 +0100)]
staging: line6: drop midi_postprocess sysfs attr

Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>